From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80CBEC19F2C for ; Mon, 1 Aug 2022 02:20:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238331AbiHACUc (ORCPT ); Sun, 31 Jul 2022 22:20:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229937AbiHACUb (ORCPT ); Sun, 31 Jul 2022 22:20:31 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 653FF644F; Sun, 31 Jul 2022 19:20:29 -0700 (PDT) Received: from dggpeml500023.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Lx1vd3xBTzWflP; Mon, 1 Aug 2022 10:16:29 +0800 (CST) Received: from dggpeml100012.china.huawei.com (7.185.36.121) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 1 Aug 2022 10:20:27 +0800 Received: from [10.67.103.212] (10.67.103.212) by dggpeml100012.china.huawei.com (7.185.36.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 1 Aug 2022 10:20:27 +0800 Subject: Re: [PATCH v6 2/3] Documentation: add a isolation strategy sysfs node for uacce To: Greg KH References: <20220730083246.55646-1-yekai13@huawei.com> <20220730083246.55646-3-yekai13@huawei.com> CC: , , , , From: "yekai (A)" Message-ID: <901896fa-2acc-127c-a8ea-8143cda47b1b@huawei.com> Date: Mon, 1 Aug 2022 10:20:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.103.212] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml100012.china.huawei.com (7.185.36.121) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/7/30 19:06, Greg KH wrote: > On Sat, Jul 30, 2022 at 04:32:45PM +0800, Kai Ye wrote: >> Update documentation describing sysfs node that could help to >> configure isolation strategy for users in the user space. And >> describing sysfs node that could read the device isolated state. >> >> Signed-off-by: Kai Ye >> --- >> Documentation/ABI/testing/sysfs-driver-uacce | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/Documentation/ABI/testing/sysfs-driver-uacce b/Documentation/ABI/testing/sysfs-driver-uacce >> index 08f2591138af..1601f9dac29c 100644 >> --- a/Documentation/ABI/testing/sysfs-driver-uacce >> +++ b/Documentation/ABI/testing/sysfs-driver-uacce >> @@ -19,6 +19,23 @@ Contact: linux-accelerators@lists.ozlabs.org >> Description: Available instances left of the device >> Return -ENODEV if uacce_ops get_available_instances is not provided >> >> +What: /sys/class/uacce//isolate_strategy >> +Date: Jul 2022 >> +KernelVersion: 5.20 >> +Contact: linux-accelerators@lists.ozlabs.org >> +Description: (RW) Configure the frequency size for the hardware error >> + isolation strategy. This size is a configured integer value. >> + The default is 0. The maximum value is 65535. This value is a >> + threshold based on your driver handling strategy. > what is a "driver handling strategy"? What exactly is this units in? > Any documentation for how to use this? > > thanks, > > greg k-h > . The unit is the number of times, also means frequency size. e.g. In the hisilicon acc engine, First we will time-stamp every slot AER error. Then check the AER error log when the device AER error occurred. if the device slot AER error count exceeds the preset the number of times in one hour, the isolated state will be set to true. So the device will be isolated. And the AER error log that exceed one hour will be cleared. Of course, different strategy can be defined in different drivers. thanks Kai