From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754099AbdFSNGk (ORCPT ); Mon, 19 Jun 2017 09:06:40 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44600 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752695AbdFSNGi (ORCPT ); Mon, 19 Jun 2017 09:06:38 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 92F6060706 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vivek.gautam@codeaurora.org Subject: Re: [PATCH v5 3/6] reset: hide reset control arrays behind struct reset_control To: Philipp Zabel References: <20170601165203.15315-1-p.zabel@pengutronix.de> <20170601165203.15315-4-p.zabel@pengutronix.de> <1497874713.2993.70.camel@pengutronix.de> Cc: linux-kernel@vger.kernel.org, Jon Hunter , Felipe Balbi , Greg Kroah-Hartman , Thierry Reding , linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org From: Vivek Gautam Message-ID: <901e927f-dde7-65ae-d9ef-27ab8e66f934@codeaurora.org> Date: Mon, 19 Jun 2017 18:36:32 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1497874713.2993.70.camel@pengutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philipp, On 06/19/2017 05:48 PM, Philipp Zabel wrote: > Hi Vivek, > > On Tue, 2017-06-13 at 12:16 +0530, Vivek Gautam wrote: > [...] >>> @@ -102,18 +94,6 @@ static inline struct reset_control *__devm_reset_control_get( >>> return optional ? NULL : ERR_PTR(-ENOTSUPP); >>> } >>> >>> -static inline >>> -int reset_control_array_assert(struct reset_control_array *resets) >>> -{ >>> - return 0; >>> -} >>> - >>> -static inline >>> -int reset_control_array_deassert(struct reset_control_array *resets) >>> -{ >>> - return 0; >>> -} >>> - >>> static inline struct reset_control_array * >> This has to return just 'struct reset_control *'. >> That should resolve kbuild errors. >> >> Rest looks good to me. >> Reviewed-by: Vivek Gautam > Thanks, I had already fixed this locally, prompted by the kbuild test > robot. I'll send a v6. I would like to merge this patch into the first > "reset: Add APIs to manage array of resets" patch, if that's ok with > you. Thanks. You are right. It makes more sense to merge these two patches if Jon finds it okay to put reset_control_array behind reset_control. I am cool with squashing this patch. Best regards Vivek > > regards > Philipp > -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project