From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752667AbcGMNTq (ORCPT ); Wed, 13 Jul 2016 09:19:46 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:49189 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133AbcGMNTh (ORCPT ); Wed, 13 Jul 2016 09:19:37 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: pochun lin , Tiffany Lin , linux-kernel@vger.kernel.org, Hans Verkuil , Matthias Brugger , linux-mediatek@lists.infradead.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: Re: [PATCH v2] [media] mtk-vcodec: fix more type mismatches Date: Wed, 13 Jul 2016 15:17:17 +0200 Message-ID: <9022784.B8ChAA686D@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-28-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1468407163.3555.1.camel@mtksdaap41> References: <20160713084916.2765651-1-arnd@arndb.de> <1468407163.3555.1.camel@mtksdaap41> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:RQ/U40ApNJ+TXyFAOFxOGxZAkoyXGYAd/NbP6hTnh9EdM31kCmg wcyF+5sYTOsZG7bR/7gH7NPYoch90edoKpfNyBJZ4oron3n7UkLqR7gfIvgnzU/ynY/y0yU Hx/c+MQeANvYers7KeUyVdrYkZm2/HxWYNtL/MPnKz8C22srZLKAptDdB36N5zus+EHYk6f znwpksEgoU6o+VreXXDHQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:UFHWmMZgUGM=:0NBtSPlk7zV6nzPHoCFTn7 +0qEse5jNXA5qbiv0CTupyCaI5oEaUIq7IgPcZayzgOfYN/30vhoB1bI54smL6Ao/QsQ1sT2s bPq3nhzOaVPNSUfSK5wisaleBeVTB5ajufmyuPTUNgkELgTxuuGahKh0PfUNPjnxtpHlYkqfG qeX9S+xpWYvZnugV7SYcqSwkXWDxIK4x2p3VJTc5NDKCXGbN74hE0HR0yVeM2Ynn5dvcDhWfL /siNlniKttTIgfCiKdYSREFkKvfUzrF8VD17x27+XpRIUH7hPseYKN+v6DgWrizfagyMN22YG d4y3OZ53cRDP7MKnuxmcKmFo3S661QUHT0mvRrPLkioEfaLOjDF2d7yFFJt3HkJkw5GxRXbmv aG+Su+JlFotWgVPZ+cyl7QJT+Y4xRemNmN4qPrwgw6AWTC9r/8MbeGzOlY7WrcNay2dUXbG11 0Fg+Fp00+aH/LjK9rWCMUAT8KEZNDjGn+A/a8mz+ZAe0C0Rq2/ZSm2yNLTHRqG6fY1myjI58J ZEiaowbrtMAjyyIFhNXgoGYC+LiL/n5oZJi8QQtjWOVWabzxK3VNsUJFB5ay75luwRPFq5rfn 7sAi6vP89LFoE3dp9qORfsHE0ytkL7TcKzML/CUw3uod/Idpk27+CnqDcPFuuzijXM5LpfGxC iczgm/rXojSxflaC/gDMMiMt9WolhRHEF9Zq/nsSLwugNQNIkNq/GO59Gvi/SkU9Sk0lpntbx uVrMLfyauqkqEg/d Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, July 13, 2016 6:52:43 PM CEST pochun lin wrote: > > diff --git a/drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c b/drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c > > index f4e18bb44cb9..9a600525b3c1 100644 > > --- a/drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c > > +++ b/drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c > > @@ -295,9 +295,9 @@ static int h264_enc_alloc_work_buf(struct venc_h264_inst *inst) > > wb[i].iova = inst->work_bufs[i].dma_addr; > > > > mtk_vcodec_debug(inst, > > - "work_buf[%d] va=0x%p iova=0x%p size=%zu", > > + "work_buf[%d] va=0x%p iova=%pad size=%zu", > > i, inst->work_bufs[i].va, > > - (void *)inst->work_bufs[i].dma_addr, > > + &inst->work_bufs[i].dma_addr, > > inst->work_bufs[i].size); > > } > > > > This modified will dump dma_addr's address, not dma_addr value. > In actually, we need to dump dma_addr value. According to Documentation/printk-formats.txt, it gets passed by reference: | DMA addresses types dma_addr_t: | | %pad 0x01234567 or 0x0123456789abcdef | | For printing a dma_addr_t type which can vary based on build options, | regardless of the width of the CPU data path. Passed by reference. The whole point of the %pad/%pr/%pM/... format strings is to print something that cannot be passed by value because the type is not a fixed-size integer. Arnd