From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CFD1C6FD18 for ; Tue, 25 Apr 2023 15:09:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234414AbjDYPJv (ORCPT ); Tue, 25 Apr 2023 11:09:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234318AbjDYPJu (ORCPT ); Tue, 25 Apr 2023 11:09:50 -0400 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCF13B0; Tue, 25 Apr 2023 08:09:48 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33PF9Kve069845; Tue, 25 Apr 2023 10:09:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1682435360; bh=1LkCUvUeAv3XL9tJ5+b1NKymuOQ2HqXUmXGnmBQmTNA=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=QY6/6UPpMfS2yR4t7nGA5TkbJ6DUUlvDvckeilPYZd6JklVVFPnd04JP0ON6Y09jK r+pGvM9r83FRMfaepPczK34PdbiGexK2gFnFoB+wi0B9cxyUQWOta4fAoc36I8da8r N7dXE4RG+DrP+nfihQoEhzsPgH7Rh7jzPqepvsIo= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33PF9K8U028033 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 25 Apr 2023 10:09:20 -0500 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Tue, 25 Apr 2023 10:09:20 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Tue, 25 Apr 2023 10:09:20 -0500 Received: from [10.250.35.77] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33PF9JR1030190; Tue, 25 Apr 2023 10:09:19 -0500 Message-ID: <90272486-864d-910c-a10b-4ba71a71f4b0@ti.com> Date: Tue, 25 Apr 2023 10:09:19 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 1/2] arm64: dts: ti: Add overlay for OLDI-LCD1EVM Display and touch screen To: Aradhya Bhatia , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Catalin Marinas , Will Deacon CC: Devicetree List , Linux Kernel List , Linux ARM Kernel List , Jyri Sarha , Tomi Valkeinen , Praneeth Bajjuri , Rahul T R , Devarsh Thakkar , Jai Luthra , Jayesh Choudhary References: <20230425051235.15533-1-a-bhatia1@ti.com> <20230425051235.15533-2-a-bhatia1@ti.com> Content-Language: en-US From: Andrew Davis In-Reply-To: <20230425051235.15533-2-a-bhatia1@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/25/23 12:12 AM, Aradhya Bhatia wrote: > From: Jyri Sarha > > The OLDI-LCD1EVM add on board has Rocktech RK101II01D-CT panel with > integrated touch screen. The integrated touch screen is Goodix GT928. > Add DT nodes for these and connect the endpoint nodes with DSS. > > This patch was picked from TI's public tree based on 5.10 LTS kernel. > > Signed-off-by: Jyri Sarha > Signed-off-by: Nikhil Devshatwar > [abhatia1@ti.com: Make syntax changes to support 6.1 DTSO format] > Signed-off-by: Aradhya Bhatia > --- > arch/arm64/boot/dts/ti/Makefile | 2 + > .../dts/ti/k3-am654-evm-oldi-lcd1evm.dtso | 70 +++++++++++++++++++ > 2 files changed, 72 insertions(+) > create mode 100644 arch/arm64/boot/dts/ti/k3-am654-evm-oldi-lcd1evm.dtso > > diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile > index 6acd12409d59..8956b19e587a 100644 > --- a/arch/arm64/boot/dts/ti/Makefile > +++ b/arch/arm64/boot/dts/ti/Makefile > @@ -26,6 +26,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-am6548-iot2050-advanced.dtb > dtb-$(CONFIG_ARCH_K3) += k3-am6548-iot2050-advanced-m2.dtb > dtb-$(CONFIG_ARCH_K3) += k3-am6548-iot2050-advanced-pg2.dtb > dtb-$(CONFIG_ARCH_K3) += k3-am654-base-board.dtb > +dtb-$(CONFIG_ARCH_K3) += k3-am654-evm-oldi-lcd1evm.dtbo This name is a bit odd, why "evm" twice? Looks like the first instance is the redundant one as most of the documents on this LCD board call it the "LCD1EVM". How about: k3-am654-lcd1evm.dtbo I would like the overlay names to give some hint to what base DTB they apply to, or better yet, apply them here in the build which will check that they apply cleanly. Plus you can drop the silly "+= -@" below. Let's see how this should be called, from the AM65x GP EVM doc[0] we get a nice picture on page 5 and the following: "The AM65x GP EVM consists of a common processor board, an LCD adapter, and a one-lane PCIe/USB3 personality card." So, this would translate to: k3-am654-gp-evm-dtbs := k3-am654-base-board.dtb k3-am654-lcd1evm.dtbo k3-am654-pcie-usb3.dtbo dtb-$(CONFIG_ARCH_K3) += k3-am654-gp-evm.dtb Next, from the AM65x IDK doc[1] also with a nice image on page 5: "The AM65x IDK consists of a common processor board, IDK application board, and a two-lane PCIe personality card.: So: k3-am654-idk-dtbs := k3-am654-base-board.dtb k3-am654-idk.dtbo k3-am654-pcie-usb2.dtbo dtb-$(CONFIG_ARCH_K3) += k3-am654-idk.dtb Note that we do have all those missing dtso files in our evil vendor tree[2] and will be upstreaming them next, so this naming should all work out nicely. Andrew [0] https://www.ti.com/lit/ug/spruim7/spruim7.pdf [1] https://www.ti.com/lit/ug/spruim6a/spruim6a.pdf [2] https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/tree/arch/arm64/boot/dts/ti?h=ti-linux-5.10.y > > # Boards with J7200 SoC > dtb-$(CONFIG_ARCH_K3) += k3-j7200-common-proc-board.dtb > @@ -45,3 +46,4 @@ dtb-$(CONFIG_ARCH_K3) += k3-j784s4-evm.dtb > > # Enable support for device-tree overlays > DTC_FLAGS_k3-am6548-iot2050-advanced-m2 += -@ > +DTC_FLAGS_k3-am654-base-board += -@ > diff --git a/arch/arm64/boot/dts/ti/k3-am654-evm-oldi-lcd1evm.dtso b/arch/arm64/boot/dts/ti/k3-am654-evm-oldi-lcd1evm.dtso > new file mode 100644 > index 000000000000..b2c790b314cf > --- /dev/null > +++ b/arch/arm64/boot/dts/ti/k3-am654-evm-oldi-lcd1evm.dtso > @@ -0,0 +1,70 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/** > + * OLDI-LCD1EVM Rocktech integrated panel and touch DT overlay for AM654-EVM. > + * > + * Copyright (C) 2023 Texas Instruments Incorporated - http://www.ti.com/ > + */ > + > +/dts-v1/; > +/plugin/; > + > +#include > +#include > +#include > + > +&{/} { > + display0 { > + compatible = "rocktech,rk101ii01d-ct"; > + backlight = <&lcd_bl>; > + enable-gpios = <&pca9555 8 GPIO_ACTIVE_HIGH>; > + port { > + lcd_in0: endpoint { > + remote-endpoint = <&oldi_out0>; > + }; > + }; > + }; > + > + lcd_bl: backlight { > + compatible = "pwm-backlight"; > + pwms = <&ecap0 0 50000 PWM_POLARITY_INVERTED>; > + brightness-levels = > + <0 32 64 96 128 160 192 224 255>; > + default-brightness-level = <8>; > + }; > +}; > + > +&dss { > + status = "okay"; > +}; > + > +&dss_ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + oldi_out0: endpoint { > + remote-endpoint = <&lcd_in0>; > + }; > + }; > +}; > + > +&main_i2c1 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + gt928: touchscreen@14 { > + status = "okay"; > + compatible = "goodix,gt928"; > + reg = <0x14>; > + > + interrupt-parent = <&pca9554>; > + interrupts = <3 IRQ_TYPE_EDGE_FALLING>; > + touchscreen-size-x = <1280>; > + touchscreen-size-y = <800>; > + > + reset-gpios = <&pca9555 9 GPIO_ACTIVE_HIGH>; > + irq-gpios = <&pca9554 3 GPIO_ACTIVE_HIGH>; > + }; > +};