From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from YQZPR01CU011.outbound.protection.outlook.com (mail-canadaeastazon11020106.outbound.protection.outlook.com [52.101.191.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ACB93CF943 for ; Tue, 16 Jun 2026 19:38:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.191.106 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781638727; cv=fail; b=My1pS0n3xU6AUVnfluptky8u8IEmncJ6GtwjbeP3kWcPxOM24iA4MXWBg8jZA+UjZZ5DmBiobqN3pHjyntszegu9fGJr3NlWmzpMfDmRzTmOIuwWP5gtYgImHqmyziz5x1msITvysnogxin3NJvqsRQbhAqMyt+UXpjqPkQJCuw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781638727; c=relaxed/simple; bh=vRhB0vvbhkeqweBfmXXpktx6+wVbvYTtAM0UVeCck48=; h=Message-ID:Date:Subject:From:To:Cc:References:In-Reply-To: Content-Type:MIME-Version; b=Ak3mc699QCoASrKMZEpjlJMolMvefKVTYAptJByWG1UugRi52fcqEY9oZ+tWRQ4INpM77TdORx818uWc1rDiJTRq8FCnPVxa8uNeiqiJZuYX0LE/L+oiyTduquf54NeCWZojbZCuzqxECRcR/WI4T64twy1357XWpL0SW1YHR00= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=QCeA46eH; arc=fail smtp.client-ip=52.101.191.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="QCeA46eH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KCvpZfbeaCDa1g7DS5y0eqPkTdvwfIbjl4gitjkiBqnoBuGomoM2H/6nwEAj6CjidZu7f/0BTnKpZZ0osuJ1S0K7Py98XEnGWB0dqN3EfFF1Lb4/YEbJTB7QokxTP95Hbt1CzzTI2kqrysxs6xTknWxXzzr9xgq8ISRksgSDavkZgC6vS0K60NLqAl/CvrnQqi7ureSholV4BPLr7VbmBnXdX1BurE1vLikJ4TRkWydx/E2pUmfnsRKFQqYvfs7m6XokzXf9/2lYmdeuP4p6a49aMVni6fLXhUPHxetii/kL/gGvuuFBDURmuQ2zUXXkypgt3sU242JjlkshIHfMCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yX7azve1LI1AokwruuzILKmRe8sHVoDq5HcDfCNyn4c=; b=TXp/B9VX7t2eYRSBaQpuU0uq5ZXgq73lXmATuQah2TwlVv7S506EctPEvNck5/aMUp055jK4KI7PuxEcC/I7uc5Ox32uOj+JlAhsrmTG9HObwKK1xDBn108zuaVF22gTj40xSuELLstwMNACwv2Zj6ABT+71Alb1AoTpP07/9IWi33w3q+hfB60sLbE2E49NpvfkVw8aflgcpBeQwAjEX9LxbpB5RBEMtw+9gQ0I2N2z45NJkK5Nqu+Zz5OQEjhfCJWE1UoOQHUjXXqp5i3RlbpwPnUfNNqftcjcull6krZwLkybD1K31J/Z8hB1mJddvDbkCEW+JKEfBppOx+CbiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yX7azve1LI1AokwruuzILKmRe8sHVoDq5HcDfCNyn4c=; b=QCeA46eHenb7ckF026ZVqE5/u6HkMQsodITYo7GgJ4qmLZwK0y2kbAydmylQxvWggAHGJA9eC480B3+hVt0gsZeMJb9UAuYY5FGGyOS9hPQinJDSIRKjwrO0bI9G3PE6gNrXkCJ8YkkYjMs36v6ArjSlopc+KmFO07xv9UPrHCRv9b49sYnaRDnCVjbopvCJ+uI862c8vTcSALjpOeTLIlf5COOfT0S05PbwSt5T+1nvYZy6hA9Qy4kPAubg9lDmYV/uL71BPGcdLjlvBhCMLzZaqTfV0eyEX9ufCUl45dJdTWhz+TuD02J/ynXabuvpcs8wK8nPZFz6DVsMRM0fNg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:be::5) by YT3PR01MB8178.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:9b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.11; Tue, 16 Jun 2026 19:38:41 +0000 Received: from YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM ([fe80::6004:a862:d45d:90c1]) by YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM ([fe80::6004:a862:d45d:90c1%3]) with mapi id 15.21.0139.009; Tue, 16 Jun 2026 19:38:41 +0000 Message-ID: <902df747-5564-4762-b588-39b58d969536@efficios.com> Date: Tue, 16 Jun 2026 15:38:40 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sched/mmcid: fix OOB clear_bit when CID is MM_CID_UNSET in fixup path From: Mathieu Desnoyers To: Rik van Riel , linux-kernel@vger.kernel.org Cc: kernel-team@meta.com, Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Thomas Gleixner , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak References: <20260616145343.1491887-1-riel@surriel.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: YT4P288CA0067.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01:d2::27) To YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:be::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT2PR01MB9175:EE_|YT3PR01MB8178:EE_ X-MS-Office365-Filtering-Correlation-Id: 53570359-0a6d-47cd-f22e-08decbdedeb1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|23010399003|376014|7416014|4143699003|22082099003|18002099003|56012099006; X-Microsoft-Antispam-Message-Info: a5/8tlyRP/h0nA4o72YhWGQEgTw20KnBdrzgqGGHWe+itsQ517K7dmsOh/VlLMP1iZevItvnKUuRQfEA49qGr8Cu38dxipeydPTI8FNK2BABSH4pCJkJB6uy1dDcPxNCUclpPHmjcto+7Yjyf17ceFx6jjvTS/wVfsqL3pO9ijFQN7XBUkWoKKjDe0LKgu1K/nkNGC8t/dWF6vlzQcqa++FTh5G1L/KWFx8LT49ddsIHSHIbdwR/f7ztQQcuGLZJ9Wte9b++mxKa/KLSFnQUITzRzb4ONFtDFtGPJwnMEEEieoBTEkAbR9Ef7yPIXliGQ+ji2sKjbuW8O4Mvg2+pUuIz0pz9Ih6h3BZf+Ogyd0iu14rbO9iN6Coo323YW4WpB++fEWp/eLNsYbXzBtk8T1lq71tMb7qVLt5ypX+d6oQC334d43AyJ9lJDMhTbFeg43fl3F4S0EhuD5N+RtXe/Vts9lq/YMgVkL6O18//HZ6DQ5mGFoP0BPJukIrwZ+NmO36onhc1Kw0VndJzgqFekVMrY1J72cSEuHcwJs6iNauvOUz0l8RnYALJ2G2pwTAnkU3X7ZuN0NKVQHdwqvmkuFZAwghM72kJz0555iv7OrOZUGZmWVnBvyqenPGGp/0YEEe1BJKOyMerli256vN6rg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(23010399003)(376014)(7416014)(4143699003)(22082099003)(18002099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnE1Q0hkNGtGVUpMZkxMci9MMEg3WjIxM2oyWE9wQUcwaXdWdDhORmNBNWNk?= =?utf-8?B?N3VDMVNaV1kxYThpU0d4UWZPMUVEU1lCSzY1Qk9wVXdOcnhPVjYzdGtlMExD?= =?utf-8?B?VEN1VUQxZStYTmtFR1k5R3pURWMwWUlEU2l4Nm9mTDJMb2thMk9oS0xnK05I?= =?utf-8?B?SnhqbzZEQVBYVGZHcVpCU2ZZUS9rTU1lNG1CanpFa3p4YWJMNEZXRW42YzVv?= =?utf-8?B?Zmx2Y0FjOHdrN1liNXVydzJ6WURkUUIyMkJsUUNSdkMzeEd6OGpzVCtMTzJD?= =?utf-8?B?MkFaOGpKMElxL3hoOTFOck16OHdXSGRENDFrckVLS09aU3hLNU13WlRINGFW?= =?utf-8?B?dEFuZmlRY2dKU2tOSGpiMlN3VkVFNENMMU1tSFA4a0ZVeTFnWldIb1BQc3Bw?= =?utf-8?B?ZXFaMUc4cUlnb1RsT2FCZk5yK3NDRmkyNENmK2RpYk5GaStlaHV3NExRUzZK?= =?utf-8?B?NWo2Z3QzekNhTUtmSEdieG44TGt4UGNkRWFmN285UE5nbnZiTXU3MmxScjUw?= =?utf-8?B?eHRQZUhjK0pQNlBtaUg3Q1lQVjdReHJydzE5ZGxXNDVSeW9Jckl5dGRhY3Jp?= =?utf-8?B?OW1nSGFKTTUxT1ZtMG5BWHo1eXRkTkR5Zk9aT0RObkE0OG5iMS9mLzVCK2lw?= =?utf-8?B?b3JpUHhPRW5YMnowQlZhMjh5MmFVUVY2OFdKQXRBTjFEdFNUU2tpdjdDYU80?= =?utf-8?B?aG5SS3VrenJaNGIyOGFyVDRNOEhnaTc0M1pTN0E4dk9VVnJucWpaRG44RktT?= =?utf-8?B?Ri8xQzFSUmRWVDdTNm5JcGloQlV6NjRTc3VmZnpSZW1oaVlZNWtvS0NGN2dI?= =?utf-8?B?VlNNSXdzZUJHZTZTUUkzaXkxSE9RZGRtNFM0eWNwNTh4akF3Tjd6U1RkNGhI?= =?utf-8?B?bndrdGF6cnEzNnRiQkNGVEhRV3Z1enFoR2hBdXg2aStUSWVOYzJXSG9Fd1pY?= =?utf-8?B?bU9GUG1CYXZEVzRQNzZlMHVZUHBXTGZYcEZCSXN2cVM1S2hxTmxTdWo2cGhR?= =?utf-8?B?aEZxSjk3MTNvREdoUmxRdG5lZEVpSHVvRTFjN1lLbzB4aWdVTXpxUkxVNlA3?= =?utf-8?B?Wkd5Tk5BRTJkZTN0TS9GZWJGYVc4djhaTTdJakMwaW9iRmJDTE5lSUxvMmxO?= =?utf-8?B?WUxHWjFvS2gwWUF1MjUzbGY2eDZ1SnhSWEZ0RGNPeGlVRHoxQnVibEFET2Yr?= =?utf-8?B?S2dmR1lSeVY0aXdMVFk2Mm5FcHE0QWlEMDVCVTY0SkNQempoajgwNGdwV0Ur?= =?utf-8?B?L0hhendERWsrcFpEYkJuSnliRWprc0RlbW9rOCtKODlPamRVdDIzZVl4endE?= =?utf-8?B?Q2ZTM1BLRVptdEFXZ3IrZlpMRzcvVUNpZ3A4Y2QyREZJaUp2eFIvbmVsZTJD?= =?utf-8?B?alg4WWxaRmxvTFZMODB0bTB2aUwzVWdBTitBTWkycE5RU3NvK1dmazVpMEtC?= =?utf-8?B?QlNUS2hUSXpOUzExcjJzNHYxVHFhOEN3VkdqNXhZd2tlUXFoVHJaMFBlMEI5?= =?utf-8?B?bjgvUmp1aytTRWFTQzg3Z245aWxCUndnUTdFNnVRMk83c0hqRWNIOU8xUUdB?= =?utf-8?B?Q1RncGFHcG1HQzF0YXNPcGJIdk42TmR1Z1lvL2dseEo2MnlHVXU4RGQ4bVFz?= =?utf-8?B?VmVuWGNJWHhWVXhYQWJVYVh5U0plWVhPTlBycFV1VUlnak05WjBWU2FOeWtx?= =?utf-8?B?a3JCV2t0VkYrQWRYTFRreE9GOVloMkVpV2tyVG81N05DY01xOUd5THVON0o4?= =?utf-8?B?TjZGWWtjYmp1MndBN1poTWNJZ1hBRUErdFc5WVp1UCtoUjI0R1ludFB3bW1V?= =?utf-8?B?dGlvUERQUVJWbHkxT28rQllTV1liV1ZXUzRVSGRmZjFoemFZQTZvM3dGOTFD?= =?utf-8?B?NUF3aHBadGEzQ013UEpxbHh3dkI2ZFNxNFRqN3FxM1F1eWFqTDVzMmszZUFn?= =?utf-8?B?K2ZncGtkRm9YNFNzUlBtQWJ3Qng5VXBmK203K21kSGxocUFnNjB4WHFzVklB?= =?utf-8?B?T2t0K29yT1RZOGI0K0hMUEdLaWlIdElpMDRSSTdIb0t6SzJzczZyWnd0K3pQ?= =?utf-8?B?VHAxdXNMSTZ1MFdjU09xQzB1YnBPZ3BLNmxrVUNONXBLNGlhbXhVUGZaNjhN?= =?utf-8?B?ekxNVzB3TkxxQUs1NytFeHEwWFdYNmU4N09vaXMvOUNIWFl0TlVYVlB4LzVn?= =?utf-8?B?dHh3QXozNkN4WjA0N3F4QzhrM3UrMXRKSHNpeW1LaXRZejBWK2pnWVNnUVlo?= =?utf-8?B?Y2t4aTE2dXhaMGdyMWhyamdoMGNtYkdja2FqZkViNE5zaHpNZ0hFZlFNUHJ0?= =?utf-8?B?TFhsc0VUbkhUbWNidTdRWWVnRXBIVW9PM0pDejNibm9qWmwyV1ludUhXMHRO?= =?utf-8?Q?020Fgu21l8hwyz+j3UKjWzTHLjh+8DoE4SU7J?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53570359-0a6d-47cd-f22e-08decbdedeb1 X-MS-Exchange-CrossTenant-AuthSource: YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2026 19:38:41.4555 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qWZQ7q8hr2pmK0HXqmelz5hYFXT4ibuYTeU1BzxqDn01gt4VHW04G7TnioVqLzIFkeHYVxnhDysFmq4wbb9ZN8/vi18PoRUXM7KEk2+uVVY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB8178 On 2026-06-16 12:09, Mathieu Desnoyers wrote: > On 2026-06-16 10:53, Rik van Riel wrote: [...] > > Did you try changing this to the following (completely untested) check > instead: > >   if (!cid_in_transit(cid) && !(cid & MM_CID_UNSET)) { ? Note: "MM_CID_UNSET" is technically a flag (bit 31), but is always set with a value store and used with an equality check, so you may prefer: if (cid != MM_CID_UNSET && !cid_in_transit(cid)) { Thanks, Mathieu > > Thanks, > > Mathieu > >>                   cid = cid_to_transit_cid(cid); >>                   rq->curr->mm_cid.cid = cid; >>                   pcp->cid = cid; > > -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com