From: Hans de Goede <hdegoede@redhat.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, peter@piie.net
Cc: markgross@kernel.org, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] acerhdf: remove unneeded semicolon
Date: Tue, 27 Sep 2022 16:19:40 +0200 [thread overview]
Message-ID: <9036da27-32aa-8ae3-9221-45b988d37266@redhat.com> (raw)
In-Reply-To: <20220926033311.84765-1-jiapeng.chong@linux.alibaba.com>
Hi,
On 9/26/22 05:33, Jiapeng Chong wrote:
> ./drivers/platform/x86/acerhdf.c:344:2-3: Unneeded semicolon.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2271
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/platform/x86/acerhdf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
> index a7407aa032ba..b48c6c5da147 100644
> --- a/drivers/platform/x86/acerhdf.c
> +++ b/drivers/platform/x86/acerhdf.c
> @@ -341,7 +341,7 @@ static void acerhdf_check_param(struct thermal_zone_device *thermal)
> pr_err("fanoff temperature (%d) is above fanon temperature (%d), clamping to %d\n",
> fanoff, fanon, fanon);
> fanoff = fanon;
> - };
> + }
>
> trips[0].temperature = fanon;
> trips[0].hysteresis = fanon - fanoff;
This patch does not apply on my current for-next branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next
I guess that this might be based on the thermal-zone changes which are going upstream
for 6.1 through another tree.
Please rebase + resend this once 6.1-rc1 is out.
Regards,
Hans
next prev parent reply other threads:[~2022-09-27 14:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 3:33 Jiapeng Chong
2022-09-27 14:19 ` Hans de Goede [this message]
2022-10-08 7:04 Jiapeng Chong
2022-10-24 14:06 ` Hans de Goede
2023-03-09 6:10 Jiapeng Chong
2023-03-16 14:36 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9036da27-32aa-8ae3-9221-45b988d37266@redhat.com \
--to=hdegoede@redhat.com \
--cc=abaci@linux.alibaba.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=peter@piie.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®