mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Denis Benato <denis.benato@linux.dev>
To: "Nizar Al-Kabbani" <nizar.m.kabbani@gmail.com>,
	"Corentin Chary" <corentin.chary@gmail.com>,
	"Luke D . Jones" <luke@ljones.dev>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: asus-nb-wmi: map ProArt key (0x8b) to KEY_PROG3
Date: Sun, 19 Jul 2026 15:31:32 +0200	[thread overview]
Message-ID: <9048aa8d-6453-4f16-b45c-570125380045@linux.dev> (raw)
In-Reply-To: <20260719090843.66777-1-nizar.m.kabbani@gmail.com>


On 7/19/26 11:08, Nizar Al-Kabbani wrote:
> The dedicated "ProArt" key on the ASUS ProArt PX13 (HN7306) emits ASUS
> WMI event code 0x8b. This code is absent from the asus-nb-wmi sparse
> keymap, so pressing the key only produces a "Unknown key code 0x8b"
> message and does nothing in userspace.
>
> On this model the key is exposed solely through the WMI interface and has
> no HID scancode, so it can only be handled inside asus-nb-wmi. Map 0x8b
> to KEY_PROG3 so the key emits a bindable event, consistent with the
> existing KEY_PROG3 mapping used for the ASUS programmable/Armoury key.
Reviewed-by: Denis Benato <denis.benato@linux.dev>
> Signed-off-by: Nizar Al-Kabbani <nizar.m.kabbani@gmail.com>
> ---
>  drivers/platform/x86/asus-nb-wmi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index 8005c08..aeb461b 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -632,6 +632,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
>  	{ KE_KEY, 0x86, { KEY_PROG1 } }, /* MyASUS Key */
>  	{ KE_KEY, 0x88, { KEY_RFKILL  } }, /* Radio Toggle Key */
>  	{ KE_KEY, 0x8A, { KEY_PROG1 } }, /* Color enhancement mode */
> +	{ KE_KEY, 0x8B, { KEY_PROG3 } }, /* ProArt key (PX13/HN7306) */
>  	{ KE_KEY, 0x8C, { KEY_SWITCHVIDEOMODE } }, /* SDSP DVI only */
>  	{ KE_KEY, 0x8D, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + DVI */
>  	{ KE_KEY, 0x8E, { KEY_SWITCHVIDEOMODE } }, /* SDSP CRT + DVI */

  reply	other threads:[~2026-07-19 13:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-19  9:08 Nizar Al-Kabbani
2026-07-19 13:31 ` Denis Benato [this message]
2026-07-21 17:15 ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9048aa8d-6453-4f16-b45c-570125380045@linux.dev \
    --to=denis.benato@linux.dev \
    --cc=corentin.chary@gmail.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=nizar.m.kabbani@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®