From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753705AbcHPL7x (ORCPT <rfc822;w@1wt.eu>);
	Tue, 16 Aug 2016 07:59:53 -0400
Received: from mx2.suse.de ([195.135.220.15]:53734 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753656AbcHPL7w (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 16 Aug 2016 07:59:52 -0400
Subject: Re: [PATCH] kbuild: do not add srctree to sysroot relative includes
To: Lars Persson <lars.persson@axis.com>
References: <1471347658-9219-1-git-send-email-larper@axis.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
        Lars Persson <larper@axis.com>
From: Michal Marek <mmarek@suse.com>
Message-ID: <90494889-24e4-64be-422e-d7cc344f03da@suse.com>
Date: Tue, 16 Aug 2016 13:59:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2
MIME-Version: 1.0
In-Reply-To: <1471347658-9219-1-git-send-email-larper@axis.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2016-08-16 13:40, Lars Persson wrote:
> We need to filter out also -I=/path to allow sysroot relative
> include paths in the makefiles of external modules.
> 
> Signed-off-by: Lars Persson <larper@axis.com>
> ---
>  scripts/Kbuild.include | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
> index 1792198..ffe5c6c 100644
> --- a/scripts/Kbuild.include
> +++ b/scripts/Kbuild.include
> @@ -206,7 +206,7 @@ hdr-inst := -f $(srctree)/scripts/Makefile.headersinst obj
>  # Prefix -I with $(srctree) if it is not an absolute path.
>  # skip if -I has no parameter
>  addtree = $(if $(patsubst -I%,%,$(1)), \
> -$(if $(filter-out -I/% -I./% -I../%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1)),$(1)))
> +$(if $(filter-out -I/% -I./% -I../% -I=%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1)),$(1)))

Hi Lars,

Two questions: 1) Where is the -I=/... syntax documented? I could not
find it gcc docs. 2) Why do these Makefiles use --sysroot at all? The
kernel does not use any system libraries and the host programs are
compiled for the host architecture.

Michal