From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 968E32D0617 for ; Sat, 28 Feb 2026 13:32:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772285527; cv=none; b=ZWF/6mqgkVE1b86c1z1v1xEZ8x6oMnbMnw0hEmZsx1GZ51cbZBhtE/fqe9BXYh8zgRzgOatfNLy+p2JGBGWzE89T0LvPCZFUderzdxV9VT3BngV59QripOYmsce7+Ux+XIkkTbehQPSkvU/ixJF7ky6cJR5VXTf8Du5X+RYS+yU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772285527; c=relaxed/simple; bh=PhHuUu9iuNN6f0u4NGXuq592Wlo743s7MLGebYKQeGg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gBV+mJIj2keHnrG4qXav/dY2VNu1zAm9qe/luiL8vWW8P6CG5Sp0BVYtWjqGi1bep3LzdEU+u187AnmiWagGqVGqwp8M8A4+A3D27P48vY6sWGKHB97cBJewtaWEcq7nryntKZeAjpiaY/rrOgQSRGW/XxhPav6d2ARPtvvrdFs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=nhs8jmK/; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="nhs8jmK/" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-48069a48629so32138625e9.0 for ; Sat, 28 Feb 2026 05:32:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1772285524; x=1772890324; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JI7TLLSl99LPgXU49aZzYXGzm70nyMbapJzO62R2hbw=; b=nhs8jmK/cWYLNhVChLZ0OoGe0sb5P7VT8UR6+dRzqkMUM4L7Izrzj+lp79JbnsSEhJ 6OfeBvxPbOlB9T60bnNgE+4mEYMdxPcPAYmiyujyk3XEsiJVHIiW+mbA11ywAiXL8jhw h7SVf7QAA8wyiY5hpTuQRnLvVFBqzUaaP3U41mpO0SlkDqBEyJme2WUeKuCEb7dGlOSL esVFG/8ymv8Qjb/3U4LrhS6MoIzhNfpqSe0M/h45NtNWhoyFqTO0Vn30CI2thVWzGr12 T05lN50XCh+TU9ERPA8H1xFSIHlydAbMczvZ7D88RNfsC9RMKZcSJiiQh8Ji/MouzMoB M4AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772285524; x=1772890324; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JI7TLLSl99LPgXU49aZzYXGzm70nyMbapJzO62R2hbw=; b=PYXKTksvBsHa8UqlOgSfkAy2QPQkNefvGPvQgCPrG+l/ZaJx+7tmKH74b2R6cXxZSr F8w3k/D9cim+x5+18OzosrlSFUyt7WyXFzdd7TkJbJxJfigUG2eAuwu21USog7pea5IG bob8pA9f3+km4zoN0L/VekMPG+XpCfEhQMtJ5zZjvM/+9P9FfU8V1B1TB5LceqiH+dYq F7JRQWIMsdqpztSqSVt3cLzhM00eld5coffLWG6gJ8pA1eJ30DRvp3A1EWk3waTL6mWM zK11t6PbrEZHelfqJhF+vW46gwe7hP6RgNgarkWMTaq8eivaujT/07f9CEP4miu+c0PM awNQ== X-Forwarded-Encrypted: i=1; AJvYcCUJT0ScSrlQ+WoWQOUqHZ0m8y+5stEkFk772uKcHqYxjhkjyIFdKlIQIrbQy3yITd+m8D8VhmcB1c4CnMs=@vger.kernel.org X-Gm-Message-State: AOJu0YzVJNWUqT0a7KXoLYbciNA7dg4Rpzi89D8wpC8fC0OYSLZKCgjY 1SQv1mHRukyBldNE5ghNkTtTS3qcH0oEJp/Al5/EQoolqRlDUplNU7b9X4sP3LJdo2w= X-Gm-Gg: ATEYQzzJx6SgzjaSuOvqvBRl0S6EJXN5RUhcjiHk+u8xz8Xt9lM5ygZZDGCiLZvR4b1 5gZ0uXT6OFeMRQzr9t4LhH9POun3Dva5t0MiWzCcHJJu7cV1RU6ld/YJbewoFfg9dnmd1g5FFn+ rj4y/QNgmh7MVBQ+g0vYd9MWeDZf2n+NFc6SB2gqcWEtDn0e9cNaFXRi//f98F+FpQO1Vqf0cDd lKp2HtfBGCyZLcBMLa871+HsZs3HYYV2bf2tOLX2BOLhvci3mrPDDooeLERRGSrnlnX/Jts0ViR kdt2LYUsdY+upPVryUiQnYFgDJ5ralJW6+/RFc5jANCQ8fLvM0vtZvQ4DRqs9NXvI+k2rafPp7D chITswMYUyDUo7p4Io/WWLUSv/yKw14h3j+pYafz6cT4BnWZL46sw0TdjO/pi2klqAmddfygAA8 BhB26tkQYvap1EFOUuA9amf5cXb3shpjDYYecMBKid X-Received: by 2002:a05:600c:4592:b0:480:6999:27ec with SMTP id 5b1f17b1804b1-483c9bc03b1mr112029205e9.13.1772285523446; Sat, 28 Feb 2026 05:32:03 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.73]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfba9566sm129482745e9.3.2026.02.28.05.32.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Feb 2026 05:32:02 -0800 (PST) Message-ID: <905b0bd8-dce4-4921-b7f2-4d694a02533f@tuxon.dev> Date: Sat, 28 Feb 2026 15:32:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v5 3/5] net: cadence: macb: add ethtool EEE support To: Nicolai Buchwitz , netdev@vger.kernel.org Cc: davem@davemloft.net, andrew+netdev@lunn.ch, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux@armlinux.org.uk, nicolas.ferre@microchip.com, linux-kernel@vger.kernel.org, theo.lebrun@bootlin.com, phil@raspberrypi.com References: <20260227150610.242215-1-nb@tipi-net.de> <20260227150610.242215-4-nb@tipi-net.de> Content-Language: en-US From: Claudiu Beznea In-Reply-To: <20260227150610.242215-4-nb@tipi-net.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/27/26 17:06, Nicolai Buchwitz wrote: > Implement get_eee and set_eee ethtool ops for GEM as simple passthroughs > to phylink_ethtool_get_eee() and phylink_ethtool_set_eee(). > > No MACB_CAPS_EEE guard is needed: phylink returns -EOPNOTSUPP from both > ops when mac_supports_eee is false, which is the case when > lpi_capabilities and lpi_interfaces are not populated. Those fields are > only set when MACB_CAPS_EEE is present (previous patch), so phylink > already handles the unsupported case correctly. > > Reviewed-by: Théo Lebrun > Signed-off-by: Nicolai Buchwitz Reviewed-by: Claudiu Beznea