From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751311AbdBXHVq (ORCPT <rfc822;w@1wt.eu>);
        Fri, 24 Feb 2017 02:21:46 -0500
Received: from mail-pg0-f41.google.com ([74.125.83.41]:36490 "EHLO
        mail-pg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751001AbdBXHVh (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 24 Feb 2017 02:21:37 -0500
Subject: Re: [PATCH] /proc/kcore: Update physical address for kcore ram and
 text
To: Kees Cook <keescook@chromium.org>,
        Andrew Morton <akpm@linux-foundation.org>
References: <f951340d2917cdd2a329fae9837a83f2059dc3b2.1485318868.git.panand@redhat.com>
 <CAHB_GupwpXiZjmy+4SQLvoJaJkAo9VvNVxQgxqvXeACRR--exg@mail.gmail.com>
 <CAGXu5jL89e33t0g+iVm8o7sstn3B9QCiFP_AhxZj8QiyaTjNZw@mail.gmail.com>
 <5b28ea05-24ab-b8db-e3d1-216399734297@redhat.com>
Cc: open list <linux-kernel@vger.kernel.org>, Baoquan He <bhe@redhat.com>,
        Dave Young <dyoung@redhat.com>, Dave Anderson <anderson@redhat.com>,
        Kexec Mailing List <kexec@lists.infradead.org>,
        Atsushi Kumagai <ats-kumagai@wm.jp.nec.com>
From: Pratyush Anand <panand@redhat.com>
Message-ID: <905c2861-11bf-0449-31ab-596d9347e7cc@redhat.com>
Date: Fri, 24 Feb 2017 12:50:50 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <5b28ea05-24ab-b8db-e3d1-216399734297@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew/Kees,

On Tuesday 14 February 2017 07:16 AM, Pratyush Anand wrote:
>>
>> Well, CONFIG_PROC_KCORE is a generalized root KASLR exposure (though
>> there are lots of such exposures). Why is the actual physical address
>> needed? Can this just report the virtual address instead? Then the
>> tool can build a map, but it looks like an identity map, rather than
>> creating a new physical/virtual memory ASLR offset exposure?
>
> Well, having an ASLR offset information can help to translate an
> identity mapped virtual address to a physical address. But that would be
> an additional field in PT_LOAD header structure and an arch dependent
> value.
>
> Moreover, sending a valid physical address like 0 does not seem right.
> So, IMHO it is better to fix that and send valid physical address when
> available (identity mapped).
>
> Thanks for the review.

So, whats the decision on this patch? I see that patch is lying in 
next/master. Should I expect this patch in v4.11-rc1?

Couple of user-space makedumpfile modification will depend on this 
patch. So, we can not get those makedumpfile patches merged until this 
patch hits upstream.

~Pratyush