From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A807529D19; Fri, 30 Aug 2024 10:04:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725012247; cv=none; b=asFH7hnCKCzCWH54+GI5fPxqVA1Lo0bV5U4BjSY611Wgl9N5+bl/WpNE6pCSx/3yyex8GA1kx9WAywmGTohWfvlv8WbpYPt3VkvA+R0kR6yrKWMeRdfDjqVD/07AipS7XtQR+071dgdGDwNF6l9vDatAnLnRMHf1MueF9AVzyPo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725012247; c=relaxed/simple; bh=ulhx2YCRsDJW6yKBaLbbpxIJyNZWYP5UY/uikdZijbY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hTT8nzwL6QVeXX2EilQ67cMvkwJFfnUnx/eNE+2iwvDwnGJjHS/jcs9hAN1KmCvxBeSV1O78Tdo2Z+IlBn/F55hjBIxSpaeha7VA3n4+Sd1dFQtpkTEMTEvxxvX49noVIpwRakTghYz9cFDybj9nfyl3dTdvkDwn2ooxmjY6jzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ls9q4+wS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ls9q4+wS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DBE6C4CEC2; Fri, 30 Aug 2024 10:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725012247; bh=ulhx2YCRsDJW6yKBaLbbpxIJyNZWYP5UY/uikdZijbY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Ls9q4+wSKT/ET9K+vZioKMLHLDJm6rS7Gp9tpsz5F3ATvxLST8Md8kYrvD+p+dQM3 Lj8YIrxllVsSYprh0wmVz0alyZ2l0V4BtXiHOImMEuhayRfJP2VxMwOy+Jk/FfIQmy wejBHwBc8CY9XtYLXib+FPe8NtKHhaKuRTEycXFV6JnTxkdMxVBYPyO1/h64n6E6qk vJbcM4l3v9JHQBe/Z6IU3FOBHzXiIp28wihiD3V6wP2DNUwopiBunsI3LsxjyFnW5i pvMI9TiOndLgZDmCh7pls4P8WTbUX8/77KNaUiQS2JCkbqJWesUUm7jX2N1vmWuPD3 Ql4hyIg4pL0fw== Message-ID: <905d4ca5-3001-4f8b-aa26-f4c6a51f050c@kernel.org> Date: Fri, 30 Aug 2024 12:04:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/9] dt-bindings: soc: renesas: Document RZ/V2H EVK board To: Geert Uytterhoeven Cc: "Lad, Prabhakar" , Magnus Damm , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das , Fabrizio Castro , Lad Prabhakar References: <20240828124134.188864-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20240828124134.188864-2-prabhakar.mahadev-lad.rj@bp.renesas.com> <28106585-59d1-42c4-af56-89820b15bdfb@kernel.org> <606dc93b-9433-46bf-8c38-1d07b3677abb@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 29/08/2024 09:35, Geert Uytterhoeven wrote: > Good mornin' Krzysztof, > > On Thu, Aug 29, 2024 at 8:00 AM Krzysztof Kozlowski wrote: >> On 28/08/2024 22:09, Lad, Prabhakar wrote: >>> On Wed, Aug 28, 2024 at 3:34 PM Krzysztof Kozlowski wrote: >>>> On 28/08/2024 14:41, Prabhakar wrote: >>>>> From: Lad Prabhakar >>>>> Add "renesas,rzv2h-evk" which targets the Renesas RZ/V2H ("R9A09G057") >>>>> EVK board. >>>>> >>>>> Signed-off-by: Lad Prabhakar >>>>> Acked-by: Rob Herring (Arm) >>>>> --- >>>>> Hi Rob, I have restored your Ack with the below change, I hope that's OK. >>>>> >>>>> Cheers, Prabhakar >>>>> >>>>> v1->v4 >>>>> - Updated 'renesas,gp-evk # GP-EVK' -> 'renesas,rzv2h-evk # RZ/V2H EVK' >>>>> - Updated commit message >>>>> >>>>> v1: https://patchwork.kernel.org/project/linux-renesas-soc/patch/20240724094707.569596-2-prabhakar.mahadev-lad.rj@bp.renesas.com/ >>>>> --- >>>>> Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 2 ++ >>>>> 1 file changed, 2 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml >>>>> index d582992aaf0e..b7acb65bdecd 100644 >>>>> --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml >>>>> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml >>>>> @@ -527,6 +527,8 @@ properties: >>>>> >>>>> - description: RZ/V2H(P) (R9A09G057) >>>>> items: >>>>> + - enum: >>>>> + - renesas,rzv2h-evk # RZ/V2H EVK >>>>> - enum: >>>> >>>> This is unusual pattern for me, but maybe I miss here something. Commit >>>> message does not explain why EXISTING boards needs to be changed. What >>>> does it mean "rzv2h-evk targets evk board"? How does this work? >>>> >>> This commit is not changing the existing boards. The entries below the >>> addition are the RZ/V2H(P) SoC variants. Here we are just adding the >>> board entry which is based on RZ/V2H SoC [0]. >> >> Then it is even more surprising to see there entries which were not >> boards. What's in this file in such case? > > Before this patch, the entry that is being modified just contained > SoC variants and a fallback SoC type. > This patch documents the compatible value for the first board based > on an SoC of this type. > >> Which DTS file it matches? > > The one that is introduced in patch 3/9 in this series. So the binding had compatibles without board-part and obviously there were no board-DTS files with them. That's a less usual, so short explanation in commit msg would be helpful. Best regards, Krzysztof