mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Baolu Lu <baolu.lu@linux.intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>,
	Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: baolu.lu@linux.intel.com, "Tian, Kevin" <kevin.tian@intel.com>,
	Joerg Roedel <joro@8bytes.org>,
	Christoph Hellwig <hch@infradead.org>,
	"Raj, Ashok" <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Jean-Philippe Brucker <jean-philippe@linaro.com>,
	"Jiang, Dave" <dave.jiang@intel.com>,
	Vinod Koul <vkoul@kernel.org>, Eric Auger <eric.auger@redhat.com>,
	"Liu, Yi L" <yi.l.liu@intel.com>,
	"Pan, Jacob jun" <jacob.jun.pan@intel.com>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 03/12] iommu: Add attach/detach_dev_pasid domain ops
Date: Mon, 16 May 2022 10:03:52 +0800	[thread overview]
Message-ID: <90619325-ea39-410e-2e8b-a38895f0dabf@linux.intel.com> (raw)
In-Reply-To: <20220512115101.GU49344@nvidia.com>

On 2022/5/12 19:51, Jason Gunthorpe wrote:
> On Thu, May 12, 2022 at 08:00:59AM +0100, Jean-Philippe Brucker wrote:
> 
>>> It is not "missing" it is just renamed to blocking_domain->ops->set_dev_pasid()
>>>
>>> The implementation of that function would be identical to
>>> detach_dev_pasid.
>>
>>    attach(dev, pasid, sva_domain)
>>    detach(dev, pasid, sva_domain)
>>
>> versus
>>
>>    set_dev_pasid(dev, pasid, sva_domain)
>>    set_dev_pasid(dev, pasid, blocking)
>>
>> we loose the information of the domain previously attached, and the SMMU
>> driver has to retrieve it to find the ASID corresponding to the mm.
> 
> It would be easy to have the old domain be an input as well - the core
> code knows it.

Thanks a lot for all suggestions. I have posted a follow-up series for
this:

https://lore.kernel.org/linux-iommu/20220516015759.2952771-1-baolu.lu@linux.intel.com/

Let's discuss this there.

Best regards,
baolu

  reply	other threads:[~2022-05-16  2:04 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10  6:17 [PATCH v6 00/12] iommu: SVA and IOPF refactoring Lu Baolu
2022-05-10  6:17 ` [PATCH v6 01/12] dmaengine: idxd: Separate user and kernel pasid enabling Lu Baolu
2022-05-10  6:17 ` [PATCH v6 02/12] iommu: Add pasid_bits field in struct dev_iommu Lu Baolu
2022-05-10 14:34   ` Jason Gunthorpe
2022-05-11  2:25     ` Baolu Lu
2022-05-11  8:00       ` Jean-Philippe Brucker
2022-05-11 11:59         ` Jason Gunthorpe
2022-05-10  6:17 ` [PATCH v6 03/12] iommu: Add attach/detach_dev_pasid domain ops Lu Baolu
2022-05-10 14:02   ` Jason Gunthorpe
2022-05-11  2:32     ` Baolu Lu
2022-05-11  4:09       ` Tian, Kevin
2022-05-11  7:54         ` Jean-Philippe Brucker
2022-05-11 12:02           ` Jason Gunthorpe
2022-05-12  7:00             ` Jean-Philippe Brucker
2022-05-12 11:51               ` Jason Gunthorpe
2022-05-16  2:03                 ` Baolu Lu [this message]
2022-05-10  6:17 ` [PATCH v6 04/12] iommu/sva: Basic data structures for SVA Lu Baolu
2022-05-10  6:17 ` [PATCH v6 05/12] iommu/vt-d: Remove SVM_FLAG_SUPERVISOR_MODE support Lu Baolu
2022-05-10 14:35   ` Jason Gunthorpe
2022-05-10  6:17 ` [PATCH v6 06/12] iommu/vt-d: Add SVA domain support Lu Baolu
2022-05-10  6:17 ` [PATCH v6 07/12] arm-smmu-v3/sva: " Lu Baolu
2022-05-10  6:17 ` [PATCH v6 08/12] iommu/sva: Use attach/detach_pasid_dev in SVA interfaces Lu Baolu
2022-05-10 15:23   ` Jason Gunthorpe
2022-05-11  7:21     ` Baolu Lu
2022-05-11 14:53       ` Jason Gunthorpe
2022-05-12  3:02         ` Baolu Lu
2022-05-12  5:01           ` Tian, Kevin
2022-05-12  5:17             ` Baolu Lu
2022-05-12  5:44               ` Tian, Kevin
2022-05-12  6:16                 ` Baolu Lu
2022-05-12 11:48               ` Jason Gunthorpe
2022-05-12 11:59                 ` Baolu Lu
2022-05-12 12:03                   ` Jason Gunthorpe
2022-05-12 12:47                     ` Baolu Lu
2022-05-12 11:51           ` Jason Gunthorpe
2022-05-12 12:39             ` Baolu Lu
2022-05-10  6:17 ` [PATCH v6 09/12] iommu: Remove SVA related callbacks from iommu ops Lu Baolu
2022-05-10  6:17 ` [PATCH v6 10/12] iommu: Prepare IOMMU domain for IOPF Lu Baolu
2022-05-10  6:17 ` [PATCH v6 11/12] iommu: Per-domain I/O page fault handling Lu Baolu
2022-05-10  6:17 ` [PATCH v6 12/12] iommu: Rename iommu-sva-lib.{c,h} Lu Baolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90619325-ea39-410e-2e8b-a38895f0dabf@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=ashok.raj@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=eric.auger@redhat.com \
    --cc=hch@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jacob.jun.pan@intel.com \
    --cc=jean-philippe@linaro.com \
    --cc=jean-philippe@linaro.org \
    --cc=jgg@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=vkoul@kernel.org \
    --cc=will@kernel.org \
    --cc=yi.l.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome