From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751869AbbLJKzv (ORCPT <rfc822;w@1wt.eu>);
	Thu, 10 Dec 2015 05:55:51 -0500
Received: from mout.kundenserver.de ([217.72.192.75]:59531 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751310AbbLJKzt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 10 Dec 2015 05:55:49 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Russell King <rmk+kernel@arm.linux.org.uk>,
        Liviu Dudau <liviu.dudau@arm.com>, Sudeep Holla <sudeep.holla@arm.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH 06/10] ARM: realview: enable multiplatform
Date: Thu, 10 Dec 2015 11:55:17 +0100
Message-ID: <90630654.JoEJDpXsxl@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <CACRpkdZwD7=h7oXdWZ6a6j5sXRcY0pKc2xuY6QsVfyNzpaWBMA@mail.gmail.com>
References: <1448469143-447355-1-git-send-email-arnd@arndb.de> <1448469143-447355-7-git-send-email-arnd@arndb.de> <CACRpkdZwD7=h7oXdWZ6a6j5sXRcY0pKc2xuY6QsVfyNzpaWBMA@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:W2N5SySw8c56UNaF/2/rarve1HE+ttZmfuR4pzLYWvdwJ0TAu09
 hqTPHJAzA2TIeAKLt4WxdYgzVPTMMST9ja6R4KGMBU4GJOQIsZ6sKbNRVdALLYWBCEAKDsH
 KaohIdF1er/vA7bQjMRDIR1IXOiw5i5Tyo5CsaDGRLLB3uzs5hweGDn4S41eBpY/kmup5jO
 2fJO0vDJQlObPtAnB4YuQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:tTSTBdSwdhA=:Zbmqid2pDo0lDyD36CTJTQ
 5TJQaz5rzpGAudi0FtoCS0FcITSlQRpdwRLeVLNBfYJqmKibo3ybNC/26Zbovuz6KyQVH4u2R
 HdUY7SZw85IuBEFPNCUNo5DBbJPvXrrg5q98xakXWFfI9r/wwLf9d7BH/5QOZdtVeNKTlVOhW
 FjiXVHx3V0aZJRo/S/XMlsR+Kw8SuAL6UJlbHv3/osyyU2Vif+LBy06U6DigkXKpk7CWE347L
 lzeR9ZHm0OPb++yMxuXjK0h8idiS/XMJbP+xiUSH7+uqXZq0zD/bK7Gwn4OrPxrx07gksfYfF
 aayibP+pNSnpZBByflr4aoWshsnl7dGk85XpJEk1NDrwseh2CueclypffxPLTVfyOzK0X44Vb
 ZpK7hyqRsxSYb94YG9OjLdhm8xB84fAW8QVkCPIy/25jM5IRlkRbgR/S7FAlYK8cYRcxOaV+z
 ssWGyQvP9KJz22BeDkHuELT1MI08uJIaC5+7LpYeHesHFk7H/OoIHWFB5b+KvF2w6gz1/mxKT
 Br+h71zdDb5K+0liwDGH2Mi8kq9ntWYkMTc7P1z2uOBJZav+QIgyHztVGaRGiLVAq9IMHSXzN
 d1m+3+750IjlWICtFL5KS/S2FzJFXpZx1dc3KrtTKUMTJnFd0v7gdLbUkSTEo9TRPJIqm4glY
 tfP7qgn2f9QPeTC0YI7mLszQjZfNoV+HtIM9Sz9+ky70lQvtjrRYILjjDcPUDZcs9GO124GqC
 CMj61v1UcdMxiOdb
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday 10 December 2015 11:04:31 Linus Walleij wrote:
> On Wed, Nov 25, 2015 at 5:32 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> 
> > All obstacles are out of the way by now, so we can finally move realview
> > to multiplatform.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > Cc: Russell King <linux@arm.linux.org.uk>
> (...)
> 
> > -obj-y                                  := core.o
> >  obj-$(CONFIG_REALVIEW_DT)              += realview-dt.o
> > +ifdef $(CONFIG_ATAGS)
> > +obj-y                                  := core.o
> >  obj-$(CONFIG_MACH_REALVIEW_EB)         += realview_eb.o
> >  obj-$(CONFIG_MACH_REALVIEW_PB11MP)     += realview_pb11mp.o
> >  obj-$(CONFIG_MACH_REALVIEW_PB1176)     += realview_pb1176.o
> >  obj-$(CONFIG_MACH_REALVIEW_PBA8)       += realview_pba8.o
> >  obj-$(CONFIG_MACH_REALVIEW_PBX)                += realview_pbx.o
> > +endif
> 
> This isn't working. Even if CONFIG_ATAGS is set, none of the files
> inside this ifdef $(CONFIG_ATAGS) are compiled. Does Kconfig
> only support if and not ifdef?
> 

Oh, it's a silly typo:

it should be "ifdef CONFIG_ATAGS", not "ifdef $(CONFIG_ATAGS)"

Sorry about that.

	Arnd