From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9816AC61D9B for ; Wed, 22 Nov 2023 19:04:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343732AbjKVTEI (ORCPT ); Wed, 22 Nov 2023 14:04:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231601AbjKVTEG (ORCPT ); Wed, 22 Nov 2023 14:04:06 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 438CA91 for ; Wed, 22 Nov 2023 11:04:02 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-50aaaf6e58fso42724e87.2 for ; Wed, 22 Nov 2023 11:04:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700679840; x=1701284640; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WeaG+b0rbUYhFaZ2y1herszVpRL6n64GLbmKdxYaZQc=; b=S1Jyexyr4xxtEIyYTcFak3F67S0kQT5W5d+jH9xsObRNPFvY5YEIjVGuOaJ9BMGBkE Sbs7cYYqTyqB3ce3DC/9ENw3JtZ3tJwcK3KYs9o4bNMZ3CXdRAEMIkbTEmg18O88pnxw ppdEgklnHCJaeiUgOVHSTVlixbDPf31IPpWEoxhJSuSEVThqam0xd1sXxFsyVc8Ku+Iv m3XWT8P5IQM28XPFtIhtFh74QTVpNZW27Xnv/HYVH/RpDTci6toDL52NK1qwwysDhRAS tUGbto0E7KGcrb1JmJf8gR1ioUiWPq/lLZi3ZfwMQXwtwBq8xD0W0Ab1htlgAnK9zqnX CjBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700679840; x=1701284640; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WeaG+b0rbUYhFaZ2y1herszVpRL6n64GLbmKdxYaZQc=; b=PCHYdQoNx+axuCIIZC6nYvtLqHlk9RobmyppFk9wtp0uQaRxRKMf1ACfF6bTQKnITs lUBBsjfS7hhqb5Z19NalPrIgeuT7Jfzq8GOFR5tTReZ0pIOj5rz3uEXNtIXDqgCsnrT8 9jO/ww6dPPY5HlnkP5t0pjsKkZLz4Esy7L/PKZraLQEh17btO/a1OnjgEtdvvES//5Jj uVx0cEGAhmti0s4B0MWex0XTKtT4FygWcGEDlZA+F6gZ01xl+KPVeEy63Z99+U9YOCmL JAVJJYCXzZ2dqp3ascykgVZM9fmrhVTV+UoxO0JkIf7r/rQG7N4F5sqLP6HeCFrEWSa3 aobA== X-Gm-Message-State: AOJu0YxRcQZZRqazUhf9mwEsoA4NQ1uh/2aKxWOrRatFk//hd+2MsdCx 1zo/4zM7cjIboBLVI/ZqUeQEpg== X-Google-Smtp-Source: AGHT+IF2aiLf0V6Jf13fm8pmWCHPn+SuYJBa3V5ieUq0HJBLwZQ6muJeRey0PrWdsVPVaUCWIJr8GQ== X-Received: by 2002:a05:6512:3083:b0:508:1470:6168 with SMTP id z3-20020a056512308300b0050814706168mr1188821lfd.57.1700679840507; Wed, 22 Nov 2023 11:04:00 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.100]) by smtp.gmail.com with ESMTPSA id d3-20020a170906174300b009fc3f347109sm89309eje.156.2023.11.22.11.03.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Nov 2023 11:04:00 -0800 (PST) Message-ID: <90664758-9273-4ed7-b711-0abe45b4efed@linaro.org> Date: Wed, 22 Nov 2023 20:03:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/5] dt-bindings: stm32: add clocks and reset binding for stm32mp25 platform Content-Language: en-US To: gabriel.fernandez@foss.st.com, Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Philipp Zabel Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20231122132156.158103-1-gabriel.fernandez@foss.st.com> <20231122132156.158103-4-gabriel.fernandez@foss.st.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231122132156.158103-4-gabriel.fernandez@foss.st.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/11/2023 14:21, gabriel.fernandez@foss.st.com wrote: > From: Gabriel Fernandez > > Adds clock and reset binding entries for STM32MP25 SoC family > > Signed-off-by: Gabriel Fernandez > --- > .../bindings/clock/st,stm32mp25-rcc.yaml | 76 +++ > include/dt-bindings/clock/st,stm32mp25-rcc.h | 492 ++++++++++++++++++ > include/dt-bindings/reset/st,stm32mp25-rcc.h | 165 ++++++ > 3 files changed, 733 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/st,stm32mp25-rcc.yaml > create mode 100644 include/dt-bindings/clock/st,stm32mp25-rcc.h > create mode 100644 include/dt-bindings/reset/st,stm32mp25-rcc.h > > diff --git a/Documentation/devicetree/bindings/clock/st,stm32mp25-rcc.yaml b/Documentation/devicetree/bindings/clock/st,stm32mp25-rcc.yaml > new file mode 100644 > index 000000000000..8697ab6bc22c > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/st,stm32mp25-rcc.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/st,stm32mp25-rcc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: STM32MP25 Reset Clock Controller > + > +maintainers: > + - Gabriel Fernandez > + > +description: | > + The RCC hardware block is both a reset and a clock controller. > + RCC makes also power management (resume/supend). > + > + See also:: > + include/dt-bindings/clock/st,stm32mp25-rcc.h > + include/dt-bindings/reset/st,stm32mp25-rcc.h > + > +properties: > + compatible: > + enum: > + - st,stm32mp25-rcc > + > + reg: > + maxItems: 1 > + > + '#clock-cells': > + const: 1 > + > + '#reset-cells': > + const: 1 > + > + clocks: > + items: > + - description: CK_SCMI_HSE High Speed External oscillator (8 to 48 MHz) > + - description: CK_SCMI_HSI High Speed Internal oscillator (~ 64 MHz) > + - description: CK_SCMI_MSI Low Power Internal oscillator (~ 4 MHz or ~ 16 MHz) > + - description: CK_SCMI_LSE Low Speed External oscillator (32 KHz) > + - description: CK_SCMI_LSI Low Speed Internal oscillator (~ 32 KHz) > + > + clock-names: > + items: > + - const: hse > + - const: hsi > + - const: msi > + - const: lse > + - const: lsi > + > +required: > + - compatible > + - reg > + - "#clock-cells" > + - "#reset-cells" If there is going to be respin, please use consistent quotes: either ' or ", in each place. No need to respin only for this. ... > diff --git a/include/dt-bindings/clock/st,stm32mp25-rcc.h b/include/dt-bindings/clock/st,stm32mp25-rcc.h > new file mode 100644 > index 000000000000..9876ee0dd1e4 > --- /dev/null > +++ b/include/dt-bindings/clock/st,stm32mp25-rcc.h > @@ -0,0 +1,492 @@ > +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-3-Clause */ Any particular reason why do you need 3-clause BSD? Checkpatch asks for different one, because that one clause is just annoying. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof