From: <Arun.Ramadoss@microchip.com>
To: <andrew@lunn.ch>, <olteanv@gmail.com>, <davem@davemloft.net>,
<Woojung.Huh@microchip.com>, <f.fainelli@gmail.com>,
<kuba@kernel.org>, <vtpieter@gmail.com>,
<UNGLinuxDriver@microchip.com>, <edumazet@google.com>,
<pabeni@redhat.com>
Cc: <pieter.van.trappen@cern.ch>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 1/1] net: dsa: microchip: rename ksz8 series files
Date: Thu, 29 Aug 2024 05:35:08 +0000 [thread overview]
Message-ID: <9066b22b221f97287484f1b961476ce6a67249df.camel@microchip.com> (raw)
In-Reply-To: <20240828102801.227588-1-vtpieter@gmail.com>
Hi Pieter,
On Wed, 2024-08-28 at 12:27 +0200, vtpieter@gmail.com wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> From: Pieter Van Trappen <pieter.van.trappen@cern.ch>
>
> The first KSZ8 series implementation was done for a KSZ8795 device
> but
> since several other KSZ8 devices have been added. Rename these files
> to adhere to the ksz8 naming convention as already used in most
> functions and the existing ksz8.h; add an explanatory note.
Refactoring the file name will better align what the implementation is.
But the file header/Kconfig should mentions what all the switches it
support.
Because there are two switches KSZ8563 and KSZ8567 does not belong to
this Family. Instead it belongs to KSZ9477 family with only difference
they are not gigabit capable.
The switch comes in KSZ8.c files are KSZ8863/KSZ8873,KSZ8895/KSZ8864,
KSZ8794/KSZ8795/KSZ8765.
>
> In addition, remove one last register definition that is already part
> of the ksz_common.c register structures.
This should be separate patch.
>
next prev parent reply other threads:[~2024-08-29 5:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 10:27 vtpieter
2024-08-29 5:35 ` Arun.Ramadoss [this message]
2024-08-29 15:56 ` Pieter
2024-08-29 22:51 ` Tristram.Ha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9066b22b221f97287484f1b961476ce6a67249df.camel@microchip.com \
--to=arun.ramadoss@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pieter.van.trappen@cern.ch \
--cc=vtpieter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®