From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.210.48 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795142190; b=MrF9ZXbTJ+QsOJaMpmqIxeiU8fzHtSGiV6EVycA4PuBnzZ+xt8gSPG5d4NR3969gN3zd CGEq17W9UhMZDXr8sFM2fhMs9gyKkJwPIHGYPTjSDU4pE+64pgPLkj8wfsqVxPyf/H8ym 44pcUTKzBltPf9Yq/Zt0WgwHmQ1tdsBK6WNsZgFayBccQV/lyj9uRGbCUl9C6T+A8oWnT GFW+aXxmOW2cRgkOV1RzD8lcIm5gZS7lX4OBxnAgukofF2vgWomvBdWlEQ37Vt2fj0WXs +w7ZtQTMqcXfPt6aF0h8ZHchsORc4ybAm68Tl1tvx3WXUTU1gUum5yBZNhjQs6v11Kw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795142190; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:Cc:References: Content-Language:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=aVnd9+3ReDHkHlGRcer4MMPc33mybdrj5Cq2BVKAQFc=; b=240UB+wPuAfkeA+6RfxXNLNeMlILrpKZn1ndTW0HraFh0D8jfGmgzDxFfIbqtGi4f3Oy lm0cWs/ktAa44grK7G7b3IKKQGJyxl+okYnJxQ9QqKTkZer7GTKgcojuL0uS6zh4/t+Vu h5wEMfrV21W/gf8qIQ79lC2BnBvyn4MO4HTqSdoS7EJS2yXt5WNsqku6eMy+Cld4lrt75 HRtDiURbm3JfSKHKXDjSc7LpCvhKOAH+YzwOq/LO1EqWSxb7Wf0emaOoGRS5z1HdKDcv+ F4YJEue55wjYWOIEwkhiSIKUS5nKP1s3r09fh4QhzX2i47vMNOk4br0DDMzBqVnv44w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass header.d=riscstar.com header.i=@riscstar.com header.a=rsa-sha256 header.s=google header.b=foql3SGB; arc=none smtp.remote-ip=209.85.210.48 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57F23606A320 for ; Fri, 20 Nov 2026 02:36:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 57F23606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar.com header.i=@riscstar.com header.a=rsa-sha256 header.s=google header.b=foql3SGB Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-862df509d48so285159a34.0 for ; Thu, 19 Nov 2026 18:36:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar.com; s=google; t=1795142188; x=1795746988; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=aVnd9+3ReDHkHlGRcer4MMPc33mybdrj5Cq2BVKAQFc=; b=foql3SGBe3Rq9oCsFUkdTTucFdgN3jVrImSDrUxdIZUh/drXxU4ErM5hUkGjKT9WPC rz8mDme6UPlFmmraq8LBhslHXuhVymCqZWyO+BlKGXrXxGyBqFO21agxbpbb50I175N3 NJl2XCkC2L4tqB8rmwnKwltKLqVliUbO3+Kz8uEIqw7g3sShAe4Z++/lubjj74J6fO1H JglAuz9pLIEEWelptb4EAdGV7xdriEqLVWUL7FQvQiIpS/X07iErdrdctYQ22rs4SGHD 1R4slVaPokh9fwr3dOcNiQ7gdYba8xBP0LMNQ5zblaK0mj3gw4LGmLbpPHnTcNCVgi+H bUvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795142188; x=1795746988; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aVnd9+3ReDHkHlGRcer4MMPc33mybdrj5Cq2BVKAQFc=; b=j42W7l2aBW/o1+FLJva3WW2O+8MLA1bBtyg00cnNXdrgjpAP36M3/8PxqLU8vIJDCO IM5MlksqmXlUoSifwND2Og7wuQTmbGVWhxzEqBnjPtWb4rCdGHrBQq7wH5H2yVXygZJ2 bLUTl4xYM7SOUMpANYfQWbYHI4sMIdWu7Z0AqlovmmqfBdiXebYqNTd896pP26LfhO5m qypDHolEp8sMZFcRXPeB0iuaJDeTd0iyS7ZH82QuAYW7lD2TJwa/2Q8+4d3dc7PnISZX PE/lYxJ++elkJO4ZAh2Fr4cyiOXUFbeZVE+joCzf2g4T+cEGNTQUhSplkUgql8R9dzba +gAg== X-Forwarded-Encrypted: i=1; AL+hErFP6+2YSdQaDn1qYHVpKYEdKw5OeHdY4vJJXoJs4Mys427QqLXNmQtEFQ9r+8GxWvmY9gN3Wf4gqQuAem0=@vger.kernel.org X-Gm-Message-State: APuU4Z/tyEmZzcFC4M8H+tFujV2PDTiD3xj51GTzFSod5OZgvtsQsjrs RVbmaSDeVyNWqaxKS1EQMMMlQ7TMhukImkqdfAMwfBnQu0WXuIQ0g2fS6NhhuJy3FOQ= X-Gm-Gg: AYBFou1SxWfwkJQAz20HxuXscoYtkVfLlBdzCGdcBWz1DVew8o/KrUDIf8jGr3Fes9O aUEOl3FM4R08wayg3O9fnQesxkky5KyI/FYMdxDDALYGEWi9KbXHwiu8DeuOqY42/P8ykMM638+ 5d9GkRA6cvMVZH9DNmN4wbYboiKmpRUCSc3Cn78yVDCcu58OBOl27QImYrXuMNBpzgP6qjPYAeM l3nt+mioZFJRJnWlFX7W1mNkXbGOUyhJF9E3vQnEXTx4/IkjPKBlU6Q8ib26eFCBfF95UZBS/Hj mBQ6KggywrFgHsrico15X2M3U8KOHOcsOWzdlFNvvMf4QnXWLewPV6DqhChTbgvZRl7hQRN0JeP pllv8rTxE4dKqtUz5UNNbkB9qMh8hYvJydxhikgJlHhoGBIG+h9Q5c0UhAI4N4mAwPF/YLkpaA1 BMduIAAIy/Oq0LipEcNbtvV2aadkTdNL3weCPJzac3hu5CMJOyK4JjedxnGv4hYeJN7ElIUhgRQ 1SDvZvMfrGXqJuaJ+8Hs1grAw+Fl/4/5TEB9bfRQP57MVrXcl7zLbUGjSldCHJtoUzxPgDDdKcA hawAGPPnz/NQnws1BBnGtSo+3OaW5Rnc4VF5KpRLGlWi37T5BOY= X-Received: by 2002:a05:6830:4109:b0:861:5d56:bd27 with SMTP id 46e09a7af769-863155f228dmr1753162a34.7.1795142188164; Thu, 19 Nov 2026 18:36:28 -0800 (PST) Received: from [172.22.22.28] ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-8631670c44dsm1127151a34.0.2026.11.19.18.36.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Nov 2026 18:36:27 -0800 (PST) Message-ID: <9066bc1a-3b92-4608-b925-e362847dd1c9@riscstar.com> Date: Thu, 19 Nov 2026 20:36:26 -0600 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] soc: toshiba: tc9564: config system controller From: Alex Elder To: sboyd@kernel.org, bmasney+clk@redhat.com, jbrunet+clk@baylibre.com, p.zabel@pengutronix.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: daniel@riscstar.com, mohd.anwar@oss.qualcomm.com, lorenzo.bianconi@oss.qualcomm.com, fabrice.gasnier@foss.st.com, alexandre.torgue@foss.st.com, marex@nabladev.com, changhuang.liang@starfivetech.com, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261104004332.2141282-1-elder@riscstar.com> Content-Language: en-US In-Reply-To: <20261104004332.2141282-1-elder@riscstar.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/3/26 6:43 PM, Alex Elder wrote: > This series is comprised of some code that was previously sent > separately. It now incorporates a new system controller driver > that advertises clock and reset functionality, as well as regmap > access to its address range. This combination is being treated > as a new series. (Details of previous versions are below.) > > The Toshiba TC9564 is an SoC that attaches to a host system via PCIe. > It includes a PCIe switch with three downstream ports. To one of > these ports an embedded PCIe endpoint is attached, and that implements > two PCI functions. BAR 4 for both PCI functions provides access to > registers controlling blocks within the SoC. > > The system controller driver adds the clock and reset devices > using the mfd_add_devices() interface. The clocks and resets > are implemented by drivers included in this series. Krzysztof Kozlowski questioned the use of the syscon for this chip, and after some offline discussion I agreed to go without it. This means Conor's ack won't be included, and I won't be doing anything I said I would that was related to the syscon. The clock and reset drivers can each stand alone, without using a shared regmap. Each of these drivers uses two registers. But in both cases, the two registers are discontiguous: clock: 0x1004 and 0x100c reset: 0x1008 and 0x1010 It has been suggested before that separating the reset and clock drivers has advantages, but I think in this case, the simplicity of the combined driver (especially because of the interleaved registers) is the better option. For that reason, I intend to *combine* these two drivers into a single clock controller driver that provides both clocks and resets. The source code will reside under drivers/clk. The combined device will have a single DTS node, defined by a single devicetree binding, and will use a single contiguous address range: clock+reset: base 0x1004, size 0x10 The next version of this series would have no syscon, and with the clock and reset support combined, it will basically be a new series. I'll provide links back to this and older code, but the next iteration will consist of: - A single devicetree binding for the clock+reset combined. - A header file defining clock and reset IDs, here: include/dt-bindings/clock/toshiba,tc9564.h - A single source file, drivers/clk/clk-tc9564.c (plus updates for Kconfig and Makefile) -Alex > > -Alex > > The system controller, along with its devicetree binding are new. > My hope is that this new model addresses concerns that Krzysztof > Kozlowski has expressed in prior versions of the clock and reset > code ("fold into the parent"). > > The clock controller driver was last posted as version 3, and all > feedback from prior versions has been addressed. This driver has > essentially been completely rewritten. There are now three clock > types (PLL, fixed factor, and gate), and each defined clock has > a parent, and the is_enabled callback is implemented for the gate > clocks. > > The last version of the clock driver is here: > https://lore.kernel.org/lkml/20261012152408.3729237-1-elder@riscstar.com/ > > The reset controller driver was last posted as version 1. All > feedback received on that version has been addressed, and it's > a bit simpler than before. > > The last version of the reset driver is here: > https://lore.kernel.org/lkml/20261012164354.3872326-1-elder@riscstar.com/ > > Alex Elder (4): > dt-bindings: soc: introduce toshiba,tc9564-config-syscon.yaml > soc: toshiba: tc9564: add a new syscon driver > clk: toshiba: introduce a TC9564 SoC clock driver > reset: toshiba: introduce a TC9564 SoC reset driver > > .../toshiba/toshiba,tc9564-config-syscon.yaml | 68 +++++ > MAINTAINERS | 23 ++ > drivers/clk/Kconfig | 12 + > drivers/clk/Makefile | 1 + > drivers/clk/clk-tc9564.c | 288 ++++++++++++++++++ > drivers/reset/Kconfig | 12 + > drivers/reset/Makefile | 1 + > drivers/reset/reset-tc9564.c | 135 ++++++++ > drivers/soc/Kconfig | 1 + > drivers/soc/Makefile | 1 + > drivers/soc/toshiba/Kconfig | 12 + > drivers/soc/toshiba/Makefile | 3 + > drivers/soc/toshiba/tc9564-syscon.c | 42 +++ > include/dt-bindings/soc/toshiba,tc9564.h | 46 +++ > 14 files changed, 645 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/toshiba/toshiba,tc9564-config-syscon.yaml > create mode 100644 drivers/clk/clk-tc9564.c > create mode 100644 drivers/reset/reset-tc9564.c > create mode 100644 drivers/soc/toshiba/Kconfig > create mode 100644 drivers/soc/toshiba/Makefile > create mode 100644 drivers/soc/toshiba/tc9564-syscon.c > create mode 100644 include/dt-bindings/soc/toshiba,tc9564.h > > > base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4