From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE0A72BEC57 for ; Thu, 19 Mar 2026 17:14:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773940458; cv=none; b=D0iki5ZNir8ZfwfZ+VOUO36ikXPNQl3b13hY9SWRFdxe1raIDGbg0hw6g4jPbM0Ua5dejxV5XZN4P1f5iLY6/LaSuojmcnFUNfjZuVPtrasuEmYj/qpSPtsaGehFkIOyNyoR90ASdI1F6xd7h53eK/c3NcJmgBf9abJl5t47PXM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773940458; c=relaxed/simple; bh=n2XhxB6Bus+9R4ghVytOWb8/f9ONXhDB15PjtKG3xOs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=flxFZ/zS3bnCWPxIxxLJL5rHSh+IFL/AyRUumTUD4xkqKK2m9rukAisL3IR+YQpAVFGZnaZY4500Q0WoVZrnwpgaJkjib9kw4aj+PDU38OA+cpSNWnEoPtiDBa1YqWSMhUDx5W1N6amVN8uZipT78eue1XVgEAOyqWGFyk3edgI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=Jk/VekBp; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="Jk/VekBp" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zr7XIjoFEzFLo+wdlJ0zAdxNaSX14JFeqx60xnzIONE=; b=Jk/VekBp7Mu6/Z5r7C7bfs5J3z xIpxduH8DhP9bWUuNhGEiuOf7800lXE5iKBckYqEAR/kqtYnHZLQJXN2XwgOArzn4GFUvsoamYYIN YBgxEhxHxvUuWx9LHpIAPoo6A4xwolHV8xeaqoQOILKoJJfFZL2owVypHflCBJyfzxF0GtJc/hx4V Jynd1yKmq/txVnwjqPJo0QtWeOnC1SsU219fJdBTisb+zFpXhfFS7CpUSZ9DcEx/DWdXsJNmJrKWZ D21r+jyyvwnmfnayWZxFIB5r5943bQyP05iSkMZBLk2wcN3GUHcKZT5OKXaMBx0e9CSaN9t1BsWgo hiYxrSmw==; Received: from [179.93.15.111] (helo=[192.168.1.54]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1w3Gwe-003Qxa-1g; Thu, 19 Mar 2026 18:14:04 +0100 Message-ID: <9066d011-7dd6-4d2e-26b0-72f83d3e5862@igalia.com> Date: Thu, 19 Mar 2026 14:14:00 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v3 2/2] mm/memblock: Add reserve_mem debugfs info Content-Language: en-US To: Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, Andrew Morton , Steven Rostedt , SeongJae Park References: <20260318190816.1811325-1-gpiccoli@igalia.com> <20260318190816.1811325-3-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/03/2026 13:34, Mike Rapoport wrote: > [...] >> -static int __init memblock_init_debugfs(void) >> +static inline void memblock_debugfs_make_dirs(struct dentry *root) > > This does not make dirs but rather exposes files representing memblock > arrays. > > How about calling this function > memblock_debugfs_expose_arrays()? > I sincerely couldn't agree more - it should have have been a braino, why on earth I called it this way?! Apologies, will respin soon...will wait until weekend in case someone else has opinions. >> { >> - struct dentry *root = debugfs_create_dir("memblock", NULL); >> - >> - debugfs_create_file("memory", 0444, root, >> - &memblock.memory, &memblock_debug_fops); >> - debugfs_create_file("reserved", 0444, root, >> - &memblock.reserved, &memblock_debug_fops); >> #ifdef CONFIG_HAVE_MEMBLOCK_PHYS_MAP >> debugfs_create_file("physmem", 0444, root, &physmem, >> &memblock_debug_fops); >> #endif >> + debugfs_create_file("memory", 0444, root, >> + &memblock.memory, &memblock_debug_fops); >> + debugfs_create_file("reserved", 0444, root, >> + &memblock.reserved, &memblock_debug_fops); > > No need to move these after PHYS_MAP attribute > OK, your call, will change it in the respin as well. Thanks, Guilherme