From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6282C4E13E0 for ; Tue, 13 Oct 2026 10:57:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791889063; cv=none; b=bUQSrl7RRM8/KkNFEJH6x2q/f5fKMftV60HEgefY+Nv/5ewYHCl3k9JZNvFQnE8lvY//Gv2Q3MM8PCb3xDFtXlh2j+PMNvUWT82Dre3B5B/pX8o3/AMUjxCcm9bBXpxo84TR4WGPlXRR4fVRCFJeGWwOSwH0ySIgr078I/Z5Jps= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791889063; c=relaxed/simple; bh=LeuVRKKz/qv40OJ9BUPv9V7/knp4nTd44u+8dX3auLI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KoCsInVu5gHlZmqOZf/Fcjy9/8ZdSTEKtMGPf3qHsb5kkROOLLOgfawCezM1jRSIWYPVPObXmCzc7rA8a/Qh3frLhgaD3Q/c6ZHiAW6VTnINdrsioXL9vuOqvDap6x5Tg2491+n/fZzWsoWbLA4Aq29EguDbE02VC5UrXUERJ5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=I90/xmiC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dNLvTxuV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="I90/xmiC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dNLvTxuV" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69D900Oo791170 for ; Tue, 13 Oct 2026 10:57:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tSEpmU69diOtyJsEu93q34ttA2iL6Hvw0WchJvAmD5o=; b=I90/xmiCWR8WibwX oOgEZXTkzbFZSo65c6ZLMdeB7caCxJnWtUeLDHUOk0gBOrnavgTaEQ6wZSqKWPWb fll6DD/vpCKecwKQWcZoSbTCOgccG+61qaieV0V6/b81BLkevNKwlWqIrAciCO5a yA2Hs2RkhuERSOXAX+ZtCVFzG7+t5nj+UcjDYqJt45CEzAzisyzpCtb/bRQw8A3K W33c4vHRDttJPxG0JQ3p3ztQC7qLuP/p9d2bOePEMI3lTUzig5OXSm1+Sg3x5f/3 YRnUNXNcI9AbT9BwDFdYZeKZ/fTcyBp1ccjvCBXGiexNGaqoazdSfBPfTgfM7riM aTLgNA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h9hmjrgk7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 13 Oct 2026 10:57:37 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5338a4075d3so9941981cf.1 for ; Tue, 13 Oct 2026 03:57:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791889056; x=1792493856; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tSEpmU69diOtyJsEu93q34ttA2iL6Hvw0WchJvAmD5o=; b=dNLvTxuVuhYHFEFqVRJDKJ7wWKv3VAtJlnfCzgURFS8Jlf2/3Jbat1BcV0kC0NswFL SguNYY0czeZTix3ZXnOkzpceMzv4ThXqwGyBq++tMHp+qkAIL9C2fg6QhSS07HJsRdRK 1mJXTy8XG9V+8ckIQ8kjs5SPO2tu9NP7jDMWYemum+hCt59/Hu7twHVzydL5rlsKwmZw jv9XCSKrsjgOVrU5bnMXLM0hAlFFoQMsianpIRbpd0lKCJPqOdQoBKpM3eTvmGLgKXXC C5Tz26fFADZnjiqp4aLDml7vczAIzGQkW8rGT6rqqtP2dDEkyce2K9TrFxc6Veuw8ABe aDvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791889056; x=1792493856; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tSEpmU69diOtyJsEu93q34ttA2iL6Hvw0WchJvAmD5o=; b=tZdDoWMFjYj3FsSyb8p4R2I+sreh1qK6rUhhW2VhUKmdQpFm9zRfUi8Bb9x6E4Pb/l ojA/SHq6VCWLMDWqG5nu9nLCjsa/BKDBhWFJxXJ0zgP42AdW/lE4Hpd1KgacALoSWCyG aw54+VpF6NVCPmWUXs6Q0o5W6uQLVeT0qRJJG31RjGOrQ64iUrPFqdAYGJWMYu/8dpf8 JkTPZ3zfgtXAjrIJ5h+KN9enLH8IQ4tA5QekOEKvwVTND0xxUrbQC6r6b16YqZmIyJqg HB2gg+mv+qjx8Op2CUJmN4ut9BSQksN0TjP4SnGccyTepP/Sq7+b2YIasUVrR+B3u+8m 89Lw== X-Forwarded-Encrypted: i=1; AKwUvBwK5YDM7hqroC+x64176WYB6gorGXAjlsyK7dT1iAYGon/PDrVeAN4qWMrE+8XjINID9yut2n8klGUWOWk=@vger.kernel.org X-Gm-Message-State: AFq9FYISywFE/dKDxMwxkHxZb/hvo0R9W8jN0k+D7exQFYpi6DXuo0f5 d9H+vbZ5IABqTUEhpGTZ26jv2YhuhjkPW6UE2LhVSfxelYb/7hU9thSgI7Z8sfm1nFj38RNXE/a e8a9v7OVEtszes6ok83Jn3yXtIgzzFBCgE7kt9Yluka6Un1ByRvu7tzAqYFgmnxXe3D4= X-Gm-Gg: AYBFou3zjQyrYI/1vlM1Y1Bgitkj8vapbin0UXol7cIev+R9Ae7PSo7A1fCITD6Gvog cMQJPpEh+qE9bXfeqmMPEMHytIvf8t7Vy4tr8faog3HoWfvN9MFJWBM+lHwpnA2Doyg1xOv2FfM 8M3XK24fd/PA8dr9Ib9AOLEswh2RAVAazPmYWnah11JaIHV6pPD0LAkUXZPU9dhIXEHsvKLlWww TVQRtZR6sbPRZLKarEKryVgt06WKDdMLIicZBsSVKfffUUQUf64ocsMjgHv/LsnW8INFElc3mzb sEaEK8/gK1yOYIC7llTSKliYsVo+ubotb3HgfDM5F5n7HziaczVPjbNrY3PX49gtg7O3ggyexvQ t5zwljH7f5IKuKtT/G8z8JQ== X-Received: by 2002:a05:622a:586:b0:533:96b4:8dd4 with SMTP id d75a77b69052e-5359f4965eamr243719081cf.1.1791889056364; Tue, 13 Oct 2026 03:57:36 -0700 (PDT) X-Received: by 2002:a05:622a:586:b0:533:96b4:8dd4 with SMTP id d75a77b69052e-5359f4965eamr243718701cf.1.1791889055675; Tue, 13 Oct 2026 03:57:35 -0700 (PDT) Received: from [192.168.226.26] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c36fa559721sm67647966b.56.2026.10.13.03.57.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Oct 2026 03:57:34 -0700 (PDT) Message-ID: <9067a9aa-3edc-4139-9310-977a9a8cd793@oss.qualcomm.com> Date: Tue, 13 Oct 2026 12:57:31 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] arm64: dts: qcom: glymur: Fix fastrpc compute-cb reg values for cdsp To: Rob Herring , Ekansh Gupta Cc: Bjorn Andersson , Konrad Dybcio , Abel Vesa , Krzysztof Kozlowski , Conor Dooley , Sibi Sankar , Srinivas Kandagatla , Bharath Kumar , Chenna Kesava Raju , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Mahima Bhattaram , Pankaj Patil , Abel Vesa , Mukesh Ojha References: <20261007-glymur-dtfix-v4-0-31f7143e759b@oss.qualcomm.com> <20261007-glymur-dtfix-v4-2-31f7143e759b@oss.qualcomm.com> <20261007204549.GA234290-robh@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20261007204549.GA234290-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYxMDEzMDA0MyBTYWx0ZWRfX2liber41k/Rt QTM3PmUM5a/ygJ/8dcBXEEa9xWyeiCx1RnKQdYw4+6YIqs0bHmyBoYqO5NTmQngd2OWGpgjnDsQ 7Ir+1Z55+TnW4cWHgkPGLjH/HmxDzlA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDEzMDA0MyBTYWx0ZWRfX5y101/BUSzop TtA3nE3/EnKtwx7/IWMqFabQX2jfS7ZTcbf4OqmiKQecLT9/KV5V4lWCW6svjc4zbdqoF9Dc3iy f8K/qEt0/tKANlgGSbvCmnzfFS2dok1/Cgtmi8UhH9xJO4ovWUL2ElNXp8UcQ4WPX4NSAfujpbT t0z9sN5gm8O7MtrXJCD2d/N7x/57uvcdoXjtyyzuxQSHAUlIpXSgtk8pToiV1sJzpyH3gstGb4A nkR8Wkt3+/Ex8fMT3S51fGRNSi47+fg3R9nmT71RxmVyeBhqqXhdqclq10e7fUVCMKCjaqMkfZJ z8wNjaPYdCKbIGPig/jV4ENkm8+89o5E29wjbscFB07Ndsk6ZUHuQKDS7yWpI38zLdFX6vgOHGZ s9ZKqwwxZDuHzULjwuEz3ULgSCDoCyIfx3U/Ql9e0NfIarwkLobvVcq2TMlpmVfmyfPOtTTZQzi prMqTEhjHbG6kLaioBA== X-Proofpoint-ORIG-GUID: sQ8mPesOPQxYS6doCQ4oMBpd2jn2DBqy X-Authority-Analysis: v=2.4 cv=O5+sLx9W c=1 sm=1 tr=0 ts=6ace0ea1 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=SYeg_LyZQ0ZiSJgYx_IA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: sQ8mPesOPQxYS6doCQ4oMBpd2jn2DBqy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-13_01,2026-10-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 adultscore=0 spamscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610130043 On 10/7/26 10:45 PM, Rob Herring wrote: > On Wed, Oct 07, 2026 at 03:51:18PM +0530, Ekansh Gupta wrote: >> The reg value of a compute-cb node must match the SID (the lower >> nibble of its IOMMU stream ID) it is associated with. In the cdsp >> fastrpc node, compute-cb@10, compute-cb@11 and compute-cb@12 were >> mistakenly given reg values of 10, 11 and 12 instead of 12, 13 and >> 14, which don't match their SIDs and leads to SMMU translation errors. >> Fix the reg values, and rename the nodes accordingly. >> >> Fixes: cd1d174c75f7 ("arm64: dts: qcom: glymur: Add ADSP and CDSP for Glymur SoC") >> Co-developed-by: Mahima Bhattaram >> Signed-off-by: Mahima Bhattaram >> Reviewed-by: Pankaj Patil >> Reviewed-by: Abel Vesa >> Reviewed-by: Mukesh Ojha >> Signed-off-by: Ekansh Gupta >> --- >> arch/arm64/boot/dts/qcom/glymur.dtsi | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi >> index de7c395d9c35..3219603372ce 100644 >> --- a/arch/arm64/boot/dts/qcom/glymur.dtsi >> +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi >> @@ -8471,9 +8471,9 @@ compute-cb@8 { >> >> /* note: compute-cb@9 is secure */ >> >> - compute-cb@10 { >> + compute-cb@c { >> compatible = "qcom,fastrpc-compute-cb"; >> - reg = <10>; >> + reg = <12>; > > Normally, reg is written in hex too. +1 please do that Konrad