From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 281F8C433E2 for ; Fri, 4 Sep 2020 19:37:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D97C02083B for ; Fri, 4 Sep 2020 19:37:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727077AbgIDThZ (ORCPT ); Fri, 4 Sep 2020 15:37:25 -0400 Received: from smtprelay0195.hostedemail.com ([216.40.44.195]:34122 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726221AbgIDThX (ORCPT ); Fri, 4 Sep 2020 15:37:23 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id D6807181D3028; Fri, 4 Sep 2020 19:37:22 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: meat92_0910680270b4 X-Filterd-Recvd-Size: 2254 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA; Fri, 4 Sep 2020 19:37:21 +0000 (UTC) Message-ID: <906c2ffb0ef6b2d87d6aecdf60b61833ea79e4fb.camel@perches.com> Subject: Re: [PATCH v6 18/18] crypto: sun8i-ce: fix some style issue From: Joe Perches To: Corentin Labbe , davem@davemloft.net, herbert@gondor.apana.org.au, mripard@kernel.org, wens@csie.org Cc: linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Date: Fri, 04 Sep 2020 12:37:19 -0700 In-Reply-To: <1599217803-29755-19-git-send-email-clabbe@baylibre.com> References: <1599217803-29755-1-git-send-email-clabbe@baylibre.com> <1599217803-29755-19-git-send-email-clabbe@baylibre.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-09-04 at 11:10 +0000, Corentin Labbe wrote: > This patch fix a double empty line issue reported by checkpatch. > While at it, since now the maximum line length is now 100, reorder some > wrapped line. [] > diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c [] > @@ -164,12 +164,10 @@ static int sun8i_ce_cipher_prepare(struct crypto_engine *engine, void *async_req > goto theend_key; > } > offset = areq->cryptlen - ivsize; > - scatterwalk_map_and_copy(rctx->backup_iv, areq->src, > - offset, ivsize, 0); > + scatterwalk_map_and_copy(rctx->backup_iv, areq->src, offset, ivsize, 0); > } > memcpy(rctx->bounce_iv, areq->iv, ivsize); > - addr_iv = dma_map_single(ce->dev, rctx->bounce_iv, rctx->ivlen, > - DMA_TO_DEVICE); > + addr_iv = dma_map_single(ce->dev, rctx->bounce_iv, rctx->ivlen, DMA_TO_DEVICE); coding-style.rst: Statements longer than 80 columns should be broken into sensible chunks, unless exceeding 80 columns significantly increases readability and does not hide information. Do these longer lines make the code significantly more readable? I don't think they do.