From: Matthias Brugger <matthias.bgg@gmail.com>
To: Chen-Yu Tsai <wenst@chromium.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: "Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: mediatek: SVS: Fix MT8192 GPU node name
Date: Fri, 9 Jun 2023 16:35:13 +0200 [thread overview]
Message-ID: <906ced27-2a01-f069-cf42-58674b0e2d65@gmail.com> (raw)
In-Reply-To: <20230531063532.2240038-1-wenst@chromium.org>
On 31/05/2023 08:35, Chen-Yu Tsai wrote:
> Device tree node names should be generic. The planned device node name
> for the GPU, according to the bindings and posted DT changes, is "gpu",
> not "mali".
>
> Fix the GPU node name in the SVS driver to follow.
>
> Fixes: 0bbb09b2af9d ("soc: mediatek: SVS: add mt8192 SVS GPU driver")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Applied, thanks
> ---
> drivers/soc/mediatek/mtk-svs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
> index 81585733c8a9..3a2f97cd5272 100644
> --- a/drivers/soc/mediatek/mtk-svs.c
> +++ b/drivers/soc/mediatek/mtk-svs.c
> @@ -2061,9 +2061,9 @@ static int svs_mt8192_platform_probe(struct svs_platform *svsp)
> svsb = &svsp->banks[idx];
>
> if (svsb->type == SVSB_HIGH)
> - svsb->opp_dev = svs_add_device_link(svsp, "mali");
> + svsb->opp_dev = svs_add_device_link(svsp, "gpu");
> else if (svsb->type == SVSB_LOW)
> - svsb->opp_dev = svs_get_subsys_device(svsp, "mali");
> + svsb->opp_dev = svs_get_subsys_device(svsp, "gpu");
>
> if (IS_ERR(svsb->opp_dev))
> return dev_err_probe(svsp->dev, PTR_ERR(svsb->opp_dev),
prev parent reply other threads:[~2023-06-09 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 6:35 Chen-Yu Tsai
2023-05-31 8:12 ` AngeloGioacchino Del Regno
2023-05-31 9:18 ` Alexandre Mergnat
2023-06-09 14:35 ` Matthias Brugger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=906ced27-2a01-f069-cf42-58674b0e2d65@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=nfraprado@collabora.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®