From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE48D3191CE for ; Mon, 29 Dec 2025 13:32:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767015147; cv=none; b=M3hQ5r8QfqeShJyj9TmbbhyYKsisoTwW0Fmu+ULQ4+BV0jSGHdZqh4ERRx+hkQg1GagQ15PEigy15vQZiLt0PgHOrcfKF5E2he/+UnbBp5mSgCQptnEivfVWe3JhFXSxx9BS0v4r5LXRua3b3tOO+1Lcj5hTThXCWtFASA20sUo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767015147; c=relaxed/simple; bh=cjm2ARDU4Ilw36GA6XP8oG+tMJuID0N8F0GSM/rH/Xk=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=XgAQjVHxlnVdyYQ7wtveipf5+Z1Ni2Qk6T1xYZd8Nmg0iTtX/5Y4Qcu3IirCZpLT+DsNSky5Jws+fAu31JCMwTCYsG71j2jeRR8uGA6rV1DND2wrDohy68eZk1w8TEDpyrmfHnrIYfdrTNlod0lj4vAvNt6iR96Dln5XR5teAM8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Vk8Gtq/G; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vk8Gtq/G" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-47a9567bcd9so6737395e9.2 for ; Mon, 29 Dec 2025 05:32:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767015144; x=1767619944; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=TH+hcq7bd4mxCYeCUmeAujqoUODEJoLDU3mL4QihJ+I=; b=Vk8Gtq/GjGO58WYU7NEBnPzu9phufBPwVWt4ajhiOfeitaJiLd15FsUrTDcoY+tELr 8df5QK1a5pdjSK0zYybWYv6LIKHJXxbYyFjj20pb9Ki0vIuUuPjujgO0qz0ZGr7CJquA suBmC6GsgQZ9gMvToUnfZ5iFqVqyN1G9mvVWQZcTyazb6XyqiH5tJpoYo21+E6crRmrm JNIXNIq3R1cH9+se0Ecc9UtRkxUkmc6pqcKW7b6vT7dj3yZiRawpzdVxgN0Cuyw+w3z5 a42LfvPnR/INxw2E3dvodUAAAj4L8Gm6cKPDj8KqJqEwHfNG5yPHg13Oemaii5rgR02h alZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767015144; x=1767619944; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TH+hcq7bd4mxCYeCUmeAujqoUODEJoLDU3mL4QihJ+I=; b=W+6PKxrahy2w006cVWPvH0Rv8Ti00hoPc9zSvUHFa9xQ9cS/dvHZLu71VmGDkQMhz1 NMkNQes/o12kQUGyhAPgCiy8nSnb3yM/sr5XPre8EXJPqSfB/1N/mgmquZ/ikFRjmfmg thf0D0P6pjpj1HC0/zExQMSxMktz3wGbVDrU1BE9AZ7Pj4x0W9Rm39U4hRfEhoD0l66x xjT2dxtrqk5eqHpSkF6Uc2vaBYEd43m4Zfs+jQq1khhqKl/MS4nTyaz4a4V6CyyN4Frf rXEVVuv5KFjcK7ySEjGibCN5+xBkP6cBheRLOWzNghPULitvrHmYmN+fSO99aFnX7rWk xJ/w== X-Forwarded-Encrypted: i=1; AJvYcCUOuDNtr0/wKr1UChRNlcMw0y8n3lIKODGwQWPAR2FcHZsqqEMqTLYyAcq+R1eeAfQ0vcQM0dYTUxDerXw=@vger.kernel.org X-Gm-Message-State: AOJu0YyF/ikjgq2kCsNX2ufeKidKCx2IBrm1rGUWWnjBDgmS0ph4ahW2 YDV3S0unabqEkyLxR6qsHpe1jz8ScgZ3ZjqwMI4KB6LELEhSeplsU9ao X-Gm-Gg: AY/fxX4zhtK17D3WUjdI1keti/F4KAg3/VZM12noInmgatRdsbwBMd4ZsxhTUVgp56q MPLgRGEX4X3rLaSg27x31uzxSYLalOwgH4BbbHlhef09irUjvO1Q1DRc6PFWQIiJuihpdlF95AU L6a8EEcDgZWA7XjE8/cUCbqQKdJP0uL0rS0E0msfu2aC5vtZZDz64fsWXDlBEad29wUFkAI1Fwk Tf7dYnUXQjnsOBo96Y6APy3DNHV1UE+Ev47FHRa6FKOcc2VBbn6C+iv+mkb1Sc58y5XCIHsFUU3 ynrqmScs7dNZ2jQrurp0ttLyK7OKKqw8RHLSmfPSyhcNA1RMRQr55fVVnU2tTSm3PJFQAUyr995 ulZF2TeW3Q2eLCbuOcuDDkpvXYuLD2wlYAJNzu7dKrRKhIYrBGL980K1izHu0WUStnIkvbqz7k3 vrdjdD/wELo1/nyZ9AlKznXSMgqhb8TNcpou8edoOLsZddjpvPGyOi X-Google-Smtp-Source: AGHT+IHszWy0+s83zJSwanWUVcASb7lQtk8CjsaWtYMfYyLjCXdDlLtmTCgSm1MFc64raO36ZloPcg== X-Received: by 2002:a05:6000:4305:b0:431:32f:3153 with SMTP id ffacd0b85a97d-4324e51040fmr22586616f8f.7.1767015143929; Mon, 29 Dec 2025 05:32:23 -0800 (PST) Received: from [128.93.83.215] (wifi-pro-83-215.paris.inria.fr. [128.93.83.215]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1b36fsm62031162f8f.5.2025.12.29.05.32.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Dec 2025 05:32:23 -0800 (PST) Message-ID: <9074448b-1b2c-4791-94ed-0ac296f0b897@gmail.com> Date: Mon, 29 Dec 2025 14:32:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] ethernet: cxgb4: Fix dma_unmap_sg() nents value From: Thomas Fourier To: Potnuri Bharat Teja Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250623122557.116906-2-fourier.thomas@gmail.com> Content-Language: en-US, fr In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 25/06/2025 15:27, Thomas Fourier wrote: > On 24/06/2025 17:17, Potnuri Bharat Teja wrote: >> On Monday, June 06/23/25, 2025 at 14:25:55 +0200, Thomas Fourier wrote: >>> The dma_unmap_sg() functions should be called with the same nents as >>> the >>> dma_map_sg(), not the value the map function returned. >>> >>> Fixes: 8b4e6b3ca2ed ("cxgb4: Add HMA support") >>> Signed-off-by: Thomas Fourier >>> --- >>>   drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c >>> b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c >>> index 51395c96b2e9..73bb1f413761 100644 >>> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c >>> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c >>> @@ -3998,7 +3998,7 @@ static void adap_free_hma_mem(struct adapter >>> *adapter) >>>         if (adapter->hma.flags & HMA_DMA_MAPPED_FLAG) { >>>           dma_unmap_sg(adapter->pdev_dev, adapter->hma.sgt->sgl, >>> -                 adapter->hma.sgt->nents, DMA_BIDIRECTIONAL); >>> +                 adapter->hma.sgt->orig_nents, DMA_BIDIRECTIONAL); >>>           adapter->hma.flags &= ~HMA_DMA_MAPPED_FLAG; >>>       } >> Thanks for the patch Thomas. >> this fix needs below change as well: >> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c >> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c >> @@ -4000,7 +4000,7 @@ static void adap_free_hma_mem(struct adapter >> *adapter) >>          } >> >>     for_each_sg(adapter->hma.sgt->sgl, iter, >> -                   adapter->hma.sgt->orig_nents, i) { >> +                   adapter->hma.sgt->nents, i) { >>                  page = sg_page(iter); >>         if (page) >>                          __free_pages(page, HMA_PAGE_ORDER); > > I don't think this change is correct since this loop iterates over all > the pages > > allocated at line 4076, not over the dma mapped pages. > > It also seems that when passing the dma addresses to hardware, > > the newpage assignment is not used line 4104 and that the dma mapping > > length is not given to hardware.  Is that correct? > >>> -- >>> 2.43.0 >>> Hello Potnuri, Any update on this patch? Thanks for your time, Thomas