From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751418AbcKNA2p convert rfc822-to-8bit (ORCPT ); Sun, 13 Nov 2016 19:28:45 -0500 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:56450 "EHLO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752622AbcKNA2n (ORCPT ); Sun, 13 Nov 2016 19:28:43 -0500 From: "Rafael J. Wysocki" To: Borislav Petkov Cc: Randy Dunlap , LKML , Andy Henroid , linux-pm@vger.kernel.org Subject: Re: [PATCH] idle/i7300: Add CONFIG_PCI dependency Date: Mon, 14 Nov 2016 01:36:15 +0100 Message-ID: <9076226.zObyvXuPt3@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.9.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20161030163247.l5nj4b52un3nef6z@pd.tnic> References: <20161030114228.24114-1-bp@alien8.de> <1e525299-ffb2-4031-a215-c9407c22a312@infradead.org> <20161030163247.l5nj4b52un3nef6z@pd.tnic> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, October 30, 2016 05:32:47 PM Borislav Petkov wrote: > On Sun, Oct 30, 2016 at 07:54:44AM -0700, Randy Dunlap wrote: > > depends on PCI > > (no CONFIG_ prefix) > > Whoops! > > Thanks. FWIW, it didn't fire even with "depends on CONFIG_PCI" anymore. > Didn't investigate why though... > > --- > From: Borislav Petkov > Date: Sun, 30 Oct 2016 14:39:28 +0100 > Subject: [PATCH] idle/i7300: Add CONFIG_PCI dependency > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > ... in order to fix this randconfig build warning: > > drivers/idle/i7300_idle.c: In function ‘i7300_idle_stop’: > ./include/asm-generic/bug.h:117:24: warning: ‘got_ctl’ is used uninitialized in this function [-Wuninitialized] > int __ret_warn_once = !!(condition); \ > ^ > drivers/idle/i7300_idle.c:415:5: note: ‘got_ctl’ was declared here > u8 got_ctl; > ^ > > Signed-off-by: Borislav Petkov > Cc: Andy Henroid > Cc: linux-pm@vger.kernel.org > --- > drivers/idle/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/idle/Kconfig b/drivers/idle/Kconfig > index 4732dfc15447..a066fca3688f 100644 > --- a/drivers/idle/Kconfig > +++ b/drivers/idle/Kconfig > @@ -18,6 +18,7 @@ config I7300_IDLE_IOAT_CHANNEL > config I7300_IDLE > tristate "Intel chipset idle memory power saving driver" > select I7300_IDLE_IOAT_CHANNEL > + depends on PCI > help > Enable memory power savings when idle with certain Intel server > chipsets. The chipset must have I/O AT support, such as the > Applied. Thanks, Rafael