From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-219.mta1.migadu.com [95.215.58.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8370B47CA8F for ; Fri, 2 Oct 2026 09:56:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.219 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790934994; cv=none; b=H+LVtiA4OHpZc88qp336OPJX/4X+qve/SvKRley30h+TZfb74W4TxzON40ye5Qvc/2M/NvdCgOltiE28YlCyU8iX1ihaTkNc9zdw0wz46b2RWkTa5vABjDNvaQnYyRYp0HyCCb3bO6HG7/qqIzMJD8XMGBH9H+cINptjmOcCBkk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790934994; c=relaxed/simple; bh=92W4VZCSKNhkkdED6V3xajazvmttQRmFoqQ3AYY4EWM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f7KkeQjdykgHZF3HOS9NWUHs225FpJ0kuUYQ/NL41AZDnbEj5kbYAAHTEWbHsyuKkCJhwJLCS0T2GqWiOgzfovEL2utygO7Dd/p+aAP2R9+m2wiyolTM1TrpJvbwJTGX1T6l28+4SrXbRwOIQwfrYNLPVNIfp6Fa9ppeMLAnuFI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=b5oyFE+f; arc=none smtp.client-ip=95.215.58.219 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="b5oyFE+f" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=92W4VZCSKNhkkdED6V3xajazvmttQRmFoqQ3AYY4EWM=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1790934990; v=1; x=1791539790; b=b5oyFE+fGttIayEVYegFIhQNE6Q6KsL6uTfFMJ/T9zt5G5ZFHRvH/KsoDFxHQd5/bVIibyp5 UhxfVEFdRSjdlr0EgVGTpfK4a4at6JZxHxmQRJqlWqk38F1mEj3M0MwkAhbhuqB/PTdL2ae2Pmn zV6G043MEUypvzZjhpIwNsrM= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 5ac8ebf340b273e0; Fri, 02 Oct 2026 09:56:30 +0000 X-Mizu-Trace-ID: 5ac8ebf340b273e0 X-Migadu-Flow: FLOW_OUT Message-ID: <90811f7b-1751-49cb-bf0b-3d5ee7f10e45@linux.dev> Date: Fri, 2 Oct 2026 17:55:56 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 10/40] drivers/usb/mon: update to use mmap_prepare + map kernel pages Content-Language: en-US To: "Lorenzo Stoakes (ARM)" Cc: linux-mm@kvack.org, "Liam R. Howlett" , Andrew Morton , Jann Horn , Pedro Falcato , David Hildenbrand , Suren Baghdasaryan , Mike Rapoport , Vlastimil Babka , Michal Hocko , Jonathan Corbet , Paul Moore , Leon Romanovsky , Greg Kroah-Hartman , Dennis Dalessandro , Jaroslav Kysela , Jason Gunthorpe , Thomas Gleixner , Usama Arif , Dave Hansen , linux-kernel@vger.kernel.org, Kumar Kartikeya Dwivedi , Daniel Borkmann , Eduard Zingerman , Zi Yan , Nico Pache , Namhyung Kim , Ryan Roberts , x86@kernel.org, Dev Jain , Barry Song , Kiryl Shutsemau , "Martin K. Petersen" , Baolin Wang , "James E.J. Bottomley" , Simona Vetter , Peter Xu , Masami Hiramatsu , Sebastian Reichel , Borislav Petkov , Arnaldo Carvalho de Melo , Harry Yoo , Rik van Riel , Peter Zijlstra , Helge Deller , Mark Rutland , Ingo Molnar , Juri Lelli , Maarten Lankhorst , Vincent Guittot , Thomas Zimmermann , Catalin Marinas , Nhat Pham , Gerald Schaefer , Maxime Ripard , Nick Piggin , "Aneesh Kumar K.V" , Muchun Song , Marc Zyngier , Will Deacon , "Matthew Wilcox (Oracle)" , Arnd Bergmann , Madhavan Srinivasan , "David S. Miller" , Paul Walmsley , Anup Patel , Palmer Dabbelt , Albert Ou , Vasily Gorbik , Baoquan He , Andreas Larsson , Claudio Imbrenda , Kemeng Shi , Gregory Price , Rakie Kim , Christian Brauner , Alistair Popple , Axel Rasmussen , linux-doc@vger.kernel.org, Alexander Viro , Matthew Brost , Ying Huang , Byungchul Park , Joshua Hahn , Xu Xin , Chris Li , linux-usb@vger.kernel.org, Qi Zheng , Yuanchu Xie , linux-rdma@vger.kernel.org, selinux@vger.kernel.org, Youngjun Park , Chengming Zhou , Wei Xu , Miklos Szeredi , linux-sound@vger.kernel.org References: <20260917-b4-mmap-prepare-vma-flag-sanify-v3-0-4583d8a23bca@kernel.org> <20260917-b4-mmap-prepare-vma-flag-sanify-v3-10-4583d8a23bca@kernel.org> From: Lance Yang In-Reply-To: <20260917-b4-mmap-prepare-vma-flag-sanify-v3-10-4583d8a23bca@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026/9/18 00:22, Lorenzo Stoakes (ARM) wrote: [...] > +static int mon_bin_discontig_init(void *vm_private_data, void **private) > +{ > + struct mon_reader_bin *rp = vm_private_data; > + > + /* Dropped by mon_bin_vma_close() on unmap, including on error. */ > + __mon_bin_vma_open(rp); Em ... If Coda uses a usbmon container and the first page insertion fails (e.g. -ENOMEM when allocating a page table) after mon_bin_discontig_init(), where is mmap_active decremented? mmap_action_finish() returns the error when is_compat is true, and mmap_file() then replaces vm_ops with dummy ops. Am i missing something? > + return 0; > +} Cheers, Lance [...]