From: Johannes Berg <johannes@sipsolutions.net>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Chunfan Chen <jeffc@marvell.com>
Cc: Brian Norris <briannorris@chromium.org>,
Francesco Dolcini <francesco@dolcini.it>,
Kalle Valo <kvalo@kernel.org>,
Amitkumar Karwar <akarwar@marvell.com>,
Cathy Luo <cluo@marvell.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] wifi: mwifiex: Fix a loop in mwifiex_update_ampdu_rxwinsize()
Date: Thu, 08 Jan 2026 21:58:46 +0100 [thread overview]
Message-ID: <9085a572f5fee0a14059c023c3240aa4d96afc08.camel@sipsolutions.net> (raw)
In-Reply-To: <aWAM2MGUWRP0zWUd@stanley.mountain> (sfid-20260108_210112_409464_E43D6B91)
On Thu, 2026-01-08 at 23:00 +0300, Dan Carpenter wrote:
> The "i" iterator variable is used to count two different things but
nice catch
> unfortunately we can't store two different numbers in the same variable.
:-)
> This was found via static analysis so I'm not positive on the impact
> of this bug.
I think it basically means anything other than the first interface
(using adapter->priv[i] with i>0) will not be updated correctly for A-
MPDU buffer usage (?) if you use more than two interfaces. Given that
most people probably only use a single interface, I suppose the impact
would be rather low.
johannes
next prev parent reply other threads:[~2026-01-08 20:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 20:00 Dan Carpenter
2026-01-08 20:58 ` Johannes Berg [this message]
2026-01-12 8:02 ` Jeff Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9085a572f5fee0a14059c023c3240aa4d96afc08.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=akarwar@marvell.com \
--cc=briannorris@chromium.org \
--cc=cluo@marvell.com \
--cc=dan.carpenter@linaro.org \
--cc=francesco@dolcini.it \
--cc=jeffc@marvell.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®