From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B1EB1FFC59 for ; Tue, 7 Oct 2025 16:14:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759853650; cv=none; b=FGDhvkJOjof/gZ11uDbhiO9H384R/j0ad/+S8Y62gKOkNk5IGZnVr8/gL8yP9Uxjv+NXHh1iAf4NLksq43xB9f8+UD5hTWvKVokQNJZ1D7897yTQGSA4Cy9lVHErtofvvkRfSS70zGsgZS0PIztl/3FlgynXToDw96EinU6b3KI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759853650; c=relaxed/simple; bh=/yJjxE8w2IvYJlej72UGq78sGRcKTVS8ShsXF0wOTQY=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=fht/zaXnm9OdwAOhYCHdcx+u57nykcMI2CPUXddpwZ391PCy9QjMCYFVfvbUJKzRT5esnG4Eb094LdnsoOtaUdkGRAjlKLFj9LcasDggZ/8j/jK08lZa0QFPe4ahEtWidqrV83u12fsRAzLGd0wOIe4KBWz//0hkEQY5qskCnZs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=A1FSZerB; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="A1FSZerB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759853647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=12Che5t0HROHRRsC4sAiXZshTGRWxlbpXt7HNiDEfA4=; b=A1FSZerBssS8f1J1XBucnyIofyhQW3MCk9PclrA9vsOL0Z2vvd4hx7x8r7KH+oZUJEt/K5 kIL6FFtMOcZJ2vGwlSxFs8fqYOKo3oM1oKYwxQbtM0ZP+O9MoXvlQ6lYY+np+/5LhNR7nf ewFqaxgvZWX3pT9DjptTJxo9C0QIlnI= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-456-sqtDjA_uO6msX-gIOwALhg-1; Tue, 07 Oct 2025 12:14:06 -0400 X-MC-Unique: sqtDjA_uO6msX-gIOwALhg-1 X-Mimecast-MFC-AGG-ID: sqtDjA_uO6msX-gIOwALhg_1759853645 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-46e377d8c80so23633405e9.3 for ; Tue, 07 Oct 2025 09:14:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759853645; x=1760458445; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=12Che5t0HROHRRsC4sAiXZshTGRWxlbpXt7HNiDEfA4=; b=a9rwKR+E8qE+PWAYe+xhmxHYhdxw3IVIXQM6O6vICHUwl7eLO5OC7n+cet7474entf 5Wl4gFUKaDdILifqGIKK1R1Vua+vLB7fYJweKgozuzZRZ/j+HdHBPzA0pZBtGFlNxXPS x3PIdFJ34sps5mKGCht/FfQR3yNUqMmHMFTctd6GJ49PoJbLW5GijgkBRxCTqIFewj70 tpLgXdv/ypSXviFP+YSRW6vDu7YTaOH+USZTFJDzgjUmMi2Nh66NzFlVRoxX7P8uyA9A 7IEuCoZkl/eXrfOckpCtzwJ+loi/WMb4oRSf5pnet0KwAjJqKO/hBt0I/fDN2Gv1Arl7 CG7A== X-Forwarded-Encrypted: i=1; AJvYcCV9I142syStphZy/XgjPN1o0cXijIvonzqv99A9J7QOdJkrrUf+H7GQYT/V+srz2q9HvOLnYBj/5LiYJWU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6N+kO4bAtCUCOkT/9kK69ZXtfNFL4ygTZMdJuu1UcrAoWfskY gazQXSEC9pE30Qcbyl5hrjdoqojaDDv7dcarhQgtMpapjr3C4V52/8DnfSQ18ES/cFxphTMr3rd 4E6m9UrQWfP2j+d6gN/a+PTWwv5x1dLGZwV73JSWMQRVio2Y7av0Zx9HVVrvqcWn2eQ== X-Gm-Gg: ASbGncsz5qJ+Sb5H2o97TEGADnRbhbZ2zKKLqqXoQsqFajx8MS4o+BjsTRNgjn6Uu7M JQEnldBMMvkoYiFyLeIGbRnJekJEL22Etiisyn4ifz5VckTzvsRu58HXsh0CSWwDtl2LDaFrVje tfvUPi2kxHu60pUn7vrnesgXKingidHgZYXw4Yf1TNbZ1cTwhe+hz3IIyBNMJ4I3IW7bKLlOXfa T3T4VVobfVkzXAO1DthOlkAPF4717qI/2B1I8yWmy/YJet4JbYG8B+ePEZVamfDQ1iqkCay0HSy hoZHr8bE/ZhqjeiMJO46L4/ZWyzwAGlXGAGzT40VO5X91At3sddoJbgSf14iVN8IJk3WPYvaJ3U mJCoq9o0d X-Received: by 2002:a05:600c:4690:b0:46e:3dc2:ebac with SMTP id 5b1f17b1804b1-46fa9afbb62mr1174205e9.27.1759853645146; Tue, 07 Oct 2025 09:14:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEcLyTc+70gon3POBYkIbpKqytKcA7VAAQhCz1d2+32GdwV8lu9XuAX5w9JuHa2D4Ly8l9zpA== X-Received: by 2002:a05:600c:4690:b0:46e:3dc2:ebac with SMTP id 5b1f17b1804b1-46fa9afbb62mr1173975e9.27.1759853644735; Tue, 07 Oct 2025 09:14:04 -0700 (PDT) Received: from [192.168.3.141] (tmo-083-110.customers.d1-online.com. [80.187.83.110]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46fa3acf0c1sm18566445e9.9.2025.10.07.09.14.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Oct 2025 09:14:04 -0700 (PDT) Message-ID: <9089d994-262f-4941-8bed-f3c6ee05a769@redhat.com> Date: Tue, 7 Oct 2025 18:14:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] mm: Introduce vm_uffd_ops API To: "Liam R. Howlett" , Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Axel Rasmussen , Vlastimil Babka , James Houghton , Nikita Kalyazin , Lorenzo Stoakes , Ujwal Kundur , Mike Rapoport , Andrew Morton , Andrea Arcangeli , Michal Hocko , Muchun Song , Oscar Salvador , Hugh Dickins , Suren Baghdasaryan References: <43d78ba7-8829-4a19-bdf3-d192a62cdac4@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >> If so, I'd prefer that rather than introducing feature-backend flags, >> because I want to avoid introducing another different feature set to uffd. >> > > I was talking about uffd_features. I thought it was being renamed to > flags, not modes_supported. It was pretty late when I responded. > > FWIU, David was saying we don't need both of modes and ioctl listed in > the uffd_ops? Right, I would have abstracted the features to clean it up and avoid using VM_ flags in this interface. > > I was thinking that we could just put the features directly as function > pointers in the uffd_ops and check if they are NULL or not for > 'support'. > > ie: > > struct vm_uffd_ops hugetlb_uffd_ops = { > .missing = hugetlb_handle_userfault, > .write_protect = mwriteprotect_range, > .minor = hugetlb_handle_userfault_minor, > > .mfill_atomic = hugetlb_mfill_atomic_pte, > .mfill_atomic_continue = ... > .mfill_zeropage = ... > .mfill_poison = ... > .mfill_copy = NULL, /* For example */ > }; > > Then mfill_atomic_copy() becomes: > { > /* > * Maybe some setup, used for all mfill operations from > * mfill_atomic() > */ > > ... > > dst_vma = uffd_mfill_lock() > uffd_ops = vma_get_uffd_ops(vma); > if (!uffd_ops) > return false; > > if (!uffd_ops->mfill_copy) /* unlikely? */ > return false; > > return uffd_ops->mfill_copy(dst_vma,..); > } > > This way is_vm_hugetlb_page() never really needs to be used because the > function pointer already makes that distinction. > > Right now, we have checks for hugetlb through other functions that "pass > off to appropriate routine", and we end up translating the > ioctl_supports into the function call eventually, anyways. Right, it would be great to get rid of that. I recall I asked for such a cleanup in RFC (or was it v1). -- Cheers David / dhildenb