From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793115191; b=gbAS1Fhk0ksKffYD9kcspG5cTC4pVWmZDZPFg7daEXfnxSZiQ1XioC+GhXDqmT2QtvGF ROYDDsJUwcJkDmN8HFdB4zrWDGuV0mQNfUByJzcy7IMwu3z30CeQY6KokoQJqAG/tdtiQ AZuEtNUkHsCdodHrPqXD4odu2TtBV7XkHDiiBmqhmQaJQbL6OQYBsZIKR4A7pJOyar6/9 fiQUHSy49ZJTPMy10zIsRbKe8G43xhbTl4JOabZd3POLhmsRcqm+bO1xQYPrQil/cEvib EQo0pqPorEP05iMNEbn8c9FnmAFRV7HG6N63Jv+q17xYCI2Z6wvEX1LiqsRhRn8PAHA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793115191; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent:From: Subject:To:Cc:References:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=XOOh+ULPr07EH3JwMHJLcn39ZNkIL073krbF4dkQm4o=; b=Mjz4McVgqOgqGGbcMsUxv0XaGPxT0uNNI30WLr7gJu4TVfwcw1FwMCr24QgixR1SavWy 6yZq6x7ADv6op1Bic0AhjdhLBsSoimDwfV45F5a8ArNbYEMc6Jxw03S/BxjxUupfXit2W RHMpGr+azjXL9j2e0sbHr0hSchRTKAy9zJrK36A88fP5vXf/NMR9Tuf4q668Qd0frvNXA 6xRr5N9v91+y4hyfVnMwCcLGEUdJqUk+KA1JrPB2KbomOI4Xct4q/VEtyOencSniso1YR XwLygeyl7oX1V3DvhuwNT1ajuXjeGMHYglGvp1FTqygHc0n4DB1ZkpUd/+3e08LI7/w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=GjR1n3En; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC91F606A31E; Tue, 27 Oct 2026 15:33:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=GjR1n3En Received: by smtp.kernel.org (Postfix) with ESMTPSA id 462F41F01828; Tue, 27 Oct 2026 15:33:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793115190; bh=XOOh+ULPr07EH3JwMHJLcn39ZNkIL073krbF4dkQm4o=; h=Date:From:Subject:To:Cc:References:In-Reply-To; b=GjR1n3EnMf4ak9lIFuA4X13+QrowxkshNVZpHhBG+FgMOI/FthJAxNAJiHZUIy5gj 4XHjoNEZ+wxFe7XfWpYpRnP4ixWsGbATxF/3YQJ9Ak1pL5dehCuVnRBzIDoloTfb0v 41V9+kbKYU7icifv508cW7HoH1e4+F0cmE8Egyu+uc8Dd6XAnsT1fE61K8+MIeLW34 nwx6DZ5idef7BIL6K1OcNUH7xRI5j8MGxNpNGMZPii298rgdBRXoXsGLnVbt/s26XO SUWwK2aW3mR180DlvdsYAMNy0ZaO7DEYJJlC4Be7gKatpbvAg6r2kmpdBxgu459rPN PdaAzVeFNCMEw== Message-ID: <908cb70d-bfe8-4d01-b64e-44ffcfe259bd@kernel.org> Date: Tue, 27 Oct 2026 16:33:07 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Krzysztof Kozlowski Subject: Re: [PATCH] platform/x86: acer-wmi: fix UAF after accelerometer registration failure To: Guangshuo Li , "Lee, Chun-Yi" , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Matthew Garrett , Marek Vasut , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org References: <20261026111103.4158855-1-lgs201920130244@gmail.com> Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <20261026111103.4158855-1-lgs201920130244@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 26/10/2026 12:11, Guangshuo Li wrote: > When input_register_device() fails in acer_wmi_accel_setup(), the error > path frees acer_wmi_accel_dev but leaves the global pointer non-NULL. > > Since acer_wmi_init() ignores the accelerometer setup failure and > continues initialization, a later driver removal or initialization > failure can call input_unregister_device() on the dangling pointer, > resulting in a use-after-free. > > Set acer_wmi_accel_dev to NULL after freeing it so that the cleanup > paths do not attempt to unregister the already-freed input device. > > This issue was found by our static analysis tool under development. > > Fixes: 1eb3fe1d3b6b ("ACER: Add support for accelerometer sensor") > Cc: stable@vger.kernel.org > Signed-off-by: Guangshuo Li > --- So you just keep ignoring and ignoring our feedback. It's just bot, so little point to discuss with bot. Best regards, Krzysztof