From: Leon Hwang <leon.hwang@linux.dev>
To: bot+bpf-ci@kernel.org, tweek@google.com, qmo@kernel.org,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
eddyz87@gmail.com, memxor@gmail.com, shuah@kernel.org,
kpsingh@kernel.org, emil@etsalapatis.com
Cc: martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev,
jolsa@kernel.org, ihor.solodrai@linux.dev, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
martin.lau@kernel.org, mason@kernel.org
Subject: Re: [PATCH bpf-next v3 3/3] selftests/bpf: Add iter subtest using lskel in global_data_init
Date: Fri, 18 Sep 2026 21:36:37 +0800 [thread overview]
Message-ID: <908dd7ec-1d03-4d2f-814b-9e1c67f337b2@linux.dev> (raw)
In-Reply-To: <b1a854da66d611f079d8ff186b9bf73845ee18b73fac2481ef468a86fc777990@mail.kernel.org>
On 2026/9/18 13:05, bot+bpf-ci@kernel.org wrote:
>> In test_global_percpu_data.c, dump_percpu_data is defined after two
>> non-autoload SEC("?kprobe") programs (verifier_strncmp and
>> verifier_snprintf). If bpftool does not skip non-autoload programs when
>> generating light skeletons, dump_percpu_data.prog_fd is left invalid or
>> unpopulated.
>>
>> Factor out a test_global_percpu_data_iter_fd() helper that operates
>> directly on prog/map file descriptors, and add an iter_lskel subtest to
>> verify that dump_percpu_data is properly loaded and executes correctly
>> when using the light skeleton.
>>
>> Fixes: 4c9241bd731a ("selftests/bpf: Add tests to verify global percpu data")
>> Fixes: 1ed2294b31fc ("selftests/bpf: Test verifier log for global percpu data")
>> Signed-off-by: Thiébaud Weksteen <tweek@google.com>
>
> Are the Fixes: tags appropriate for this commit? This patch only adds new
> test coverage (a new iter_lskel subtest) and refactors existing test code
> (factoring out test_global_percpu_data_iter_fd() with no behavioral change
> to the existing "iter" subtest). It doesn't fix anything that
> 4c9241bd731a or 1ed2294b31fc got wrong.
>
> The bug being tested is in bpftool, introduced by d510296d331a
> ("bpftool: Use syscall/loader program in "prog load" and "gen skeleton"
> command.") and actually fixed by the two preceding patches in this series
> (202ee90dee368 and 843762e6f4665), both of which already carry the correct
> Fixes: d510296d331a tag.
Agreed.
The Fixes: tags of this patch can be dropped.
Others lgtm:
Acked-by: Leon Hwang <leon.hwang@linux.dev>
>
> There's also a backport concern. The Fixes: tags make this patch a
> candidate for AUTOSEL/stable pickup independently of 202ee90dee368 and
> 843762e6f4665. Since this is the last patch of the series, backporting it
> alone would land the new iter_lskel subtest in a tree with the unfixed
> bpftool, where skel->progs.dump_percpu_data.prog_fd is left at 0 and
> bpf_link_create(0, 0, BPF_TRACE_ITER, &opts) fails. The subtest would fail
> by construction.
>
> Should the Fixes: tags be removed, or if they're intended to be kept,
> should the dependency on the two bpftool patches be stated via
> Cc: <stable@vger.kernel.org> prerequisite lines?
>
>
> ---
> AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
> See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
>
> CI run summary: https://github.com/kernel-patches/bpf/actions/runs/35306404663
next prev parent reply other threads:[~2026-09-18 13:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 4:09 [PATCH bpf-next v3 1/3] bpftool: Skip non-autoload programs when generating light skeletons Thiébaud Weksteen
2026-09-18 4:09 ` [PATCH bpf-next v3 2/3] bpftool: Compute light skeleton ctx.sz without relying on links Thiébaud Weksteen
2026-09-18 8:42 ` Quentin Monnet
2026-09-18 4:09 ` [PATCH bpf-next v3 3/3] selftests/bpf: Add iter subtest using lskel in global_data_init Thiébaud Weksteen
2026-09-18 5:05 ` bot+bpf-ci
2026-09-18 13:36 ` Leon Hwang [this message]
2026-09-18 8:43 ` [PATCH bpf-next v3 1/3] bpftool: Skip non-autoload programs when generating light skeletons Quentin Monnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=908dd7ec-1d03-4d2f-814b-9e1c67f337b2@linux.dev \
--to=leon.hwang@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bot+bpf-ci@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=ihor.solodrai@linux.dev \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=mason@kernel.org \
--cc=memxor@gmail.com \
--cc=qmo@kernel.org \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=tweek@google.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®