From: Tariq Toukan <ttoukan.linux@gmail.com>
To: Wentao Liang <vulab@iscas.ac.cn>,
saeedm@nvidia.com, leon@kernel.org, tariqt@nvidia.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net v2] net/mlx5: handle errors in mlx5_chains_create_table()
Date: Thu, 6 Mar 2025 11:19:14 +0200 [thread overview]
Message-ID: <90902747-b976-4653-8d9d-0371f168bdbb@gmail.com> (raw)
In-Reply-To: <20250306085402.2503-1-vulab@iscas.ac.cn>
On 06/03/2025 10:54, Wentao Liang wrote:
> In mlx5_chains_create_table(), the return value of mlx5_get_fdb_sub_ns()
> and mlx5_get_flow_namespace() must be checked to prevent NULL pointer
> dereferences. If either function fails, the function should log error
> message with mlx5_core_warn() and return error pointer.
>
> [v1]->[v2]:
> Add Fixes tag.
> Target patch to net.
> Change return value from NULL to ERR_PTR(-EOPNOTSUPP)
>
Change history should not be part of the commit message.
Please move it to under the "---" marker below.
> Fixes: ae430332557a ("net/mlx5: Refactor multi chains and prios support")
Same problem existed also in mlx5_esw_chains_create_fdb_table(), before
the refactoring.
Please refer to the original patch where issue was introduced, seems to
be commit 39ac237ce009 ("net/mlx5: E-Switch, Refactor chains and
priorities").
prev parent reply other threads:[~2025-03-06 9:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 8:54 Wentao Liang
2025-03-06 9:19 ` Tariq Toukan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90902747-b976-4653-8d9d-0371f168bdbb@gmail.com \
--to=ttoukan.linux@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=stable@vger.kernel.org \
--cc=tariqt@nvidia.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®