From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99EA71B86FA for ; Fri, 16 Aug 2024 13:09:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723813752; cv=none; b=Cnz8Dov34Yg27mVzIaaLwliqTfIpRuvCX1h3dD3+g6DYCnYBgLC14/Es2oAt1wVeCLbYUHYb08eXtpsMA1pksDe4zhkJBFcm+trlN7z4on1FC060EBA9YP7K8pyTd8gr7BNrG6sTI9Il1WhtxXzk/p+eRH8C2Abo7Tjxl4TmbAo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723813752; c=relaxed/simple; bh=hV61UEsZvxQXAH//23EBTg5Dfv0U9kPjQojStjFfjbA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JwDtrYh1vDKY7ZzqcVN21elSch6t7TLHoj2550ZwP9oOemzRvns+1Lm2ssU8sbneRSpGh1yUCirQqSDYIKnxLq+q/bsV+1Ddk6OGnc8AvijmuA9oXGt7pE14T8uFfcnUl0TKdar/0UR5ksJRIe/cinexZ7+elB2+PGwEx/PVyfs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=m0CsYM8n; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="m0CsYM8n" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-42803bbf842so19960145e9.1 for ; Fri, 16 Aug 2024 06:09:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723813749; x=1724418549; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=I57ivJzE0S7Jyj+4EZvgDuynmnlEVJTzFHiR3Sj8E/Y=; b=m0CsYM8n+xy8sQdVxy0PxK0vVJTXaBZqOPx+SCC1vvNAeI0fKjsh4hLgO6P+THne42 iKQQNNZWY/7Z+tvYnR/y0LQw++pxObbcXgHQGN8ILjtEFc6PyahUudcGEglYSUJyyjv6 zRyXLBCAQXdfSZJ8pMUcsZFKOy9cQD1W6tRrxSncDnV3vFJtcEubdi6PizI+53JpwdJK i2fw6xjPsKpP17NVxGU9ve0kyONZt8HDItUDjLqDb2CziEST9EsuqNVqou8vC4ozc1vu vRxd9XxzSMVDWk1epoyF7DL6j8dvNUqxINe5NDAsKnH8gQlQRWIKCx14pClnZCyoJtJQ 1AGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723813749; x=1724418549; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I57ivJzE0S7Jyj+4EZvgDuynmnlEVJTzFHiR3Sj8E/Y=; b=adYvDRqSQNll9wH0vYrbI/81xGDdSMEabI5D2nB+2AheeDtbs5T5aj67+SOlyvpNnG shzF3Rw5uxxkG/JzYqB6RbSzii5Wckl+rpUXuz6jwaPJO2y4ePkfCWajIYY+miTDwxvl h51I704S44klrvCLx+/ZKE3zfBlEYZniYK3B60G4r/V+fH/5cgB/b44WZ+QOJyXyx3qH FUqH6TzTf6MPJR2QgEzpVv+E+4Bcu3YXpUgOjdPyY0cs92n/aKaPfbRPMdrrPKrA3BdH AHR/TqYxy/xfwU1VOfGlsYwDNHM+6Mu92MiVRO5MKuHa5tftxdohhGv2aRUKJQdZNUGr gZiQ== X-Forwarded-Encrypted: i=1; AJvYcCU//BcTLnSJ1xDx9GlNU5kc56xoT61+5BnQoUF9aCxhDKu8WfwM9z9AxJ0axcBebOWrXO2EwusNMkgbAJRC8BT5Ckj8ZPbds2xONqRY X-Gm-Message-State: AOJu0YzgZ5KItvkGl5CfYXf9gi27D5aAYGxT+K+YyprzYFl2MJVRyFkJ NxxzlyQxhr7S1Nq3uK3R+q88Y4N6r0GBVCJ4Lz20nbdhaXQaEsxaaCehGcMksvg= X-Google-Smtp-Source: AGHT+IGnx6kas1tzOJHAhP+U85MHgXfoWOwHa4tNkKg9SyOtPuPTLGnQgFkIbtCooFiXuJnYxwkOOg== X-Received: by 2002:a05:600c:3ca4:b0:429:c674:d9de with SMTP id 5b1f17b1804b1-429ed78411cmr22492805e9.2.1723813748808; Fri, 16 Aug 2024 06:09:08 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429ed648e76sm22683515e9.2.2024.08.16.06.09.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2024 06:09:07 -0700 (PDT) Date: Fri, 16 Aug 2024 16:09:03 +0300 From: Dan Carpenter To: Changhuang Liang Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , Hans Verkuil , Laurent Pinchart , Jack Zhu , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [v2] staging: media: starfive: Add the dynamic resolution support Message-ID: <90939451-4e26-4aec-bf69-d078d88fb5c2@stanley.mountain> References: <20240816125132.514488-1-changhuang.liang@starfivetech.com> <0680445d-1108-4400-b150-4804da63ddba@stanley.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0680445d-1108-4400-b150-4804da63ddba@stanley.mountain> On Fri, Aug 16, 2024 at 04:04:38PM +0300, Dan Carpenter wrote: > On Fri, Aug 16, 2024 at 05:51:32AM -0700, Changhuang Liang wrote: > > Add the dynamic resolution support for video "capture_raw" device. > > > > What does this change look like from a use perspective if a user is reading the > git log? > > > Fixes: e080f339c80a ("media: staging: media: starfive: camss: Add capture driver") > > > > This looks like a new feature and not a bugfix. Please describe the bug more > clearly if it's really a bugfix. > Actually the first version of the commit had a good description. Just go back to that. > Add multiple resolution support for video "capture_raw" device. Otherwise > it will capture the wrong image data if the width is not 1920. Btw: 1) Don't put a blank line after the Fixes tag. 2) Put a note under the --- cut off line that says what changed. https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ Please send v3. regards, dan carpenter