From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77400C636D6 for ; Thu, 16 Feb 2023 10:58:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230345AbjBPK6D (ORCPT ); Thu, 16 Feb 2023 05:58:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230323AbjBPK55 (ORCPT ); Thu, 16 Feb 2023 05:57:57 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3585956485 for ; Thu, 16 Feb 2023 02:56:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676544979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uTgMQWhXxbdOB1s+iJ3y+3uVjK3VfEIrdExBYMmTzrk=; b=cgTA8yeBuLVrFQVUmlI+zpc+i1N1YJx/XupkVor1p/PDzbtkrCJaRFBHH5jm5w/+5d51X8 Bn2kkqyd8oZGSVLCtonsceAAevnNU5H26m5PiLePfMmuSxCWYBhVrrk1glN+9V+nsIJyVa 6qv75jzAEiTEOdI0A+bzz0LgINFEB2s= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-353-r9p6845-ODSq9UybbBZQVg-1; Thu, 16 Feb 2023 05:56:18 -0500 X-MC-Unique: r9p6845-ODSq9UybbBZQVg-1 Received: by mail-wr1-f72.google.com with SMTP id k17-20020adfe8d1000000b002c55ef1ec94so194314wrn.0 for ; Thu, 16 Feb 2023 02:56:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uTgMQWhXxbdOB1s+iJ3y+3uVjK3VfEIrdExBYMmTzrk=; b=Y1UxWZc15PQCXsYimcxF2sMZ4vW2vlJF2YJyd/3WRv2pku7ht+Bgtg38kI2lq/BZ96 igh4E9k0fMNH04yJnS7UUgbN9JMOG55gHO6g+rLS5615nA5LK+PghdB9Pj6A2XwP6wJp aCBa7Ly0ic+4PPOJQyPw0A3g5uOIe2OKe53NB9iLF1w3DJUr0pnnFGeseZMJt66/ocqU g22BEVKyTAZci4Q3TB/ohPQk2x6pj05BRuyma+Y65W48gE1y0aRHwW7rcMGa2h/q7T4y lFSRDb2T9VTtp8Kykh0WBXymzTv6AGgyXt9z0C7XawmTVAGpmnHEgO1LV0yY9uD+InSE Fbzw== X-Gm-Message-State: AO0yUKWVyeIdXFxeQ2Zd1kAa11lS8yaYlANorf2CzY3dw/Tuw/4qnJtj F96qtfHcU8n/RDnmpgTsL/fxLHzXUPmQASB03dD6eSChQFsjdlORnMVw+memC167Bzi24yOCp1g BqR7RWAxIeerqc+8e5fH12ccf X-Received: by 2002:adf:e701:0:b0:2c5:5331:5516 with SMTP id c1-20020adfe701000000b002c553315516mr4351118wrm.51.1676544976935; Thu, 16 Feb 2023 02:56:16 -0800 (PST) X-Google-Smtp-Source: AK7set9ObTYOMWdJTcJUhFYm6zKW9Smmq8ZljjToRyJseQklHttx5j+GTfa92sWHSmEG8i4fOJ6xDQ== X-Received: by 2002:adf:e701:0:b0:2c5:5331:5516 with SMTP id c1-20020adfe701000000b002c553315516mr4351100wrm.51.1676544976599; Thu, 16 Feb 2023 02:56:16 -0800 (PST) Received: from ?IPV6:2003:cb:c708:bc00:2acb:9e46:1412:686a? (p200300cbc708bc002acb9e461412686a.dip0.t-ipconnect.de. [2003:cb:c708:bc00:2acb:9e46:1412:686a]) by smtp.gmail.com with ESMTPSA id h16-20020adffa90000000b002c5621263e3sm1221457wrr.19.2023.02.16.02.56.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 02:56:16 -0800 (PST) Message-ID: <909d3cd5-eb64-6901-4e12-00ac5c69f4aa@redhat.com> Date: Thu, 16 Feb 2023 11:56:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 2/2] Revert "splice: Do splice read from a buffered file without using ITER_PIPE" Content-Language: en-US To: Konrad Dybcio , David Howells Cc: Alexander Viro , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , "Matthew Wilcox (Oracle)" , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mm@kvack.org References: <20230215-topic-next-20230214-revert-v1-2-c58cd87b9086@linaro.org> <20230215-topic-next-20230214-revert-v1-0-c58cd87b9086@linaro.org> <3055589.1676466118@warthog.procyon.org.uk> <71078188-1443-d84e-658c-967991f3b590@linaro.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <71078188-1443-d84e-658c-967991f3b590@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16.02.23 10:10, Konrad Dybcio wrote: > > > On 15.02.2023 14:01, David Howells wrote: >> Konrad Dybcio wrote: >> >>> next-20230213 introduced commit d9722a475711 ("splice: Do splice read from >>> a buffered file without using ITER_PIPE") which broke booting on any >>> Qualcomm ARM64 device I grabbed, dereferencing a null pointer in >>> generic_filesplice_read+0xf8/x598. Revert it to make the devices >>> bootable again. >>> >>> This reverts commit d9722a47571104f7fa1eeb5ec59044d3607c6070. >>> Signed-off-by: Konrad Dybcio >> >> Commit d9722a47571104f7fa1eeb5ec59044d3607c6070 was part of v13 of my >> patches. This got replaced yesterday by a newer version which may or may not >> have made it into linux-next. >> >> This is probably a known bug fixed in the v14 by making shmem have its own >> splice-read function. >> >> Can you try this? >> >> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=iov-extract > next-20230216 boots fine again, thanks! > >> >> (Also, can you include me in the cc list as I'm the author of the patch you >> reverted?) > Ugh.. I thought b4 would have done that for me.. weird.. Right, and usually it's nicer to comment on the problematic patches, asking for a fix or a revert, instead of sending reverts. My 2 cents. -- Thanks, David / dhildenb