From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B71B3C00A8F for ; Tue, 24 Oct 2023 02:00:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231864AbjJXCA0 (ORCPT ); Mon, 23 Oct 2023 22:00:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231854AbjJXCAY (ORCPT ); Mon, 23 Oct 2023 22:00:24 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BA6C10C3 for ; Mon, 23 Oct 2023 19:00:22 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 377DCC433C8; Tue, 24 Oct 2023 02:00:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698112822; bh=5Sn3H4oSN3dJtZjA+ZBhX1Pu9c0nxls8h7MoaYAi7n0=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=QVAPh1uPdXfvl0LfK1KAM8xDPpdsB0lWPL47UpoeDyZqaQFMhkYzl8gzGx0GCHfqf gQbGpqiwZfqFXe8rEv/3HJgd9nfgOh1rHoBFIkRAGM6Hq7OWOIhWN/AIztHfJbzkfG jIbQtPU4rHmuwN5082Cys8ml8/FL0ypY7GgbSCpiwA52s+N69eeNjSevvwShE8mZt4 1J0vzY46xCWJFsVlKzXZpOuVra8oSuLZDGjhF/jW2omNlpIzmbtWo6Oj4OqVuUEW6Z xwhgWCrAW2f7OjdFsZ5SontrM8/djBmrCuWhvgnj80tD80TPXcLtrMk+6Ham9U1Vwi 8PRZ/QJ/Z2CSg== Message-ID: <909e5d44d6cd79924d6e62d1b649646f.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230922025216.3604978-1-make_ruc2021@163.com> References: <20230922025216.3604978-1-make_ruc2021@163.com> Subject: Re: [PATCH] spmi: hisi-spmi-controller: fix potential memory leak in spmi_controller_probe() From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, Ma Ke To: Ma Ke , mchehab+huawei@kernel.org Date: Mon, 23 Oct 2023 19:00:20 -0700 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Ma Ke (2023-09-21 19:52:16) > spmi_controller_alloc() allocates a memory space for ctrl. When some > errors occur, ctrl should be handled by spmi_controller_put() and set > spmi_controller->controller =3D NULL because spmi_controller->controller > has a dangling pointer to the freed memory. When the failure happens, > the function returns without calling spmi_controller_put() and setting > spmi_controller->controller =3D NULL, which will lead to a memory leak. >=20 > When the failure happens, we can fix it by calling spmi_controller_put() > and setting spmi_controller->controller =3D NULL in all of the places > where we call spmi_controller_put(). >=20 > Signed-off-by: Ma Ke > --- > drivers/spmi/hisi-spmi-controller.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi= -controller.c > index 9cbd473487cb..5b3cfa7f5056 100644 > --- a/drivers/spmi/hisi-spmi-controller.c > +++ b/drivers/spmi/hisi-spmi-controller.c > @@ -321,6 +321,7 @@ static int spmi_controller_probe(struct platform_devi= ce *pdev) > =20 > err_put_controller: > spmi_controller_put(ctrl); > + spmi_controller->controller =3D NULL; The controller will most likely be freed after the put call one line above so this will oops. No thanks.