mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Pőcze Barnabás" <pobrn@protonmail.com>
To: Armin Wolf <W_Armin@gmx.de>,
	linux-leds@vger.kernel.org,
	Werner Sembach <wse@tuxedocomputers.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: Maximum values for multi_intensity sysfs attribute
Date: Wed, 04 Mar 2026 11:45:27 +0000	[thread overview]
Message-ID: <90a08353-429c-4603-bc6f-536a789fe5fa@protonmail.com> (raw)
In-Reply-To: <2d91a44e-fce2-42dc-b529-133ab4a191f0@gmx.de>

Hi

2026. 02. 14. 20:15 keltezéssel, Armin Wolf írta:
> Hello,
> 
> i am currently adding support for RGB keyboard backlight control to the uniwill-laptop
> driver, and want to use the multicolor LED class for that. However the hardware interface
> is a bit exotic:
> 
> - 5 global brightness levels
> - 50 intensity levels for each R/G/B channel
> 
> I am now asking myself how this should be mapped onto the multi_intensity sysfs attribute.
> Should i set max_brightness to 5 and reject intensity values larger that 50? Or should
> i set max_brightness to 50 and interpolate? What is the input range of intensity values?

Is that the same interface implemented by https://github.com/pobrn/hid-ite8291r3
(and https://github.com/pobrn/ite8291r3-ctl)?

In any case it's probably not too different. Unfortunately I don't recall ever finding a
satisfying way to integrate it with the multi-color led things. The best approach I could
find: brightness as [0; 50], while multi_intesity is [0; 255], essentially specifying the
color of each channel (simply clamping, without `led_mc_calc_color_components()`). Note that
the above kernel driver does not implement per-key color setting, so this approach seemed
most sensible.


Barnabás Pőcze

> 
> Thanks,
> Armin Wolf
> 
> 



  parent reply	other threads:[~2026-03-04 11:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-14 19:15 Armin Wolf
2026-03-03 20:11 ` Armin Wolf
2026-03-03 20:35   ` Werner Sembach
2026-03-03 20:43     ` Werner Sembach
2026-03-04 11:45 ` Pőcze Barnabás [this message]
2026-03-04 11:58   ` Werner Sembach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90a08353-429c-4603-bc6f-536a789fe5fa@protonmail.com \
    --to=pobrn@protonmail.com \
    --cc=W_Armin@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=wse@tuxedocomputers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®