From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35470C433E0 for ; Fri, 29 Jan 2021 07:18:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D737864DFD for ; Fri, 29 Jan 2021 07:18:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232001AbhA2HSL (ORCPT ); Fri, 29 Jan 2021 02:18:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229819AbhA2HSB (ORCPT ); Fri, 29 Jan 2021 02:18:01 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4014C061574 for ; Thu, 28 Jan 2021 23:17:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=nAnTETMHcfweHl7T4+bq1hybnR4BA4pB1t2JYrikVAk=; b=KS95H98dWPeHViBs1Z6WwzGCFO CTZBeyqLXhKw1cPWie38D9LoqDVH1DFrQ22pXi1yOwt5U3R8Qrgy7lIX+AjJ93EzMjFiZxsdH9Cgx rfP/mxCOo+v0Uq5lSknEiLvmdDtql2WKeEucP/PPodOXQKXxGIwAW2NXzjmVnSrFFvnqA3gwQ7fmz gG0AUjM9hVSsgPRB2FuSWekhC886QUDJyw7pJvJmD9neAg/IkCWox3q5jbx6mOQr5L8JXFYfGAycJ ru70Yq8twQsxnTiiZWppvpfnVQAKqYJer+htJiWBBZYsyHglvJ6UxZ0msCtKXnWV6Y6HKsFzr+K6f VGp/Q5TQ==; Received: from [2601:1c0:6280:3f0::7650] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5O1s-00014O-Fd; Fri, 29 Jan 2021 07:17:16 +0000 Subject: Re: [PATCH] misc: bcm-vk: only support ttyVK if CONFIG_TTY is set To: Scott Branden , Arnd Bergmann , Greg Kroah-Hartman Cc: Kees Cook , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Olof Johansson , Desmond Yan References: <20210129060443.14864-1-scott.branden@broadcom.com> From: Randy Dunlap Message-ID: <90a4fb55-3ecc-cdcd-2884-1f65062d139c@infradead.org> Date: Thu, 28 Jan 2021 23:17:09 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20210129060443.14864-1-scott.branden@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/28/21 10:04 PM, Scott Branden wrote: > Correct compile issue if CONFIG_TTY is not set by > only adding ttyVK devices if CONFIG_TTY is set. > > Reported-by: Randy Dunlap > Signed-off-by: Scott Branden > --- > drivers/misc/bcm-vk/Makefile | 4 ++-- > drivers/misc/bcm-vk/bcm_vk_dev.c | 13 +++++++++++++ > 2 files changed, 15 insertions(+), 2 deletions(-) Acked-by: Randy Dunlap # build-tested Thanks. -- ~Randy