From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF717C010A3 for ; Tue, 5 Nov 2019 11:27:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2C7721929 for ; Tue, 5 Nov 2019 11:27:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="jsoCfvmi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730845AbfKEL1P (ORCPT ); Tue, 5 Nov 2019 06:27:15 -0500 Received: from lelv0142.ext.ti.com ([198.47.23.249]:54914 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730624AbfKEL1P (ORCPT ); Tue, 5 Nov 2019 06:27:15 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id xA5BR7lA061552; Tue, 5 Nov 2019 05:27:07 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1572953227; bh=gVRqoU4DY2RZFqcIAa7kQA6NvFoO5m5yaA/iykLARlc=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=jsoCfvmiDdSviAW4wklT+kWNDAUo0ChRzqh3HjEV3DxA+V9+IS0Xjq8YohXSePRX6 u1FN588Eo6xgEB/i4C9y7vq7kdzRysdPykBFgoETWFhjt958bqsGyGIbCMf489G+y0 sJWtLPiv+wPsMjYKF9iQjTjqw+ArX2IGVuWSsGMc= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id xA5BR7YV000512; Tue, 5 Nov 2019 05:27:07 -0600 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 5 Nov 2019 05:26:52 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 5 Nov 2019 05:26:52 -0600 Received: from [10.250.98.116] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id xA5BR4BI033326; Tue, 5 Nov 2019 05:27:05 -0600 Subject: Re: [PATCH 28/62] gpio: gpio-omap: Use new GPIO_LINE_DIRECTION To: Matti Vaittinen , CC: Santosh Shilimkar , Kevin Hilman , Linus Walleij , Bartosz Golaszewski , , , References: From: Grygorii Strashko Message-ID: <90a8b355-8092-38c8-2f7d-a65f0e1ce746@ti.com> Date: Tue, 5 Nov 2019 13:27:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11/2019 12:25, Matti Vaittinen wrote: > It's hard for occasional GPIO code reader/writer to know if values 0/1 > equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and > GPIO_LINE_DIRECTION_OUT to help them out. > > Signed-off-by: Matti Vaittinen > --- > drivers/gpio/gpio-omap.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c > index d0f27084a942..3bd8adaeed9e 100644 > --- a/drivers/gpio/gpio-omap.c > +++ b/drivers/gpio/gpio-omap.c > @@ -805,8 +805,10 @@ static int omap_gpio_get_direction(struct gpio_chip *chip, unsigned offset) > { > struct gpio_bank *bank = gpiochip_get_data(chip); > > - return !!(readl_relaxed(bank->base + bank->regs->direction) & > - BIT(offset)); > + if (readl_relaxed(bank->base + bank->regs->direction) & BIT(offset)) > + return GPIO_LINE_DIRECTION_IN; > + > + return GPIO_LINE_DIRECTION_OUT; > } > > static int omap_gpio_input(struct gpio_chip *chip, unsigned offset) > Reviewed-by: Grygorii Strashko -- Best regards, grygorii