From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25C20C54FB9 for ; Tue, 21 Nov 2023 09:07:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230326AbjKUJHC (ORCPT ); Tue, 21 Nov 2023 04:07:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbjKUJHB (ORCPT ); Tue, 21 Nov 2023 04:07:01 -0500 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C70C97; Tue, 21 Nov 2023 01:06:57 -0800 (PST) Received: from [2a02:8108:8980:2478:8cde:aa2c:f324:937e]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1r5Mia-0005fz-Ne; Tue, 21 Nov 2023 10:06:52 +0100 Message-ID: <90abbd7a-e3e3-42c9-9be9-28e475f0fc9a@leemhuis.info> Date: Tue, 21 Nov 2023 10:06:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: spi: imx: Increase imx51 ecspi burst length fails on imx6dl and imx8mm Content-Language: en-US, de-DE To: Francesco Dolcini , Stefan Moring Cc: linux@bigler.io, Linux regressions mailing list , Mark Brown , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org References: <2fcdd99eee9ee4f5d34fa1abab2f51bb@mail.infomaniak.com> <86566391db9c5044f1a082bc8ec697a2@mail.infomaniak.com> <6322fd4c1967a518310140c35ab34f65@mail.infomaniak.com> From: Thorsten Leemhuis In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1700557617;7b5ce5aa; X-HE-SMSGID: 1r5Mia-0005fz-Ne Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20.11.23 18:48, Francesco Dolcini wrote: > On Mon, Nov 20, 2023 at 04:30:15PM +0100, Stefan Moring wrote: >> Can you verify the values used for the transfer,  spi_imx->count and spi_imx-> >> bits_per_word inside the mx51_ecpsi_prepare_transfer() method? Those are the >> only two things that changed in the commits. Maybe compare them to the working >> version? > > I would suggest to bisect the issue to the actual commit that > introduced the regression, I do not think this was done yet. I think it was. To quote https://lore.kernel.org/all/8a415902c751cdbb4b20ce76569216ed@mail.infomaniak.com/ "'" After upgrade from kernel 6.5.11 to 6.6.1 the spi-devices on my hw colibri-imx6dl and verdin-imx8mm are not working anymore (TPM2 and SPI-SRAM). Analyzing the problem showed that the 2 commits introduced the problem: spi: Increase imx51 ecspi burst length based on transfer length 15a6af94a2779d5dfb42ee4bfac858ea8e964a3f spi: imx: Take in account bits per word instead of assuming 8-bits 5f66db08cbd3ca471c66bacb0282902c79db9274 Reverting the commits solved the problem. "'" Or am I missing something here? Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr If I did something stupid, please tell me, as explained on that page.