From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 658DBC04A94 for ; Wed, 16 Aug 2023 06:15:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242070AbjHPGPS (ORCPT ); Wed, 16 Aug 2023 02:15:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242118AbjHPGPJ (ORCPT ); Wed, 16 Aug 2023 02:15:09 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 720792684 for ; Tue, 15 Aug 2023 23:15:05 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-3fe2fb9b4d7so55868395e9.1 for ; Tue, 15 Aug 2023 23:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692166504; x=1692771304; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VTUQHvk6nMPNqeWY6wjgN795gkMb2j9jEUIFdAG4LqY=; b=xO7Z5WcoLupf7WKGjXnm0+2JGKVIp+cZFnQW8qQQUX+vL1sMACIBIoFNaOSViPQ14a UHJWJ2K87aax2Dd0w9aiBwD8VUPcehzUU/C1kdQpQSDDsiBJNmOQiSmx/CYU+BkizcTX mscN1bNSQA1cC+Hvmg9TNKYwS6ExADhhO5BWlp4JNCfIuF55JUL3hQG1nyoLcAJlBfM2 WYvXyXs1HgxJMlF15emnRH/wHuQ7vwi7UGdR44Dr76G5QR6uB0rf7ahScIKYQxrNXbjR kWBwlJocmwayctKWjiVkfWbA5zs1pIirENmfQGmsI6fVzE4i8pa2TE/V1KuSTWiD/hkO aFTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692166504; x=1692771304; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VTUQHvk6nMPNqeWY6wjgN795gkMb2j9jEUIFdAG4LqY=; b=V3Vg1tAbDMfhcI2H+JAE+8wgXDhrFuUHCzM9vv/aCHHc1gjPCUi0azvZXO3tw9GahW PCYO9x7jRkdoEzbw2rZPpf1osnUKNb1ur5bp4Vmj3/pwBmBtKp3RPLc3Rsj4vfa4D8vY mDzL39tRyqH54rhjZWoCV8dpG4kffCpiLdnVxPdrWHp/gfHBJYeH/uT3Xm4KhEyo+Bmk azS2TNkU8NmaRL5uFR52kV2YscaxTDxcEon9j7i3N9spwaAP2SPwmG15YQR7Kl3sBFVs /sEFxq2smZUz4aQo4Ju2v8D2bV+6tIh95SjBzNmS03umrlWhZR+HaQhSkEIzqX2IcI1q A6Xw== X-Gm-Message-State: AOJu0Yyu4jBpbGo2yOf3KhV1HlrGhlPPvuZiUdpHdtuUuMO6ugH8I8qQ 6vn/qye3TNyTDuJz+NU8BjitRA== X-Google-Smtp-Source: AGHT+IExivCJdkDf6HyiYHESX10/DHxdo5RQNph3ghItuTm+BBL36Ju2Zk/LPgvSP3sBJ03330hYSw== X-Received: by 2002:adf:fc8b:0:b0:317:5d60:2fea with SMTP id g11-20020adffc8b000000b003175d602feamr784010wrr.52.1692166503982; Tue, 15 Aug 2023 23:15:03 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id o10-20020a5d684a000000b0031758e7ba6dsm20004076wrw.40.2023.08.15.23.15.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Aug 2023 23:15:03 -0700 (PDT) Message-ID: <90acb8cc-b2b6-0fd1-6512-c17502c9d0f6@linaro.org> Date: Wed, 16 Aug 2023 08:15:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2 2/5] firmware: qcom: scm: Add SDI disable support Content-Language: en-US To: Robert Marko , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, quic_gurus@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: computersforpeace@gmail.com, Mukesh Ojha References: <20230815140030.1068590-1-robimarko@gmail.com> <20230815140030.1068590-2-robimarko@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230815140030.1068590-2-robimarko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/08/2023 15:59, Robert Marko wrote: > Some SoC-s like IPQ5018 require SDI(Secure Debug Image) to be disabled > before trying to reboot, otherwise board will just hang after reboot has > been issued via PSCI. > > So, provide a call to SCM that allows disabling it. > > Signed-off-by: Robert Marko > Acked-by: Mukesh Ojha > --- > drivers/firmware/qcom_scm.c | 23 +++++++++++++++++++++++ > drivers/firmware/qcom_scm.h | 1 + > 2 files changed, 24 insertions(+) This should be squashed with next patch. Adding local function without user is useless. Best regards, Krzysztof