From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 739B92FE07A for ; Tue, 2 Sep 2025 12:02:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756814545; cv=none; b=J0HphVaZa+pBPAsTBAspN4nnUPHW6l/Re9JRG2oaNOubVsHC+lKrztg1Q9RuzTdVe7K7oDyFa+EBelf9aO3leLUiH2pyHHDASRdhs7bWwdfc+Q3VLhErOGnn1LXsRXmBwAXjFpXnt/oqpNOzemEFEHHakMqcYihpn5x34BA82CU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756814545; c=relaxed/simple; bh=4TzxjJYIEkM93LSsZNJ7ZgTRddLrFBxtbjs3pMbeoUw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lgHWsDsvk/Cj9ryu3HKcmQWuwHB1765GSl4/+pBl+7zwwfGSLHkTEZl6wv2ruRrxTRswolV+Aj/6xIgFzIu53rtNMAo6EZ09HTAjQvxksRVu7NZ2Rrgr1Ai8nqmf+JHpR3sbbnjEEctPnh/ApX0GKjs7WYANuEvodLhA3rOQ8KM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Bk66qHMa; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Bk66qHMa" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 582B043T013850 for ; Tue, 2 Sep 2025 12:02:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9/1kAQDm/SU/mMAVnrKZOzxGTzM4Q3HKFjG6jr+d3L4=; b=Bk66qHMa5mklpb+b l8R3j0hB77vZfbO1l1yn0YGsEZGfkJzup0058kF1ciMr5gwt4MuUmoBhLM7+mq6u 0BoT+ZkiddUxItWCFi16y9dUmTwvDBnSubKNP9eTdy+rXExIMV3lEctgn26MlIFC uc6wNcZL9JwOgWLOT6swvBWgr+G9lZfQhcIeMycTyONvs+J79x4QN+VrsddChI5Q WOkJD4+sHzPXdEoFvdOaaTJROKHbMMXnBIUGW0RU8NAaK1jp8o8wktmxSWhxdnQE RssUhfytPc7zIF+1MJrMWlZPCilHUoPucbZy8huYcOYnh/a56ZBQwDGzZ43/bX6p bMa3uA== Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48uq0eftk2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 02 Sep 2025 12:02:21 +0000 (GMT) Received: by mail-vk1-f199.google.com with SMTP id 71dfb90a1353d-544b00a07beso46808e0c.2 for ; Tue, 02 Sep 2025 05:02:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756814540; x=1757419340; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9/1kAQDm/SU/mMAVnrKZOzxGTzM4Q3HKFjG6jr+d3L4=; b=h0tdTFu7XBnypBWUn6ltkglqu8OA5hY0d0NIq725SN8iVmgm5Mskfa5TqCKMnMcDzI v2GQqcsJ2BP0nLV943GCZ24Y+GTmGR7w9+7i8yCifXy0/PIgLWTJyyKSETnPTC5WVVri /+vloLT2aQuZOoIf0PNdS2bVj4WXtC/tns6LDrtnIoZEDLLMuLL4zTyh1wGgCLlVVOMa p3B/jh8HvZifTSuDuL8Jv6sK6dLrc9DSgjvwyvVhA3M+nTHOj3D0asQgC50jr/qV0uf5 sQJ2hu1qkTeccbt72hUas9srh1yMg9od8JUehTLOgcmer4N9kfVzioaz6dgzl6r6i/0t PlZw== X-Forwarded-Encrypted: i=1; AJvYcCX+YoUgFXxb7fGPyRElwPKR96Wj9i/YNl3x1hGgo9CvyxYaO28dQ5HS1EksUP7i0IIp5asmd2VVAmxQn1Q=@vger.kernel.org X-Gm-Message-State: AOJu0YyQEfKqNDbWeiNJ/oYbbhBJHDKux51yS578a6+wFynXXTjFVH5g RuDQSew1UTrOW++12hEEU1zvgYcOIZcA8KxR+NgNkx8yqSRiraNhmJt5eaQjHRxZ/5W7Rn2P4UX KNLxVJ5U5Kc6QLy6lJ/Cbo37ce4W72BGF/bMhTvr9kRcHHcBW+FhxIyunHsjBWhm8mxE= X-Gm-Gg: ASbGncvI9MKNuJgritK+4vNvC3SH8qobW4VMkuQ1Hn3BamrgFGqlhNMbzZZ/aTW+3g7 7S2wr0Ilm/hOqYeEcEi8rr5y3WFegz6nGQFAmSwcMYpy5RygAc8FX/HbeJxvzwyj/iUlzvgV34a tpDmCk73tZ51AmbRyAiBJX/u6oVwTb3sjPuyHXTAHOk0DfLacCJ+ggJyuXoW37tTUr4hqv4lxhl /qJ4gLXFjZiDvj6oI9tGgIJJikthIK+ZZdbrPkdwceZPUZF4bGp2hFcMcF/pzLXM12BBqRIWG4E zNDlMBbgypA+IR0/UjtYAbjHOoih0gaHIGZDoNRoNsrtWXSFZo63VPKAjWy7mAPQIEmJWHDF/cV ioqJzcv8fz/JUSYzvbPLQmA== X-Received: by 2002:a05:6122:3a83:b0:544:9bc2:8676 with SMTP id 71dfb90a1353d-5449bc2aa5dmr1067967e0c.1.1756814539679; Tue, 02 Sep 2025 05:02:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEkeOteUQsHrAg2Cy2y9fzQCmk+oLMhpHwli32VvO1rpwsKviEqQRUMDoCaCgN2xEoKHR06lA== X-Received: by 2002:a05:6122:3a83:b0:544:9bc2:8676 with SMTP id 71dfb90a1353d-5449bc2aa5dmr1067944e0c.1.1756814538721; Tue, 02 Sep 2025 05:02:18 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-61cfc1c7848sm9834988a12.2.2025.09.02.05.02.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Sep 2025 05:02:17 -0700 (PDT) Message-ID: <90b13660-1844-4701-8e63-7fde2f093db0@oss.qualcomm.com> Date: Tue, 2 Sep 2025 14:02:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sc7280: Drop aggre{1,2}_noc QOS clocks on Herobrine To: Brian Norris , Bjorn Andersson , Konrad Dybcio , Georgi Djakov , Odelu Kukatla Cc: cros-qcom-dts-watchers@chromium.org, Conor Dooley , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Krzysztof Kozlowski , Rob Herring , Douglas Anderson , devicetree@vger.kernel.org References: <20250825155557.v2.1.I018984907c1e6322cf4710bd1ce805580ed33261@changeid> <20250825155557.v2.2.Idebf1d8bd8ff507462fef9dc1ff47e84c01e9b60@changeid> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250825155557.v2.2.Idebf1d8bd8ff507462fef9dc1ff47e84c01e9b60@changeid> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: ImOykBPREy2I08YmbvMNmWZfJY2FLIIz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODMwMDAwNCBTYWx0ZWRfXzaO22jEBStxe V/FYGPLrDK3W75Be0FpfP9tEwCSainj4+wBRa1sK7sjtjqTtp3LE7U2c/GaIrkLR/GETGKpH/ac Exbpvqz84s5SkMoGHl2k2FR0WYxipU2VeQSjp40c5crW2vuMFPOxoEy2ez6qF1+24ihTIfvHpVU WXcMetRLdsEInUE0Lunk6FotcMz0V1FJbWIX9SP8AbgedAfsEmCXEJUp48y4YVRNqGUtBEojqYc EX2baUnn7jiyhUJSk1MCpRLSpwg0UkBlHhaNzZDIKGdn7fV+Dxa6AKFuu9IyNg11aozmdyqYNL0 SzeHjACIN5kcWWetTtoIiBDWRsTTJylDD6+bFEdHVf20Acvd465D97wHerqmvx5dw75V8hs0Hyg kXPaKsgS X-Proofpoint-ORIG-GUID: ImOykBPREy2I08YmbvMNmWZfJY2FLIIz X-Authority-Analysis: v=2.4 cv=ea09f6EH c=1 sm=1 tr=0 ts=68b6dccd cx=c_pps a=+D9SDfe9YZWTjADjLiQY5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=IKJ9IO03V--UWE61HX4A:9 a=QEXdDO2ut3YA:10 a=vmgOmaN-Xu0dpDh8OwbV:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-02_04,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 clxscore=1015 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508300004 On 8/26/25 12:55 AM, Brian Norris wrote: > Ever since these two commits > > fbd908bb8bc0 ("interconnect: qcom: sc7280: enable QoS configuration") > 2b5004956aff ("arm64: dts: qcom: sc7280: Add clocks for QOS configuration") > > Herobrine systems fail to boot due to crashes like the following: > > [ 0.243171] Kernel panic - not syncing: Asynchronous SError Interrupt > [ 0.243173] CPU: 7 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.11.0 #1 c5464041cff584ced692726af2c4400fa2bde1db > [ 0.243178] Hardware name: Qualcomm Technologies, Inc. sc7280 CRD platform (rev5+) (DT) > [ 0.243180] Call trace: > [ 0.243182] dump_backtrace+0x104/0x128 > [ 0.243194] show_stack+0x24/0x38 > [ 0.243202] __dump_stack+0x28/0x38 > [ 0.243208] dump_stack_lvl+0x28/0xb8 > [ 0.243211] dump_stack+0x18/0x30 > [ 0.243215] panic+0x134/0x340 > [ 0.243219] nmi_panic+0x48/0x98 > [ 0.243227] arm64_serror_panic+0x6c/0x80 > [ 0.243245] arm64_is_fatal_ras_serror+0xd8/0xe0 > [ 0.243261] do_serror+0x5c/0xa8 > [ 0.243265] el1h_64_error_handler+0x34/0x48 > [ 0.243272] el1h_64_error+0x7c/0x80 > [ 0.243285] regmap_mmio_read+0x5c/0xc0 > [ 0.243289] _regmap_bus_reg_read+0x78/0xf8 > [ 0.243296] regmap_update_bits_base+0xec/0x3a8 > [ 0.243300] qcom_icc_rpmh_probe+0x2d4/0x490 > [ 0.243308] platform_probe+0xb4/0xe0 > [...] > > Specifically, they fail in qcom_icc_set_qos() when trying to write the > QoS settings for qhm_qup1. Several of the previous nodes (qhm_qspi, > qhm_qup0, ...) seem to configure without crashing. > > We suspect that the TZ firmware on these devices does not expose QoS > regions to Linux. The right solution here might involve deleting both > 'clocks' and 'reg', but 'reg' would cause more problems. Linux is > already OK with a missing 'clocks', since pre-2b5004956aff DTBs need to > be supported, so we go with an easier solution. Just to make sure I'm reading this right - the clocks enable just fine, but it's the writes to the QoS settings that trigger the hang? Any chance skipping qhm_qup1 specifically makes things better? Could you please share your exact software version (which I assume is really just the version of TF-A in this case) so I can try and reproduce it? Konrad