mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Amelie Delaunay <amelie.delaunay@foss.st.com>
To: Hyunjung Ko <hj351016@gmail.com>, Vinod Koul <vkoul@kernel.org>,
	Frank Li <Frank.Li@kernel.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	<dmaengine@vger.kernel.org>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: stm32-dmamux: don't resume runtime PM under a spinlock
Date: Wed, 18 Nov 2026 16:25:00 +0100	[thread overview]
Message-ID: <90b4417d-f2fe-498a-8128-3229eb284d8c@foss.st.com> (raw)
In-Reply-To: <20261118082853.926607-1-hj351016@gmail.com>

Hi,

On 11/18/26 09:28, Hyunjung Ko wrote:
> stm32_dmamux_route_allocate() calls pm_runtime_resume_and_get() while
> holding dmamux->lock with interrupts disabled. The runtime-resume
> callback stm32_dmamux_runtime_resume() calls clk_prepare_enable(), which
> can sleep, and the device is not marked pm_runtime_irq_safe(), so this
> can sleep in atomic context.

Indeed.

> 
> The lock does not protect anything here: the dma_inuse bitmap is already
> updated under the lock earlier in the function, and this second critical
> section only wraps the pm_runtime call. Drop the lock around it.

The lock is misplaced and completely useless here. Your patch is correct 
but incomplete.
The lock should instead protect the CCR register write, as in 
stm32_dmamux_free(), which also needs to be fixed.

> 
> Fixes: 4f3ceca254e0 ("dmaengine: stm32-dmamux: Add PM Runtime support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Hyunjung Ko <hj351016@gmail.com>
> ---
>   drivers/dma/stm32/stm32-dmamux.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/dma/stm32/stm32-dmamux.c b/drivers/dma/stm32/stm32-dmamux.c
> index 57318715d9f3..890328b3d302 100644
> --- a/drivers/dma/stm32/stm32-dmamux.c
> +++ b/drivers/dma/stm32/stm32-dmamux.c
> @@ -139,13 +139,9 @@ static void *stm32_dmamux_route_allocate(struct of_phandle_args *dma_spec,
>   	}
>   
>   	/* Set dma request */
> -	spin_lock_irqsave(&dmamux->lock, flags);
>   	ret = pm_runtime_resume_and_get(&pdev->dev);
> -	if (ret < 0) {
> -		spin_unlock_irqrestore(&dmamux->lock, flags);
> +	if (ret < 0)
>   		goto err_put_dma_spec_np;
> -	}
> -	spin_unlock_irqrestore(&dmamux->lock, flags);
>   
>   	mux->request = dma_spec->args[0];
>   

In addition, I suggest:
@@
-	stm32_dmamux_write(dmamux->iomem, STM32_DMAMUX_CCR(mux->chan_id),
-			   mux->request);
+	spin_lock_irqsave(&dmamux->lock, flags);
+	stm32_dmamux_write(dmamux->iomem, STM32_DMAMUX_CCR(mux->chan_id),
+			   mux->request);
+	spin_unlock_irqrestore(&dmamux->lock, flags);
+

And moving pm_runtime_put_sync() in stm32_dmamux_free():
@@ static void stm32_dmamux_free(struct device *dev, void *route_data)
      /* Clear dma request */
      spin_lock_irqsave(&dmamux->lock, flags);

      stm32_dmamux_write(dmamux->iomem, STM32_DMAMUX_CCR(mux->chan_id), 0);
      clear_bit(mux->chan_id, dmamux->dma_inuse);

-	pm_runtime_put_sync(dev);
-
      spin_unlock_irqrestore(&dmamux->lock, flags);

+	pm_runtime_put_sync(dev);
+
      dev_dbg(dev, "Unmapping DMAMUX(%u) to DMA%u(%u)\n",
          mux->request, mux->master, mux->chan_id);


Runtime PM calls are made outside the lock, which is held only for the 
CCR write and the dma_inuse bitmap.

Regards,
Amelie

  reply	other threads:[~2026-11-18 15:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  8:28 Hyunjung Ko
2026-11-18 15:25 ` Amelie Delaunay [this message]
2026-11-18 15:28   ` [PATCH v2] dmaengine: stm32-dmamux: don't call " Hyunjung Ko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90b4417d-f2fe-498a-8128-3229eb284d8c@foss.st.com \
    --to=amelie.delaunay@foss.st.com \
    --cc=Frank.Li@kernel.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=hj351016@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®