Re: [PATCH v2 2/5] fs/resctrl: Free mon_data structures on rdt_get_tree() failure

[Babu Moger <babu.moger@amd.com>]

Hi Tony,


On 5/15/26 14:39, Tony Luck wrote:
> If mkdir_mondata_all() succeeds but a subsequent call in rdt_get_tree()
> fails, the mon_data structures allocated by mon_get_kn_priv() are
> leaked. Add mon_put_kn_priv() to the out_mondata error path to free

out_mondata -> out_mongrp ?

Thanks
Babu

> them.
> 
> Fixes: 2a6566038544 ("x86/resctrl: Expand the width of domid by replacing mon_data_bits")
> Reported-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>   fs/resctrl/rdtgroup.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c
> index a6376a3fc4c3..506b40dc9430 100644
> --- a/fs/resctrl/rdtgroup.c
> +++ b/fs/resctrl/rdtgroup.c
> @@ -3071,6 +3071,7 @@ static int rdt_get_tree(struct fs_context *fc)
>   		kernfs_remove(kn_mondata);
>   out_mongrp:
>   	if (resctrl_arch_mon_capable()) {
> +		mon_put_kn_priv();
>   		rdtgroup_unassign_cntrs(&rdtgroup_default);
>   		kernfs_remove(kn_mongrp);
>   	}