From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAA49C43331 for ; Thu, 26 Mar 2020 17:06:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB48E20714 for ; Thu, 26 Mar 2020 17:06:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728141AbgCZRG3 convert rfc822-to-8bit (ORCPT ); Thu, 26 Mar 2020 13:06:29 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([207.82.80.151]:50242 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726267AbgCZRG3 (ORCPT ); Thu, 26 Mar 2020 13:06:29 -0400 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-128-BbCZWy8OPy-iM7dSdlzdMw-1; Thu, 26 Mar 2020 17:06:25 +0000 X-MC-Unique: BbCZWy8OPy-iM7dSdlzdMw-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 26 Mar 2020 17:06:25 +0000 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Thu, 26 Mar 2020 17:06:25 +0000 From: David Laight To: 'Jessica Yu' CC: "linux-kernel@vger.kernel.org" , "'Linus Torvalds'" , Masahiro Yamada , Matthias Maennich Subject: RE: modpost Module.symver handling is broken in 5.6.0-rc7 Thread-Topic: modpost Module.symver handling is broken in 5.6.0-rc7 Thread-Index: AdYDiqOPE71nee/CTfS3aDSZbkO5JwABAkKAAABe9DA= Date: Thu, 26 Mar 2020 17:06:25 +0000 Message-ID: <90b763cc306140499fddf8e3185e26f5@AcuMS.aculab.com> References: <931818529b1d4d13a08d30ddace22733@AcuMS.aculab.com> <20200326165036.GA22172@linux-8ccs> In-Reply-To: <20200326165036.GA22172@linux-8ccs> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jessica Yu > Sent: 26 March 2020 16:51 > +++ David Laight [26/03/20 16:25 +0000]: > >Something is currently broken in modpost. > >I'm guessing it is down to the recent patch that moved the > >namespace back to the end of the line. > > > >I'm building 2 'out of tree' modules that have a symbol dependency. > >When I build the 2nd module I get ERROR "symbol" undefined message. > > > >If I flip the order of the fields in Module.symver to the older order > >and link with modpost from 5.4.0-rc7 (which I happen to have lurking) > >it all works fine. > > > >Note that I'm using a named namespace, not the default one > >that is the full path of the module. > > > >I'll dig in a little further. > > [ Adding more people to CC ] > > Hi David, > > Could you provide some more details about how I can reproduce the > issue? As I understand it, you have two out-of-tree modules, and one > has a symbol dependency on the second? Pasting the modpost error > messages helps too. Ok, I've found out what broke it. Was actually the removal of the code that parsed Module.symvers from the current directory (which happened for 5.5.0-rc0). Took some digging and printfs in modpost to find what wasn't happening. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)