From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDC2030148B for ; Wed, 21 Jan 2026 11:53:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768996435; cv=fail; b=tePbT6WR7ginKnYHayclt8R6CzDIseDp9k2ST16NZPh4Hqu4n3crvG3tC0qf42us57I+flnWBwf4+E42DNxbsZZgQqv60nA8n8NSsoYYFCa1zNTARjMYF0beSHldagitdiPvuyS74wa6/1JYrVGux2rcbZYX0vi4Samu6VieijY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768996435; c=relaxed/simple; bh=/1C0h70XMef7zgsdInF3RnG5fNaQ8ScNMYs635im1Us=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Yv+q38fe8f9j97JHV1Sy59KUKRPpoW83oGWnm/Ivyxf97U5Su46pioKbFCJiv6ooaf7OrOBPW5G/kz5Wy23MnSz0ViY08NQCcNp2sP7yUVlQ3U5UElsBdJbWNXPqVS0Kro/Dd51rrnWBOjjm4r2LNrT/gMpfGw4BoWNM0vgaOfs= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=KDHWg+oX; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=DnodcUKc; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="KDHWg+oX"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="DnodcUKc" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60L6X81e4091091; Wed, 21 Jan 2026 05:53:35 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=uvBtgRYkRiGshOPzoVEzCPCpecAluLNVEIkCdiUi9O8=; b= KDHWg+oXFO3mqRdxusUEg2KndE1YJgJYFlAcFuxDJ1QlgOpPHldQR+5a25pCbvQ6 U2Q2KLsAIEk3aU3o98oNLYuxt4HJAWO7cftQeOVNWL1Ep02qjdvap21MVTkDpyTG JcdxjIljC14v3+ibuppo7fz40AeFVlRH5uE47KZr6DzPKVHFDhErQMHsdH1fKLvM F1tuklvBdl/yGXuiNiNW4i8ZuLJq91VI9qQcDR/Mos9Afy+D1Z520W79UcGt1DVB u8v0KFokZquAD/RrKarBoLAeukI55KyuZq5wt1Zo/WTmXlRHjHMdLujHHxMFxkDQ v0AB6cbLHEw4iSkcVmwCjw== Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11022099.outbound.protection.outlook.com [52.101.43.99]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 4br7qjvqk2-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 21 Jan 2026 05:53:35 -0600 (CST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=s0omXrh8/ZE4Vkx9OkYX852ridM+UUvRHrJcchfyLdxZAIzl0SnPwWhUPZFVMpgAiFhHgdM8US5mINhpzOFChKmWKgxatyTgZQG3c6y9mTHVw2Euvvrm+P9j5u8z11y4VUlxkjNa4R+x6L1go9ebv9jrtCu7iZ2qIjH/SlJ+HBLtocA40EqB1qjADzlD6FsB9Zaizvkc9DDhLTWU5PzAWOQvj7rMch0anRn4Fz1EgrxKTqtHkEyjXG7TRF76RfflSB5/DGlHRqo0+3Ez/vEHHPmNUMacog+yeinBQnHlErUCocfFm4j1Df56LPx5D+IZ3NmIh9O5YTcydQXg+GcVAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uvBtgRYkRiGshOPzoVEzCPCpecAluLNVEIkCdiUi9O8=; b=OPrZMhH6rUv8TzKw8BTdJp2+97GYX5q2Ba1eExQU6t/Wm5TNDCrhWuzC4QT3ASaXd6yRTYLnHOeW/OYPpGvYwlpq+2kX2yvd9bzwoQBrS2RBTFUeCYglwMcmMm0hG16YhuTOAdeES+ckj4BXUmusfqZjPvZZi926HlX1U0Cr+3tL3XRCOeAXvdR1b6kjDRth+3GN2JNtKqgTHDQRP4yG4ZeONH3d70c8/4XN0Ccam9LGIJrk4DIqmKMfdEDfKkUWlFGP4RKZoePdOBlpraTocJ7R/oQvGNfZEfo0jGgZQ6vpNnMW/araAh10QDxePeNGtsH7NdE716p5EpMguweqPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uvBtgRYkRiGshOPzoVEzCPCpecAluLNVEIkCdiUi9O8=; b=DnodcUKc962MgbGSsp41z3gMbZ7lrrN0Kuv87IDE+bn9il1tFV9F/TB4XF6GcQe9ja7tuxfmlIUeMJoZOAVJjgxXi47x+dGKHMJtf4jbt5C7mVHK5izTp5QBHkFQu8CyIP9BIzdcXtgTi2kEsj4x/P824GViWSSTq31sWeLvZMI= Received: from SJ0PR03CA0057.namprd03.prod.outlook.com (2603:10b6:a03:33e::32) by SA1PR19MB8969.namprd19.prod.outlook.com (2603:10b6:806:45c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.11; Wed, 21 Jan 2026 11:53:31 +0000 Received: from SJ1PEPF00002316.namprd03.prod.outlook.com (2603:10b6:a03:33e:cafe::f9) by SJ0PR03CA0057.outlook.office365.com (2603:10b6:a03:33e::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9542.10 via Frontend Transport; Wed, 21 Jan 2026 11:53:30 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by SJ1PEPF00002316.mail.protection.outlook.com (10.167.242.170) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9542.4 via Frontend Transport; Wed, 21 Jan 2026 11:53:31 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 3AD29406540; Wed, 21 Jan 2026 11:53:29 +0000 (UTC) Received: from [198.90.208.24] (ediswws06.ad.cirrus.com [198.90.208.24]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 28F5C820249; Wed, 21 Jan 2026 11:53:29 +0000 (UTC) Message-ID: <90b80379-6799-4600-886d-08ef48d9a35f@opensource.cirrus.com> Date: Wed, 21 Jan 2026 11:53:28 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: request_irq() usage in wm8350_register_irq(). To: Sebastian Andrzej Siewior Cc: patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Lee Jones , Andy Shevchenko References: <20260121111617.quQxFcZK@linutronix.de> <20260121113659.CCJtYuQS@linutronix.de> Content-Language: en-GB From: Richard Fitzgerald In-Reply-To: <20260121113659.CCJtYuQS@linutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002316:EE_|SA1PR19MB8969:EE_ X-MS-Office365-Filtering-Correlation-Id: 90d7d21d-4550-4dab-e716-08de58e3b2c4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|36860700013|376014|82310400026|54012099003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QzgxcEhYUzRnZ0JXS1lya1luMlQxN3QxeEc2R0R2Ykd1QUNRMXk3U3lpNmhy?= =?utf-8?B?a2YwamE3VkhFMGVYZVZYcnFldDkvTWh0SEVsVXVOMXlJS2lGdlFXTVFzZGUw?= =?utf-8?B?djc5QjhWdWZlV1pzR0NyaVBMK29lYk84cStVQUhpNmp5VCtiZVY4dHdEU01k?= =?utf-8?B?bkNiaGNLSTRzNUFNcWtsd2E1cXZwYWk1QVRxeDM3MkszUG9XT3ZjcGZLditH?= =?utf-8?B?cEpRbjlDa3h6VTlubXJ6emZLL1N4WkZHM3dlRmR3cnRod2hlTVA1TlRIbGZY?= =?utf-8?B?VVNXdTE4ODhsdklNemxvTnVkR0Vvdk0veGE0NFJadGlsVTRQQ2s4SlByWXpS?= =?utf-8?B?UTRNc1hIVVRUSUpNMndsanpkbWZMRWJDYlA4MjZ3Q0ZOODlSclVWQzNCZGJj?= =?utf-8?B?bXMxb0hudysvY2ZuTk5scTlXdmxYSmdjQ2lRM0xlV1djcm9LUERLa3g2Q2xn?= =?utf-8?B?emk4T2loTGpnRGUyTlZoTWl3ZkIvam44YkhmV2JuT3U1M3M3L2NrSGc5VmxW?= =?utf-8?B?eEVibTgyRlFhODFZMW5QR2U2NXV0L1ZQLy80TFI2dkJPVW05ZkJNUWJ5THlT?= =?utf-8?B?NXdtdHdKTHZ0Vy91UEVBT3c4MFJvSGRhRkdhUXU0bUNCaVQ5Uk5nNVlCTTQx?= =?utf-8?B?UE9Jc3JDRzFnRExIckZOdEdTaEdZM1VZdUUxSXIzWXphdmVHMXNNTUg2MEkv?= =?utf-8?B?S0hSQUhsenpZVWd2RFBOdFQwejQ3dE5ZUEwyNzMvaEFUVkd2RU9mbTA4cjBX?= =?utf-8?B?WWpVT0hGdnBvdjRycjZhQ1JwamkwVkY0RmJlY2FyUThzMm0zcnVSNWtiY01V?= =?utf-8?B?eVM3L0ZPZGdTdW9saXQ0TU1DaFY3RWdvZFNUeEw0bEMyZHpDcU9BSVZDVjJB?= =?utf-8?B?TWdJMUtIZFVWQm04WHdZN1dRUVozRy8wZXNhOVA5MzBidHBqdFBIbUhpKy9P?= =?utf-8?B?ZlQ5VU4wWHU5MzhxQWZkaGQ2YTl5KzhEOXFJUDFqZ214U25tbktxWU1sY1N6?= =?utf-8?B?SlRsRng0cnhnak9NY3FVMCtzSXJTNEhZc3ZHRWc5cUtMTkxLV25ibDd0L1d1?= =?utf-8?B?SnBLZW51UFRIYXR5QUZDMDhZM3JVTkc2dVFJaUprNUc4L3YzRVRSZWVjZWt6?= =?utf-8?B?Um42OXF2RkFEYUlpRTNWOHZpV3pxbStHVGt3SWEwNTgyd1ZEUmNlQ3F1ZUJG?= =?utf-8?B?MnVtamhBTnhxcmRQVlhwWExHVVlWczdPNjl6YWdHcXBuZXhYejh3Zjc1VUpk?= =?utf-8?B?QlF0dUpNd01UQXlpLzVMWXY4QUQ5c1NSTFMwcVJrcHNTNXNXZXFYL1Z5bVIz?= =?utf-8?B?akcvQXMzU2lGcy9LNTFOc3BuWThWZFpscHNORURzakdHd280am1CRmM3eHV5?= =?utf-8?B?dE9UVFBSV0EwWFVPNFBab1grMGNJajJFMWhZMnRpRVlyaW9CZ3RUbTZrRnd5?= =?utf-8?B?VElFaEYzeXQ3c3UzeFIwTFhtODRQRGZ4V0NOb1FxUzBZZ1U3RThDMVlMVVBQ?= =?utf-8?B?RHNFeGxTTGpJQ1IzNWI0NlVja2wwWGc3R3VSWEV3Q1Vqem93am96M244a2kz?= =?utf-8?B?T1pDbVhDbk9vRFZ5Z3VsT2VVUUVDSXp1ZlBSNHVVN0s3WTdaeGFmdWloRnNW?= =?utf-8?B?cDRBRFdrQVFNdDcvalhLS3V6VURrMndUeUZqLzRKZjZaNmtteG5oRVZJYVZW?= =?utf-8?B?SWgxNlVoNlhvNS95dmZsWVBNL1YveXptU2Z0ak9RWEVrd0N3K0tFNFArYVNr?= =?utf-8?B?YTc2Vmd2V2J6NytkOVZCNVVEZmtiNU52MWgzL3pFYStySVl3NUNNclhtcDJE?= =?utf-8?B?TEEybDlUVE00WTJGaEN6eWhzMTZ1MWdJNXVUeEtOTUlVenFmSTlUb2lCaDQw?= =?utf-8?B?Y09MMGxTZ1Q4MVBZWWd6YnNJU0pDVDJqejdYUUFpcys1L25sdXlWMGk5aElM?= =?utf-8?B?aWpBVWwvd1djQi81QnBLaUF2VVhoa3h1Q25Dc3VuSWNyek5JQVRDcXovSlZz?= =?utf-8?B?aW5DWXZDM0RNcU1GRVIyM3FSeW54UXkyUnI4S0tNbHpNZlFPeWdCWWIyNm13?= =?utf-8?B?ejFiWFJ2ZWY4WTNTZ2xkd1dKN2UrMXBYdytIT2pkdFdadFVFVHg4ZjlXUTFt?= =?utf-8?B?SExCTndsOTYvQnRFc3NtQkhVZ3R2S2dFaEdpUThzL0pJS2w5WUhQS3JmR1J4?= =?utf-8?B?Y3YvY2F5dkpBeTI3OU9zazN1VUIrTllOVThOais2WlQvaHJpSmIyZlpicytq?= =?utf-8?B?eWZuK1Z0L3lGRmlFWENCQzYyRzJRPT0=?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(61400799027)(36860700013)(376014)(82310400026)(54012099003);DIR:OUT;SFP:1102; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2026 11:53:31.0003 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 90d7d21d-4550-4dab-e716-08de58e3b2c4 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-SJ1PEPF00002316.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR19MB8969 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIxMDA5OSBTYWx0ZWRfX4Ve+/EFYqQO/ 4Nb2syv1nacLFHz0OklBgS+cfWgrMwTERcplz5gsquTfICBVcTP1iBs0WriOSQn5e2n1w+AzcNJ MrBVWzqoVLuirvZi5EwlxhalOHsfAinktgrZ3xhC16s4Ub7AxRDce4aRpl4yBAGFru4PI0k47+L ObyWNe0xcMkEq7bBDWCCjEbwKWDIHxN/n4yluLJqEselYR50rPHs6Bv1dkoE1CRHXdAliN65GKR +ai5Yn7im3EFQj8SctsxoDM1qzqbMQbLpk3hmcKe/VUZBeGhAmmIhk+AbBnnKHdgvA7VxKnv5sW wFTy7mJPGdWIuKNka+N4tkmMf6s7AQEUU0wM5XxYf4606/haur0Nx4LOSoA0c/mY7DIm1Gmyvxm NYsp0eqHkuC7YXZlfKshqyj+tnZmSqe5YAL1q079FAYVp3Qj8hQDI4kG6qySY7zgAe7jv2SuE5I yLcmuRPlmD3lfjj41vw== X-Proofpoint-GUID: 7siDpnq4kj8UTOl-HYPFWtNiKtmmvCkT X-Authority-Analysis: v=2.4 cv=GrRPO01C c=1 sm=1 tr=0 ts=6970be3f cx=c_pps a=MyZQQtGQDv4zT9mHdzB88A==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=4ArUX50hw130fP2HYDcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: 7siDpnq4kj8UTOl-HYPFWtNiKtmmvCkT X-Proofpoint-Spam-Reason: safe On 21/01/2026 11:36 am, Sebastian Andrzej Siewior wrote: > On 2026-01-21 11:22:32 [+0000], Richard Fitzgerald wrote: >> Or because request_threaded_irq() supplies a default handler, so >> handler!=NULL when it calls __setup_irq(). >> >> >> int request_threaded_irq(unsigned int irq, irq_handler_t handler, >> irq_handler_t thread_fn, unsigned long irqflags, >> const char *devname, void *dev_id) >> { >> >> ... >> >> if (!handler) { >> if (!thread_fn) >> return -EINVAL; >> handler = irq_default_primary_handler; >> } >> >> ... >> >> >> retval = __setup_irq(irq, desc, action); >> >> ... >> } > > -> > > | } else if (new->handler == irq_default_primary_handler && > | !(desc->irq_data.chip->flags & IRQCHIP_ONESHOT_SAFE)) { > … > | pr_err("Threaded irq requested with handler=NULL and !ONESHOT for %s (irq %d)\n", > | new->name, irq); > | ret = -EINVAL; > > Sebastian Ah. I didn't notice that. Confusing error message. It says "handler=NULL" but handler != NULL. More like "handler=default".