mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: InKi Dae <daeinki@gmail.com>
To: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Cc: Kyungmin Park <kmpark@infradead.org>
Subject: [PATCH] fixed distortedness situation for Samsung SoC Framebuffer  Driver
Date: Wed, 5 Aug 2009 19:31:43 +0900	[thread overview]
Message-ID: <90b950fc0908050331i7c98a008qc3e66ce849019cb3@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

This patch solves the problem that image is distorted in the mode more
then 24bpp.

In 16bit mode, WINCON0[16] should be Swap Enable(HAWSWP_F) and in the
mode more then 24bpp,
WINCON0[15] should be Swap Enable(WSWP_F).

For this, I added a MACRO in regs-fb.h file for 24bpp+ and modified
s3c-fb.c file also.
It was tested on s5pc100 and s5pc110 and worked fine.

signed-off-by: InKi Dae <inki.dae@samsung.com>

Thank you.

[-- Attachment #2: s3cfb.patch --]
[-- Type: application/octet-stream, Size: 856 bytes --]

diff --git a/arch/arm/plat-s3c/include/plat/regs-fb.h b/arch/arm/plat-s3c/include/plat/regs-fb.h
index e9ee599..ae5eb5d 100644
--- a/arch/arm/plat-s3c/include/plat/regs-fb.h
+++ b/arch/arm/plat-s3c/include/plat/regs-fb.h
@@ -173,6 +173,7 @@
 #define WINCONx_BITSWP				(1 << 18)
 #define WINCONx_BYTSWP				(1 << 17)
 #define WINCONx_HAWSWP				(1 << 16)
+#define WINCONx_WSWP				(1 << 15)
 #define WINCONx_BURSTLEN_MASK			(0x3 << 9)
 #define WINCONx_BURSTLEN_SHIFT			(9)
 #define WINCONx_BURSTLEN_16WORD			(0x0 << 9)
diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
index 5a72083..24d56ed 100644
--- a/drivers/video/s3c-fb.c
+++ b/drivers/video/s3c-fb.c
@@ -422,6 +422,7 @@ static int s3c_fb_set_par(struct fb_info *info)
 		else
 			data |= WINCON0_BPPMODE_24BPP_888;
 
+		data |= WINCONx_WSWP;
 		data |= WINCONx_BURSTLEN_16WORD;
 		break;
 	}

                 reply	other threads:[~2009-08-05 10:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90b950fc0908050331i7c98a008qc3e66ce849019cb3@mail.gmail.com \
    --to=daeinki@gmail.com \
    --cc=kmpark@infradead.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®