From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCF81309F00 for ; Tue, 16 Jun 2026 11:14:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781608464; cv=none; b=IgloG+sOXUq23aKO07hOn6wwPQ6p1nJpxP8nEWMG/XcY4N7hDhpHcRQ8uz5MubxLOWLnd+vpmQ+dHILLmsmio8oEfXwC/dTwky/7doVcmg3z41iDjzLJNUaZM4rpvpTWid3HPEefcu9TO973tkohfGQp0iGE3WTsqoR5etoS+BY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781608464; c=relaxed/simple; bh=OQ7dkFnQJlc0ejXfMEENqq9M1D366YdvQk/DHWariCA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=UaBoyqlOLEGomfE8hUlPGU0a0TDmapNLDGgwkwPSUSfsgklBnnL10NL0kj+jzbuyfQ1rozN3SZAsJlvovANItNztkVc8CMSXwKL57fjHtOhNdOjhP8p3/gancZjisoXos0ojZtmA74NoonmGdAcZhTCzcbMVaOUEQ0J2NLQj2Qo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=f8OD1ce/; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=LiNL9IlZ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="f8OD1ce/"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="LiNL9IlZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781608461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6naCJKi/lyJIy5fzCdFSeiS5sUypi98L+LX13ZNgRaM=; b=f8OD1ce/C9HfFbOWaahhIp7JpTbUwM7IgSAQVzE5TeX5oDtOECFC2mOueqKA5eacFg5UQ7 DnqcE/89MT797Iif5MFQaFb9h5jF2zzDOvSgg63g6cWbrN955CevOKFAmc9qa8nWMBZj9v BnRHcF+ZyBoOnmvQR/hya/1YF2L3paQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-331-c3jasGf5NW23-ADUiIncag-1; Tue, 16 Jun 2026 07:14:20 -0400 X-MC-Unique: c3jasGf5NW23-ADUiIncag-1 X-Mimecast-MFC-AGG-ID: c3jasGf5NW23-ADUiIncag_1781608459 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-490c56e2576so35099305e9.3 for ; Tue, 16 Jun 2026 04:14:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781608459; x=1782213259; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=6naCJKi/lyJIy5fzCdFSeiS5sUypi98L+LX13ZNgRaM=; b=LiNL9IlZPCZ548NQIyDkRZZPtHVDLicgJk5HlmLhxP8+rTxX74rjfpIU9HNhg9njg8 tGCgkgGd0om4fATTgqXiYSSSS165d9LzdDhmqMxfGnC+YSnuo7k7/6dQpp3f2mVReSpE Tfs4FP3jse3k4Bmr303ZfxgR6zI3jBvR0Sl79rQI5byi+3SqXNeN6+HXjneR8MrrFrmD BnNBTZwkVV/E4QfIUZrdFOApiXVfmVzMmO0ZxwZjFlYUktm09ewZgSSpzumgfyJ84yHE 2Tun7+15DX9q8+5o3GZgecq15l2DJ6wX5pbwH5Q94GkmlOzoJFLin3BVxuyTGOh5bRal TjaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781608459; x=1782213259; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6naCJKi/lyJIy5fzCdFSeiS5sUypi98L+LX13ZNgRaM=; b=jDOY7h715vxqXno1E/PIDbJFu18U98lvnCnD9dB23t0WxAXD2iO+klGg50AHjCx4QS gFW850a7ZjqS5L1SCcbHXaAYesJ5VlufyzVrw94+hjk2D6+B4Yt4WWuF/ayWijwQm7Yn BXzTiNgovNioVwkMPLZl2mLwkSysNmcIq+yod/7Y0WI8nhRGYEuzH9tF7szU2vhEmyVm 1R2ya0k6aCPFOMICyL6MFprThluGUS6laXL+HTLCDbV0Sjbl0+TjcNPmT0ypaJ3gM1bv /2VxHPCIiTwKHzckfRPhPtKXoACce5BF8lD7wnd9+nqaMg3FZ2uq3tKLIhtLMlTqhzTh 28rg== X-Forwarded-Encrypted: i=1; AFNElJ/cfGzGQcYaJ7GeThHuU4SCpe66KC+q8tUjsETs0XYMytNFkHsN98qmZf7K6s2jGlD+518PhL8RFxC4oII=@vger.kernel.org X-Gm-Message-State: AOJu0YxXIBg1aZdc8yTYdIodLOH0hcAUll1ka5LBMp4Vx3lOw32EsiXF 1U20UCJVk1Pb0wlnTiSDCGl+DPcSXar/wGPy0tdIVFHmJJZGgzCK+bKW5KjQdvnxguMdVI39VLB xxxezXfGVG3g2+PQGrPQ8cv4nPbCvcSTYqTG+Jlw8AuozMpJiOsArGoZ+ihmFbqmBJg== X-Gm-Gg: Acq92OEYdbM3lVZk8j7J0poX44ygIsCfqCZLZHczrKwzU65DFtc/Oav0LOTZp+J59a4 bylk1t5w+hxR+jUwmPASFuhQAbw2yQ0uGfrKQ8O5ZlMR3leWxKv4B8EZcKmoSn/KOLboZor2NWW JjMfkyEs4ngqEQlLyHD7zk+SEt+JUTqCYU0C/MZQog2pOt5+6q55jQsEXcfyTlOmJpHFge5vvJ9 0RIHrxWc+f/hg935ay54IpytDQ4Jo8pO52Yjp25sLuUHpfy1huMo3PdwSc1pD8CGZXtM2pxPe6D qI7zE3LNHHKUQQQj59vXVsmHJBHA37+7DH32XsvoSHRfEWmlc8tfKMxuHtGdRr1bmyBTw1KR0Ca INTUk75v/nCVI6VRPN6tmafYaVw== X-Received: by 2002:a05:600d:8494:20b0:492:2d84:fbd1 with SMTP id 5b1f17b1804b1-4922ff7bc9cmr41223975e9.15.1781608459352; Tue, 16 Jun 2026 04:14:19 -0700 (PDT) X-Received: by 2002:a05:600d:8494:20b0:492:2d84:fbd1 with SMTP id 5b1f17b1804b1-4922ff7bc9cmr41223515e9.15.1781608458868; Tue, 16 Jun 2026 04:14:18 -0700 (PDT) Received: from [192.168.1.167] ([185.168.96.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49230a4fd31sm52422755e9.4.2026.06.16.04.14.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 04:14:18 -0700 (PDT) Message-ID: <90ba0c6d4e6f0706acb78197a1607968472da6bb.camel@redhat.com> Subject: Re: [PATCH v3 8/9] selftests/verification: fix verificationtest-ktap for out-of-tree execution From: Gabriele Monaco To: wen.yang@linux.dev Cc: Steven Rostedt , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 16 Jun 2026 13:14:16 +0200 In-Reply-To: <95e700c62601cf432842269d89a86a492d073f0e.1780847473.git.wen.yang@linux.dev> References: <95e700c62601cf432842269d89a86a492d073f0e.1780847473.git.wen.yang@linux.dev> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-06-08 at 00:13 +0800, wen.yang@linux.dev wrote: > From: Wen Yang >=20 > verificationtest-ktap used CWD-relative paths which broke when > invoked outside the verification directory (e.g. via vng). I still don't get this, I even run from my home directory and it works without this commit: make -C linux/tools/testing/selftests/verification/ run_tests=09 It builds and runs your new tests just fine, how exactly do you run them? vng shouldn't affect this since it runs from the same directory as overlay mount, what errors are you getting? The only issue I see is with the read only filesystems since ftracetest attempts to write logs, but that doesn't seem solved by your commit either. Adding the appropriate rwdir lets me run them just fine: vng -v --rwdir tools/testing/selftests/verification/logs -- make -C tools= /testing/selftests/verification run_tests I'm suspecting you're trying to call verificationtest-ktap manually from somewhere else to call it only on tlob/, but that looks like asking for troubles. While you're at it I don't see why you don't just call ftracetest. Gabriele >=20 > Resolve paths via realpath "$(dirname "$0")" so the script works > from any working directory.=C2=A0 Accept an optional subdirectory argumen= t > interpreted relative to the script's directory. >=20 > Suggested-by: Gabriele Monaco > Signed-off-by: Wen Yang > --- > =C2=A0tools/testing/selftests/verification/verificationtest-ktap | 4 +++- > =C2=A01 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/tools/testing/selftests/verification/verificationtest- > ktap b/tools/testing/selftests/verification/verificationtest-ktap > index 18f7fe324e2f..055747cef38a 100755 > --- a/tools/testing/selftests/verification/verificationtest-ktap > +++ b/tools/testing/selftests/verification/verificationtest-ktap > @@ -5,4 +5,6 @@ > =C2=A0# > =C2=A0# Copyright (C) Arm Ltd., 2023 > =C2=A0 > -../ftrace/ftracetest -K -v --rv ../verification > +dir=3D$(realpath "$(dirname "$0")") > +testdir=3D$(cd "$dir" && realpath "${1:-.}") > +"$dir/../ftrace/ftracetest" -K -v --rv "$testdir"