From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57A5D85931; Mon, 1 Jul 2024 13:04:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719839057; cv=none; b=VATH7/KIiW/Q1Vziirql2qeUpOu6x7K/ga/FKRg3kDspeLbufxV9+QP3aJ0MVouoWsid9OvhqW8Uk6VmKnPgXcCneqiw+0e31D2U3wbSvf6L4ExkWAUWmED75tUcyLnQsBXX8TZy0wrGOYrwLJoq9pTHB1nVXf/sNAcM5AGsso8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719839057; c=relaxed/simple; bh=nGaz0Qgvfx/NnXXbZBvI/HXcjEab7DuIrRSLlgXO9kA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gGV4yK0T6q0tX//rFV9IifwZnImGi1NI2MmLW23MZ7yLmoUg1+MwbdKVdXC2Jvz6E36Zjg8hRUx8ZDNL7M1LAx/kcEzji8S8aJuPFp5c5ahqtFa0oN2pAY5DM63g4jNxa/cAUHZ80YO3iSDjT2ChYn6cepLO0B4mZqOaNA8a0F0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MgZvX+q7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MgZvX+q7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5FB7C116B1; Mon, 1 Jul 2024 13:04:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719839056; bh=nGaz0Qgvfx/NnXXbZBvI/HXcjEab7DuIrRSLlgXO9kA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=MgZvX+q7aP22ABWyd+hd6fhORW6TkphIHkjNia/S66cQIGEmZEu6QvrqUZA9UnR5X 5t6jbKw/Phl3VYQ4dmy5EBs+QoIH4VD8ieAYeWjWJFPEuczCwZl4Rv1oDD4HtqlKNA nHFQOMtUJG3mNXCuYKj6e9PyAQkyASIylKTAwLfkr1T6pGeBQapfhVGPK3AvhfZduA EnvnF9PYFNNKe4muIb2eeEzZAVX5A2Dzal3fOJfSOBqw/V/nrMod3PGBBsKBitofAa OeXXOfsDUjr8+nsUoFZwoVi89TUCr45eYisCj3Gl6KzpBbm6k+mIsoB40Yuzrd/Egf 3++llx7cirlow== Message-ID: <90bed6e2-472a-4882-b1e0-64b50d5c5a47@kernel.org> Date: Mon, 1 Jul 2024 15:04:06 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/5] arm64: dts: rockchip: Add AP6275P wireless support to Khadas Edge 2 To: Jacobe Zang , "robh@kernel.org" , "krzk+dt@kernel.org" , "heiko@sntech.de" , "kvalo@kernel.org" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "conor+dt@kernel.org" Cc: "efectn@protonmail.com" , "dsimic@manjaro.org" , "jagan@edgeble.ai" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-rockchip@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arend@broadcom.com" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "megi@xff.cz" , "duoming@zju.edu.cn" , "bhelgaas@google.com" , "minipli@grsecurity.net" , "brcm80211@lists.linux.dev" , "brcm80211-dev-list.pdl@broadcom.com" , Nick Xie References: <20240630073605.2164346-1-jacobe.zang@wesion.com> <20240630073605.2164346-4-jacobe.zang@wesion.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 01/07/2024 13:31, Jacobe Zang wrote: >>>> +     pcie@0,0 { >>>> +             reg = <0x400000 0 0 0 0>; >>>> +             #address-cells = <3>; >>>> +             #size-cells = <2>; >>>> +             ranges; >>>> +             device_type = "pci"; >>>> +             bus-range = <0x40 0x4f>; >>>> + >>>> +             wifi: wifi@0,0 { >>> Where is the compatible (again!)? Test your code - you will see your >>> binding is a no-op. >> >> I tried to build kernel with CHECK_DTBS=1. And didn't get any message >> like 'compatible' is a required property in wifi node. But when I check >> the bindings that do required the compatible... So I will add it next time. > >> Yep, use different clock name and then test. You should see errors, >> right? But there are not, because schema is not applied to this node at all. >> >> Look how Apple is doing this. >> >> I have doubts that your code works at all in the first place. If there >> is no compatible, how your platform device gets of_node? > > In file brcm_hw_ids.h and pcie.c has added Device ID and Vendor ID > for bus to enumerate the device when board bootup, so I didn't add > specific compatible in DTS. And by doing so, it can probe successfully. I did not ask about probe()... that's quite obvious. How the device's of_node is assigned? Best regards, Krzysztof