From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D68FC2E737D for ; Fri, 29 May 2026 06:08:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780034900; cv=none; b=SKSgqeeL0B70NqBTxf7LP4W8Q0uImhVhpy4Cz2ZgdXcykUwHaGD/Rehae8xHWBlAJlEAwMhe7ZEd7Zei9xZac8hEZt+F88s3+nWtL5nCLB0oep8Y6K5eU0ZLr7EhRaeoVPqTGS6/TXL/3Ya8o6jAZzDkE8blr1MLrb2oQtr4B90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780034900; c=relaxed/simple; bh=QE90Vm1v241VW5L7o0c7RK2smtkqVjG7hxXcnZPfIS0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=jRWRBokbTeiU2O6M+LzKkhWIDP/6NfYyXs2gINqmfgvJZSC7Dl11VnHewgm5+nqW0zlnEz7mjmDC3+S+LaTW/TCVAtMntmDL8F7FNH3QObOpvu6bvPwEnusPZBTR5Nix3Qwe1jbCjxl9O6q+G9r+PVgPhz5Ti3Xe6Ag1/Atuh1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MPzCpNbo; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Stt5jWPU; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MPzCpNbo"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Stt5jWPU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780034897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QE90Vm1v241VW5L7o0c7RK2smtkqVjG7hxXcnZPfIS0=; b=MPzCpNboYajbTux8PAWxic1q2vcO22Y3TE+sCUOt8PMFeatf3ThwDLT09P/5qHhnfBJCfj RszRJZ2B6i9RPSU4bFn3Lt1vMYOXfVruLRNbZTAkYMfTOHo37ZFQw3lQCsFZiqBL9RIJcZ XCytIXnhqmRZaUc4aooBgjIsOzRedbw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-421-izpwfAx_Ow-fHguUuSL_yQ-1; Fri, 29 May 2026 02:08:15 -0400 X-MC-Unique: izpwfAx_Ow-fHguUuSL_yQ-1 X-Mimecast-MFC-AGG-ID: izpwfAx_Ow-fHguUuSL_yQ_1780034894 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4903dcb32f8so65576315e9.0 for ; Thu, 28 May 2026 23:08:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780034894; x=1780639694; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=QE90Vm1v241VW5L7o0c7RK2smtkqVjG7hxXcnZPfIS0=; b=Stt5jWPUKuS9GdJmAy78Lna0H7KsFFSwJtLK2546B9QvIigIP0TEXZKs8W/LWjD2Nc mR4ePZFU+WD8/GCHeZgQu9MocP8bXRegnvSn1x0OPnQNcFvH31C0e7UvTVZ7uD5OGbOQ j6WpFrpzoaTIN/aMURIM8nZVMESoHSgn1FdXUTdn2yLHhb318uQqRUgRmeWOW6DPgb84 JzK3GRoJkvaErYoXqEErF4px3vKLMNSIqwCOAe7lCw+AIkw0FQTQGjzBto9SiXbw8Pbv hIuvPbHQ8/zh41ShnhkYk/Un4AvHw2Wvny0M/Zrl8tDiE4Fz9s3Ok/9V1MmjSTyzIYBH GQtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780034894; x=1780639694; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QE90Vm1v241VW5L7o0c7RK2smtkqVjG7hxXcnZPfIS0=; b=b/p81oi9qMe1Wl7tTNc1MLhWbeJRSwqEMTN5xLj+umf26CPdZFE7LbsQnN7PDg7QtH aYoEDNz9SNFtXVZyzLWaePrUZQD/sKU+e0kG14Ide0SUkEuOVV/y7W/0akiv5aSW26Cc Gj9/B66BXzTSTq1w5AdNJ6KJ3GvQVhykIctBDNVY9A+zUy/yJvt3/b+6ZIcrt3T58zS4 WtW9QA1j4KJSCRJVEZjwf/LAE/sWsMH2LW3nsPrhSWNxTlxQK+QFL9WM2hKnoLE38YE9 Wz+zLmAWd7UXgbfxXNUQmzJxc4yU5lLU7ihq8wPWJfliaKSi6t7q7AuUdpjwtGXaFvR4 2MLQ== X-Forwarded-Encrypted: i=1; AFNElJ+ueykTGDRUsMdzBeNB8AFsOP8Lkvkq6YNhW3V+IhIVOAUpVrQ8tjeTOeyago9GPDUlqqpWQfj6QZoILsk=@vger.kernel.org X-Gm-Message-State: AOJu0YyC7m5qvVbWaHE8QmeX80CYMP3lGI4n6oDwMJUxbLTeVVNCPja4 g9JhtDnB8xWE3kE5mJ3wwP5cePnI9ACqrUT2Jn1ibcEZ4Z2cXNYm4h7shLU7Lv/ZLeplxnSD7cl vuzwOkwy/XT04vuB9AEbnT8k3nU1yvZ465/g981gD5MsNU/QnY/WEM7FxJiDtVB72qg== X-Gm-Gg: Acq92OHnA19j5D5qZRSFIht+cDJwg6YydFlJBZeVaXwEFCY2VRiwbULtSsYl6mui8l0 ykrC+qHSl5jV05Kclf3r5KsDY/GFTbZyHlpk+x6PWS3DUIdQd3l4g/tjaYkVk5lYOZS2gWNsW7I ecB8en/MSMPAx0+Sxx9Y85OADvaCum8iD1Bz9ug5SxUjtsdfr/R28lRslUIsV8lkmfYlArRnzOi dB/M9bk2T86cu1tGEcSqS/G58o7MBUdGyiO2U7/35l6KWHGegVQSMO9KEBhN8JjDHQ+otcQ1EpZ uW3gMoN1ZkaxTlQSDfwB9pu/BTiX+Te/e3BNS4fxpJqddCnaDzHMgz9GmXZnK+dXJy6ZP4dKt5q omegIfuFmRAFc9L/E64xzQzLZwpPjZfidNupr X-Received: by 2002:a05:600c:3104:b0:490:9d1b:f068 with SMTP id 5b1f17b1804b1-4909d1bf102mr17916425e9.29.1780034894083; Thu, 28 May 2026 23:08:14 -0700 (PDT) X-Received: by 2002:a05:600c:3104:b0:490:9d1b:f068 with SMTP id 5b1f17b1804b1-4909d1bf102mr17915865e9.29.1780034893617; Thu, 28 May 2026 23:08:13 -0700 (PDT) Received: from [192.168.1.167] ([185.168.96.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909d68980csm21833625e9.1.2026.05.28.23.08.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 23:08:13 -0700 (PDT) Message-ID: <90bedf1a51a12b2f2fab4a34b3f2402c33fa4f34.camel@redhat.com> Subject: Re: [PATCH v2 02/12] rv: Fix read_lock scope in per-task DA cleanup From: Gabriele Monaco To: Nam Cao Cc: Wen Yang , linux-kernel@vger.kernel.org, Steven Rostedt , linux-trace-kernel@vger.kernel.org Date: Fri, 29 May 2026 08:08:12 +0200 In-Reply-To: <87ldd3orft.fsf@yellow.woof> References: <20260527062313.39908-1-gmonaco@redhat.com> <20260527062313.39908-3-gmonaco@redhat.com> <87ldd3orft.fsf@yellow.woof> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.1 (3.60.1-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2026-05-28 at 10:43 +0200, Nam Cao wrote: > Gabriele Monaco writes: > > The da_monitor_reset_all() function for per-task monitors takes > > tasklist_lock while iterating over tasks, then keeps it also while > > iterating over idle tasks (one per CPU). The latter is not > > necessary > > since the lock needs to guard only for_each_process_thread(). > >=20 > > Use a scoped_guard for more compact syntax and adjust the scope > > only > > where the lock is necessary. > >=20 > > Fixes: 30984ccf31b7f ("rv: Refactor da_monitor to minimise macros") > > Fixes: 8259cb14a7068 ("rv: Reset per-task monitors also for idle > > tasks") >=20 > Fixes: tag "indicates that the patch fixes a bug in a previous > commit". There is no bug here, so I don't think Fixes tags are > applicable. Yeah good point, that isn't a real bug.. We're just holding a lock for a bit too long but there's no harm in that. Will remove the tags. Thanks, Gabriele >=20 > > Reviewed-by: Wen Yang > > Signed-off-by: Gabriele Monaco >=20 > Reviewed-by: Nam Cao