From: Shuah Khan <skhan@linuxfoundation.org>
To: paulmck@kernel.org
Cc: Christian Brauner <brauner@kernel.org>,
Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] selftests/pidfd: Fix duplicate-symbol warnings for SCHED_ CPP symbols
Date: Thu, 24 Jul 2025 12:26:21 -0600 [thread overview]
Message-ID: <90c793c3-91fd-4808-8fea-cbd07d2098e0@linuxfoundation.org> (raw)
In-Reply-To: <cc7e4fe7-299f-4bf3-af46-df6551d61997@paulmck-laptop>
On 7/23/25 17:13, Paul E. McKenney wrote:
> The pidfd selftests run in userspace and include both userspace and kernel
> header files. On some distros (for example, CentOS), this results in
> duplicate-symbol warnings in allmodconfig builds, while on other distros
> (for example, Ubuntu) it does not.
>
> Therefore, use #undef to get rid of the userspace definitions in favor
> of the kernel definitions.
>
> Other ways of handling this include splitting up the selftest code so
> that the userspace definitions go into one translation unit and the
> kernel definitions into another (which might or might not be feasible)
> or to adjust compiler command-line options to suppress the warnings
> (which might or might not be desirable).
>
> [ paulmck: Apply Shuah Khan feedback. ]
Looks good to me.
thanks,
-- Shuah
next prev parent reply other threads:[~2025-07-24 18:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 23:01 [PATCH RFC] " Paul E. McKenney
2025-07-18 21:03 ` Shuah Khan
2025-07-18 23:56 ` Paul E. McKenney
2025-07-23 23:13 ` [PATCH v2] " Paul E. McKenney
2025-07-24 18:26 ` Shuah Khan [this message]
2025-07-24 22:17 ` Shuah Khan
2025-07-24 23:29 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90c793c3-91fd-4808-8fea-cbd07d2098e0@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=brauner@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®