From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C12B643B6D2 for ; Tue, 18 Aug 2026 09:22:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787044970; cv=none; b=UvbmpNVNqmpmYPLfzeZ9SqKNqJKx+AZnCjLF75XL17LYz7WxXNNio+COHhgzGIJv67aAns7umsyyuPXoAv6+QiZMmgcSm7iL/a90vve5Jvf/aTByOReRjIywk87hTV6eHq/uNkFcuTkpmL353ytUP6OwFQMc/WCXZya7GUKI44U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787044970; c=relaxed/simple; bh=u6361v8Uib/n/iTfG4KC8YAYXaeOdYsfglkX/0VQSIc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OMSakjb37Tdf7ho5QSxZ2kEFOvVAW3/w/iZA5yo7r8gwTjEAf/AcCuREjKCnJ3XKNX9QMUJf+FKW/wT3DobXa0YrTGs2Eaq5hkZS6m8HqRRbv944Jz9ukh53Tx4PB1thOrtlXSTU0jMauoOT284Ue4X4MGybVjXFliwh8I9x4jw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WPKtT9T3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=V1Nt/R7A; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WPKtT9T3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="V1Nt/R7A" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67I8BJfr325459 for ; Tue, 18 Aug 2026 09:22:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OSIL9YTRSIWHiru5H07jwll9RFpqB+9Hr8pASO8MwNk=; b=WPKtT9T3+8xyOifs YQKEAdn0BU3kqC0MWAphRGIpJsxV4MGDUnxlbbwGG+c73SVtp/3ZIUEmLcemp3Lg hCvRYMpgr7Y2oVKEmHFRU6LBe4leLGdKY9hPx2nc9xCkp6ypzcFswd/8IVsUD16D 1oJCWtQEtLnY569SIwcaYAF7UxhnrcWKsLclYKdqQAC9ir3aI03TvJWDXDeEjB5z s/TaIladLl9xYoeA9mgtpMNLUlmFsGT+EYtn8nzwYkq+kPZsSsd2+hlWwrx0aV0v wuRa5Wj95iaZugys4V5J0GFn7vBHNvO8gZtvUrIhLkddusi0600P1mlQnD9V6v8u fYf00Q== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4eqtskg6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Aug 2026 09:22:47 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-936bd9b045fso3275085a.2 for ; Tue, 18 Aug 2026 02:22:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787044967; x=1787649767; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OSIL9YTRSIWHiru5H07jwll9RFpqB+9Hr8pASO8MwNk=; b=V1Nt/R7Av/1dpvANKX+cqLo0Ch5vxH+10O6hNhmoD6o9+w1biuCMsbvNI9V/zZZ/DL VycbiVIobti3PPvX57Zae0xobixytanb13ySkGDa+CNNvoPwO5gN0dCuAhS8tm4hk4oK GdB+zLYt38CqqbHxE44MyCs7WmW37rYqLs9nmajLjIDjguYh4cXqKbo8JxSwi6ggP2g2 uhf9bsDQWsH+XOoGqRiT2kiqi6rRJOS3SWLclA9+eGhns0wVNede8HZdsfZkkJuE5NX0 vcGmZzyMHZb7jLuphxFeG4svPBmKhiLd429Sfb/nkNmaphAodL+qaGyA/Fu6qLUeJ4nN 4stg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787044967; x=1787649767; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OSIL9YTRSIWHiru5H07jwll9RFpqB+9Hr8pASO8MwNk=; b=XQ7lQwnErBDypADUSMX3c/I5lxWFtzYX2pQr6SwLcdGGF9Ez6mvIqfYw9SrRfO6Of5 GEsIGWa4VBkag4HAd8KGcUV3dDUVplKNR5zLVzhwksubiY2sEW4sIodpon4N/dTVoRAa ZXUBaG+EkJnUwcRQMowh2b8UT+tfjsOBnKv0xuI2BUsK5Fco5cuLVLs2j7LSwyV0Cwe4 4vn5kasVq1sc2oY4meknPUdhPYR8lCARDzK4crBzSP9uwMc8SUX9WoQQWiRr7oCgv01E KbTCMYfMI26KjqzuxCs1frduml8Gou4r1D1YurMulUK6+7miM4mT5Pmf+1JhjBB59/vO UiMw== X-Forwarded-Encrypted: i=1; AHgh+Rp+tjO2Do3RyT6NtPA7G0x70n85VurytEYMj7MWDFJka+A71Fsv8kVg3eauOMVQ07IHD182dlwi8txjsCY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8SdWVN+rslkz5Eu+7ZUscDW7JQ8+yN8/4T5d9lZwz/OVe6ruK ohhS+GYIc2c5Mi3Ou69b03HDNdreeNIB9nfKctRS7RvLxZlIDYl/yws9Jsx+NCZFvWfhKIvG59t Vyc0QJJyO4pWYvuNETvRVKQM9JGYUNBTXeXSq82BM4MJSqhO8yv+tHF8o0aEAxDb/ScA= X-Gm-Gg: AR+sD134TsNQSsoMY/dWWLRE0vQyK0nE/MgZwHzNu4IpaMdwghWeuSZtMz2ohqL0xt4 yUC8XxvZF1i+v/x7YXki5PFC0q3hX56k5lLn++DufDHCGvkXd1AkTjvUEleSK2SNlu3T0Tk7B2g 0b7+MAVMtYbo9OzXUFywr4Fxj9TV3Q0Y+vmGtxd1hEPYQyy0VqMMvMbSpSP9Z3tSDSxlsoCOfjw 6BR2SJTV4uyfPdPVh8pM0/DMBTM+nQpJZhk60+0x0H2D9Rgna+YnCp5dtkt9cXiFgwOskzjIa/8 vMWWNbYa2S2Jv0qAz0RPWnsbek2Vr3hN2aCAmpDmhijkeHUWuirwjlbt+yMrVsde9qLfTYkNpx6 4SZaHDQKWDD/0cSe9wW1B97cZ X-Received: by 2002:a05:620a:45a8:b0:92b:7420:bd58 with SMTP id af79cd13be357-936d1ed8aa2mr2222532185a.0.1787044966860; Tue, 18 Aug 2026 02:22:46 -0700 (PDT) X-Received: by 2002:a05:620a:45a8:b0:92b:7420:bd58 with SMTP id af79cd13be357-936d1ed8aa2mr2222529885a.0.1787044966465; Tue, 18 Aug 2026 02:22:46 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a3d851767dsm1627320a12.5.2026.08.18.02.22.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Aug 2026 02:22:45 -0700 (PDT) Message-ID: <90c9dca7-5873-43eb-b9bf-1c8dd2c0093d@oss.qualcomm.com> Date: Tue, 18 Aug 2026 11:22:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: qcom: llcc-qcom: Handle errors from optional IRQ lookup To: phucduc.bui@gmail.com, Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260810051031.26656-1-phucduc.bui@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260810051031.26656-1-phucduc.bui@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODE4MDA2OCBTYWx0ZWRfX3cV8MXJasAv3 aqmZZ35p0Z+lL/awI6liKTKr9ItdcyRB4eXMVzAyH7a5q7O6oRng9MCNBOlWPwojZSJinWnndde x/DBqeqx9xji0aY6fLfU8JBQzpwvYwg= X-Proofpoint-ORIG-GUID: PGfow0zH786jQBz0M43m1k3KBkI3GLAz X-Authority-Analysis: v=2.4 cv=UfFhjqSN c=1 sm=1 tr=0 ts=6a842467 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=pGLkceISAAAA:8 a=hZ_HGFdO2wMKUaizlUUA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: PGfow0zH786jQBz0M43m1k3KBkI3GLAz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE4MDA2OCBTYWx0ZWRfX94Q0TJhyy9KO YhyoxDG+G2pOFVf5NYZdmjFSOLPR+8T6Q0p1sm+pnRtl0CHhY5+aeQaCHc5+O5P3iEEuRvCQgdn twEWCl/GyyK/71fS5EDZyziMKSztVEWNfqYWvHL82OdS27KGX2mDZ+XMbGgnOo7+DhM944EGrzw s+C6Pr8hKNKpWUwlyPypvHvhkgKY/D6DIqz9qiC9F0RNwZK0p5XLd1l7x4Tf67LNjo4iIfA5ZpL bAUdwy8iGnC0DCv2PpglasQ9LKwlf7uIN0SoTQKTJOarZ30sMiLlN4BSkQkUDb2tRCQkOjrQROr PQs7FxoGrffAkn6uemy29ho1gPSSlyMCTnqB+kn8K2lgu16Uk/7tsVc7g4lMo36s0nh73Ptzoge 8eHMJ5nxSwVvjEE6fe5fqpqJCUygxVBT+EEKHdXNlUJtWLyubISehyGGMUsL5BiBGSxvE3citnM 5PNw6Vq9kwb/XQRWZGg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-17_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 impostorscore=0 suspectscore=0 adultscore=0 spamscore=0 priorityscore=1501 clxscore=1015 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608180068 On 8/10/26 7:10 AM, phucduc.bui@gmail.com wrote: > From: bui duc phuc > > platform_get_irq_optional() can return errors such as -EPROBE_DEFER, > but the driver currently stores the return value directly in > drv_data->ecc_irq and continues probing. > > Propagate negative errors other than -ENXIO using dev_err_probe(), and > only assign the IRQ to drv_data->ecc_irq when a valid IRQ number is > returned. > > Signed-off-by: bui duc phuc > --- > drivers/soc/qcom/llcc-qcom.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c > index 8948b5fd42d2..e42946810b50 100644 > --- a/drivers/soc/qcom/llcc-qcom.c > +++ b/drivers/soc/qcom/llcc-qcom.c > @@ -5587,7 +5587,12 @@ static int qcom_llcc_probe(struct platform_device *pdev) > goto err; > } > > - drv_data->ecc_irq = platform_get_irq_optional(pdev, 0); > + ret = platform_get_irq_optional(pdev, 0); > + if (ret < 0 && ret != -ENXIO) > + return dev_err_probe(&pdev->dev, ret, "failed to get IRQ resource\n"); > + if (ret > 0) > + drv_data->ecc_irq = ret; Techinically you can drop the second if-statement Konrad