From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED6FD3002DC for ; Mon, 26 Jan 2026 10:55:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769424924; cv=none; b=khoTVxA6Pu2GtuKO+Uvj+Zz8c1eV3PNogK82K4ObohLx2dkuqF5q8EpU+3qkFrf5QoCUisSH0biETWVxRaQrrBUAzqpQOf7/ZHa262XZ81G/WGPz2EXiNgO4LcuZcIiMkBk4ss53Gk/FBKwrSLf5IveUxUFxxf9yutjT9exBfKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769424924; c=relaxed/simple; bh=eFMeGtFIFGJquwXlDim//AQP9KuI8WKVR8aq/1BCx10=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KEUNyA7WycUtvvUUjQzQRlNZZ7zmaHil61h9YSZCAR8cI0/8akTYQ7AcFzRqUtxF0dZr7vifpZMoJAXG4XeRRL2c6/FwEIxBCu2gTGO4N4SrDSIKvSyOtYIzlPyeL6DeTu1FJp3V4P05/4bBXD21xV+wjUlmeUz3kO91RNyirNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Jr5EMSTI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Sr6treNT; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Jr5EMSTI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Sr6treNT" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60Q9TNgx1307847 for ; Mon, 26 Jan 2026 10:55:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uZPXRfD10D1Dsj5FWFf81PZVjfVxlK6MiYVfjk3qR5g=; b=Jr5EMSTIJ2Uy+m6l hNzDWiB33joWqgG8fE9mV4QMtw4QLT8setVWu86wimUQSW46nSzTGphzzjZZ6KHG NKReh2mM4LtXGSWKevu6X0n6OQz8TO+43yR78rJ8XKI0d+olTpTZ5u/DyejUyHNA X0QZ/nLN0Q0EyPW8Rft0oj/z/gwAh9pwaYpMzICW5KlogxUz+47jMWTHWFVqkxGD H1VIT795KzNhfw2ygI3zym6wGqU8Y6RWnhvtRWsvTjXprOnXC/SAS0MHHXsB2Ue6 laAYQyL+mo4x/o2TerPungI9VNAF15LSLdm3iSv5FbNZtcHwgTfPxAh6afl+DLY2 VL+q3w== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bvq3hc8wu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 26 Jan 2026 10:55:20 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-88880bc706cso15069096d6.2 for ; Mon, 26 Jan 2026 02:55:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769424920; x=1770029720; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uZPXRfD10D1Dsj5FWFf81PZVjfVxlK6MiYVfjk3qR5g=; b=Sr6treNTHDR/mB6Px4sl6gap0rQtWuSUdBjDsnCzju3+kNI8Bt4T0vhSjxffBsaP6a QNcY4Kxy+Q95H9nv2mF5Fs/3aqP03Z+2Z+y+4aAFRy1y21JDLhxhndXGCrSLdQqcrqAO UGdObFLcHWs8Abh1AVTLstlgo+jMDFOEEnu9LF0Px4jrdH9fA/ae4/BG3asEVmCln4Pb Q+hssNCQm6dkp15FWyIm8EfjhxJvOh3KQJdJSw90UsL/NR4Fdwrc0i045MSfcdzd/weH ZAIgj3LNJoeWAW5yRGrjYZE+tGrogZnLNv+8PsZrP/TidngekSro3cqe2Gy3+rYp5sD1 wmYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769424920; x=1770029720; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uZPXRfD10D1Dsj5FWFf81PZVjfVxlK6MiYVfjk3qR5g=; b=vj+Fl9lAOUtggxNTA5LMRHgKBnyd8r1loq7OsZg6/yg0ZxAXvEXpb5lSt5foRhOTUb U5d9SwG28o8pg1MKwJz1UV+GtHFkkrxDIDuKnLRqgssI4JWKnvLXkkUBtoU2I/LXzvgi mKAt8weRnnpXR26QRkJmvH38i+6To2+6U1I2VuyzC81EDSGqDW4zD/p4+J89RjdHt+iD Ba37UsyZO5jDXSgEi26+69wXAM/O38EdCfh7M2sdkA3/OFWUuB8dDSJoDO+W3+DTqsmb 1vfxsRxnLl8ZKfh6bYxoeapt+UC6ZWb9xKIQExF9VuAlLbGT/W2wN9l8Dw9C91K1vWdg nzGA== X-Forwarded-Encrypted: i=1; AJvYcCXlGMWQFWov7c3rJQo1zHY4jaRqktH2i/vQT9PRrekGw9784pEzYJ2vLRx6D+TocHQur3a0hEeh+bnJIro=@vger.kernel.org X-Gm-Message-State: AOJu0Yyw/q0itCNcyEbaXzveZmA40wRMA9l4fDmSOwYyCrh91CZ/HL5a RbpSLUs3j1KVNX+rSKRBlIcjKVmKV568CU5shAVJQflevJBiuBz6ieas50/WBILJKYiYicoeHlf mJq8I0vndmYbBcg263adao2Ev7AuKXiIXTp2Vw/Z84zXSqIcTxXcBEYnBS6nFhpEHOeo= X-Gm-Gg: AZuq6aIAAasALJbtZUeO2o2rBCiQpz7zX01RUQoI9WYPaoExHlgP3fZCza20E3q3fVB 17LMb24DMJk+CPh10wSytc2KTA3nHHCrR9FLFqRgpLklDaCAmbvjGdEiyIWAFh/SoaHxNc0Iksd ce7UlbVjbH87m4Hnyf52ix/LaSofj4xEYOl9KXNuaN4QBrfmrZDQHsPYIVxqByzU4eVg6iAs6Br +lIeqfYfo7zDYoeP8Xh6YMt7ZNzz+5wEkduXoJez6yH0UlIqI5X4uHB90RCh0YVJQdjslZrEG0A Wv2ri1+ZqVBkMe1YxyEdyS7sAGT9tz62H8rQTIK7Typt/dXYNlWcH/ExAEdmIvYaVpeaE6SDDGY zXLxr9PSOz6j8FZfuEqGFj3ZLk4GFn9aUEH31UU34/dDRzSPZ9eyTQKZVZE8wx/I61OM= X-Received: by 2002:a05:6214:55c1:b0:894:a36b:f7df with SMTP id 6a1803df08f44-894b079435amr36883186d6.8.1769424920275; Mon, 26 Jan 2026 02:55:20 -0800 (PST) X-Received: by 2002:a05:6214:55c1:b0:894:a36b:f7df with SMTP id 6a1803df08f44-894b079435amr36883036d6.8.1769424919635; Mon, 26 Jan 2026 02:55:19 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-385d9faed52sm25102401fa.2.2026.01.26.02.55.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 02:55:19 -0800 (PST) Message-ID: <90c9fac9-3c55-492e-a0af-3d379164727e@oss.qualcomm.com> Date: Mon, 26 Jan 2026 11:55:15 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/7] arm64: dts: qcom: sc8280xp: Add Venus To: Dmitry Baryshkov , Taniya Das , Jagadeesh Kona Cc: Vikash Garodia , Dikshita Agarwal , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Abhinav Kumar , Bjorn Andersson , David Heidelberg , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , Bryan O'Donoghue References: <20260125-iris-sc8280xp-v3-0-d21861a9ea33@oss.qualcomm.com> <20260125-iris-sc8280xp-v3-4-d21861a9ea33@oss.qualcomm.com> <136bf12f-cead-4485-b689-af780c937e2d@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI2MDA5MyBTYWx0ZWRfX2iaKUbDq2N0E QPPvb4c8NIh/Ffp6I2zm1jtbvTOfOUwhm/LjWzTLkMHgc4cc5gptdF5Nglt0s6Bs9tI0nY2++3y f0GdBcR4OsIK1M66Y4DIjC2Ymvafyyr99ws23fLJ0odeRvVODWRJKGFyvdHotrIZn1wx+wlbZka uZnRYk6ngKbM6UnDBizEfThWzSpXRVLaOujbq9EDESdqe1iQKktgB/Di8PDizihfmpLJM0+wRaM 0mxMb7AfkkEigg51POKjddLKsVuR0DsVnc3dngBpwSV1FJaksxxDg1wMS0RuEmPSNqfOCTpS8xa 7NSst29ndnoD6ouYzbovl6vRdT7GOvHBPzl0oqSVBowWuSFEC1OU8s6kQ7vnDA+vclxwcoYMeT5 SQ98iDtC+murB0nLDh7UWzBzZa1VuRSo1KuYG1I8qpGyCzqC2pEXOfatoZYLqm27lKNaY+FVMjv dLz0keMvTsazueaN2KA== X-Proofpoint-ORIG-GUID: Uw3h2YDO7z8zXcQYw-wTRB9VLlO4UISp X-Proofpoint-GUID: Uw3h2YDO7z8zXcQYw-wTRB9VLlO4UISp X-Authority-Analysis: v=2.4 cv=c/imgB9l c=1 sm=1 tr=0 ts=69774818 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=BXNv1TGYQw0SXM4-lsYA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-26_02,2026-01-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601260093 On 1/26/26 11:47 AM, Dmitry Baryshkov wrote: > On Mon, Jan 26, 2026 at 11:00:25AM +0100, Konrad Dybcio wrote: >> On 1/25/26 4:33 PM, Dmitry Baryshkov wrote: >>> From: Konrad Dybcio >>> >>> Add the required nodes to enable Venus on sc8280xp. >>> >>> [ bod: added interconnect tags ] >>> >>> Signed-off-by: Konrad Dybcio >>> [ johan: use sm8350 videocc defines ] >>> Signed-off-by: Johan Hovold >>> [ bod: dropped video encoder/decoder declarations ] >>> Signed-off-by: Bryan O'Donoghue >>> [ db: dropped llcc icc, switched to sc8280xp compat, added more freqs ] >>> Signed-off-by: Dmitry Baryshkov >>> --- >> >> [...] >> >>> + venus_opp_table: opp-table { >>> + compatible = "operating-points-v2"; >>> + >>> + opp-720000000 { >>> + opp-hz = /bits/ 64 <720000000>; >> >> You need to div3 all of these, otherwise this LOW_SVS OPP >> will actually apply a more-than-TURBO_L1-requiring frequency.. > > Hmm, is the OPP table for SM8250 then also incorrect? The OPP-set clock is "vcodec0_core" The DT references VIDEO_CC_MVS0_CLK, which is a branch-child of video_cc_mvs0_div_clk_src, so that sounds like it makes sense.. And the frequency plan concurs that. > > I cross-checked SM8250 and Kodiak against, msm-4.19 and msm-5.4 > correspondignly, the OPP tables are written in the same way. > >> >> [...] >>> + videocc: clock-controller@abf0000 { >>> + compatible = "qcom,sc8280xp-videocc"; >>> + reg = <0 0x0abf0000 0 0x10000>; >>> + clocks = <&rpmhcc RPMH_CXO_CLK>, >>> + <&rpmhcc RPMH_CXO_CLK_A>, >>> + <&sleep_clk>; >>> + power-domains = <&rpmhpd SC8280XP_MMCX>; >>> + required-opps = <&rpmhpd_opp_low_svs>; >> >> AFAICS the PLLs will not turn on if *MX* is at < LOWSVS, but they still >> need to be scaled 1:1 with MMCX as the freuqency rises, so you need to >> wire up 2 power domains to the OPP table > > I don't see this being done for SM8250, should it also be fixed? On > SM8550 we indeed manage MMCX and MX together. Should SC7280 also scale > both CX and MX together? 8250 yes On kodiak, the docs strangely say that it's *all* powered by CX, maybe +Taniya or +Jagadeesh could confirm if that's right Konrad