From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757440AbcILIZI (ORCPT ); Mon, 12 Sep 2016 04:25:08 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:42548 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757151AbcILIZG (ORCPT ); Mon, 12 Sep 2016 04:25:06 -0400 Subject: Re: [PATCH -next] drm/tilcdc: Fix non static symbol warning To: Wei Yongjun , Tomi Valkeinen , David Airlie References: <1473510777-25444-1-git-send-email-weiyj.lk@gmail.com> CC: Wei Yongjun , , From: Jyri Sarha Message-ID: <90cd5805-32a1-2b9a-dd4b-abd477d9c90e@ti.com> Date: Mon, 12 Sep 2016 11:24:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1473510777-25444-1-git-send-email-weiyj.lk@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/10/16 15:32, Wei Yongjun wrote: > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/gpu/drm/tilcdc/tilcdc_drv.c:64:5: warning: > symbol 'tilcdc_atomic_check' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun I'll pick this up. Thanks, Jyri > --- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > index 4405e4b..dc58770 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > @@ -61,8 +61,8 @@ static void tilcdc_fb_output_poll_changed(struct drm_device *dev) > drm_fbdev_cma_hotplug_event(priv->fbdev); > } > > -int tilcdc_atomic_check(struct drm_device *dev, > - struct drm_atomic_state *state) > +static int tilcdc_atomic_check(struct drm_device *dev, > + struct drm_atomic_state *state) > { > int ret; > > > >