From: Florian Vaussard <florian.vaussard@gmail.com>
To: Dan Murphy <dmurphy@ti.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Florian Vaussard <florian.vaussard@heig-vd.ch>
Subject: Re: [PATCH 0/2] Input: drv266x: Fix misuse of regmap_update_bits
Date: Tue, 29 Nov 2016 18:24:16 +0100 [thread overview]
Message-ID: <90cd6727-4394-1b93-b6fb-1c3d870df229@gmail.com> (raw)
In-Reply-To: <583DB6A3.8070305@ti.com>
Hello Dan,
Le 29. 11. 16 à 18:10, Dan Murphy a écrit :
> Florian
>
> On 11/29/2016 10:59 AM, Florian Vaussard wrote:
>> Hello,
>>
>> This series fixes similar misues of the regmap_update_bits() API found
>> inside the drv2665.c and drv2667.c drivers. More details can be found
>> in the message of each patch.
>>
>> Theses changes are not tested as I do not have the required hardware,
>> but the calls to regmap_update_bits() are clearly wrong in the current
>> code and the fix seems obvious. Any tests are warmly welcome.
>>
>> Best regards,
>> Florian
>>
>> Florian Vaussard (2):
>> Input: drv2665: Fix misuse of regmap_update_bits
>> Input: drv2667: Fix misuse of regmap_update_bits
>
> Thanks for the patches what about the drv260x.c?
>
>From what I can see, drv260x.c does not have such a bug. The calls to
regmap_update_bits(.., mask, value) in drv260x.c where value > 0 are using
DRV260X_LIB_SEL_MASK and DRV260X_STANDBY_MASK as masks. In both cases, the range
of 'value' is such that (mask & value) is not null (if 'value' is not null of
course). Thus no obvious problems here.
Best regards,
Florian
prev parent reply other threads:[~2016-11-29 17:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 16:59 Florian Vaussard
2016-11-29 16:59 ` [PATCH 1/2] Input: drv2665: " Florian Vaussard
2016-11-30 1:39 ` Dmitry Torokhov
2016-11-29 16:59 ` [PATCH 2/2] Input: drv2667: " Florian Vaussard
2016-11-30 1:39 ` Dmitry Torokhov
2016-11-29 17:10 ` [PATCH 0/2] Input: drv266x: " Dan Murphy
2016-11-29 17:24 ` Florian Vaussard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90cd6727-4394-1b93-b6fb-1c3d870df229@gmail.com \
--to=florian.vaussard@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dmurphy@ti.com \
--cc=florian.vaussard@heig-vd.ch \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®